From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#39683: [PATCH] Add NOFOLLOW flag to set-file-modes etc. Date: Thu, 20 Feb 2020 16:51:53 +0200 Message-ID: <831rqpl3au.fsf@gnu.org> References: <20200220003400.265566-1-eggert@cs.ucla.edu> Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="44317"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 39683@debbugs.gnu.org To: Paul Eggert Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Feb 20 15:53:12 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1j4nCS-000BQG-9a for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 20 Feb 2020 15:53:12 +0100 Original-Received: from localhost ([::1]:43680 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j4nCR-0005uA-Aw for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 20 Feb 2020 09:53:11 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:44222) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j4nCK-0005t5-3w for bug-gnu-emacs@gnu.org; Thu, 20 Feb 2020 09:53:04 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1j4nCI-0003Ai-9f for bug-gnu-emacs@gnu.org; Thu, 20 Feb 2020 09:53:04 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:38193) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1j4nCI-0003AP-6d for bug-gnu-emacs@gnu.org; Thu, 20 Feb 2020 09:53:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1j4nCI-000680-0t for bug-gnu-emacs@gnu.org; Thu, 20 Feb 2020 09:53:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 20 Feb 2020 14:53:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 39683 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 39683-submit@debbugs.gnu.org id=B39683.158221034823515 (code B ref 39683); Thu, 20 Feb 2020 14:53:01 +0000 Original-Received: (at 39683) by debbugs.gnu.org; 20 Feb 2020 14:52:28 +0000 Original-Received: from localhost ([127.0.0.1]:44166 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1j4nBj-00067C-KY for submit@debbugs.gnu.org; Thu, 20 Feb 2020 09:52:27 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:57278) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1j4nBh-00066y-S3 for 39683@debbugs.gnu.org; Thu, 20 Feb 2020 09:52:26 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:60078) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1j4nBb-0002jv-SF; Thu, 20 Feb 2020 09:52:19 -0500 Original-Received: from [176.228.60.248] (port=2290 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1j4nBQ-0002D3-CY; Thu, 20 Feb 2020 09:52:19 -0500 In-reply-to: <20200220003400.265566-1-eggert@cs.ucla.edu> (message from Paul Eggert on Wed, 19 Feb 2020 16:34:00 -0800) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:176294 Archived-At: > From: Paul Eggert > Date: Wed, 19 Feb 2020 16:34:00 -0800 > Cc: Paul Eggert > > diff --git a/lisp/dired-aux.el b/lisp/dired-aux.el > index 0069c1744d..de5e8bb567 100644 > --- a/lisp/dired-aux.el > +++ b/lisp/dired-aux.el > @@ -409,7 +409,8 @@ dired-do-chmod > (set-file-modes > file > (if num-modes num-modes > - (file-modes-symbolic-to-number modes (file-modes file))))) > + (file-modes-symbolic-to-number modes (file-modes file t))) Can we please use some descriptive symbol, like 'nofollow, instead of just t? I expect that to save at least some of us an extra read of the doc string each time we see such code. TIA