From: Eli Zaretskii <eliz@gnu.org>
To: Paul Eggert <eggert@cs.ucla.edu>
Cc: 39683@debbugs.gnu.org
Subject: bug#39683: [PATCH] Add NOFOLLOW flag to set-file-modes etc.
Date: Thu, 20 Feb 2020 16:51:53 +0200 [thread overview]
Message-ID: <831rqpl3au.fsf@gnu.org> (raw)
In-Reply-To: <20200220003400.265566-1-eggert@cs.ucla.edu> (message from Paul Eggert on Wed, 19 Feb 2020 16:34:00 -0800)
> From: Paul Eggert <eggert@cs.ucla.edu>
> Date: Wed, 19 Feb 2020 16:34:00 -0800
> Cc: Paul Eggert <eggert@cs.ucla.edu>
>
> diff --git a/lisp/dired-aux.el b/lisp/dired-aux.el
> index 0069c1744d..de5e8bb567 100644
> --- a/lisp/dired-aux.el
> +++ b/lisp/dired-aux.el
> @@ -409,7 +409,8 @@ dired-do-chmod
> (set-file-modes
> file
> (if num-modes num-modes
> - (file-modes-symbolic-to-number modes (file-modes file)))))
> + (file-modes-symbolic-to-number modes (file-modes file t)))
Can we please use some descriptive symbol, like 'nofollow, instead of
just t? I expect that to save at least some of us an extra read of
the doc string each time we see such code.
TIA
next prev parent reply other threads:[~2020-02-20 14:51 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-20 0:34 bug#39683: [PATCH] Add NOFOLLOW flag to set-file-modes etc Paul Eggert
2020-02-20 14:51 ` Eli Zaretskii [this message]
2020-02-24 0:50 ` Paul Eggert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=831rqpl3au.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=39683@debbugs.gnu.org \
--cc=eggert@cs.ucla.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.