From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#40914: 27.0.91; erc send is failing on pretest Date: Tue, 28 Apr 2020 19:10:48 +0300 Message-ID: <831ro7381j.fsf@gnu.org> References: <86zhawr2li.fsf@gmail.com> <83blnc2cy8.fsf@gnu.org> <86wo5z1ui7.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="19759"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 40914@debbugs.gnu.org To: =?UTF-8?Q?andr=C3=A9s_?= =?UTF-8?Q?ram=C3=ADrez?= Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Apr 28 18:17:46 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jTSvY-0004yZ-NE for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 28 Apr 2020 18:17:44 +0200 Original-Received: from localhost ([::1]:37180 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jTSvX-00057y-O3 for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 28 Apr 2020 12:17:43 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:59296) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jTStj-00037a-Qj for bug-gnu-emacs@gnu.org; Tue, 28 Apr 2020 12:16:45 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.90_1) (envelope-from ) id 1jTSq3-00019g-FD for bug-gnu-emacs@gnu.org; Tue, 28 Apr 2020 12:15:51 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:57827) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jTSq2-00019b-TW for bug-gnu-emacs@gnu.org; Tue, 28 Apr 2020 12:12:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jTSq2-0005BO-No for bug-gnu-emacs@gnu.org; Tue, 28 Apr 2020 12:12:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 28 Apr 2020 16:12:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 40914 X-GNU-PR-Package: emacs Original-Received: via spool by 40914-submit@debbugs.gnu.org id=B40914.158809027819853 (code B ref 40914); Tue, 28 Apr 2020 16:12:02 +0000 Original-Received: (at 40914) by debbugs.gnu.org; 28 Apr 2020 16:11:18 +0000 Original-Received: from localhost ([127.0.0.1]:41140 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jTSpK-0005A9-20 for submit@debbugs.gnu.org; Tue, 28 Apr 2020 12:11:18 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:55780) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jTSpI-00059x-9s for 40914@debbugs.gnu.org; Tue, 28 Apr 2020 12:11:16 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:34403) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jTSpC-0007wb-0n; Tue, 28 Apr 2020 12:11:10 -0400 Original-Received: from [176.228.60.248] (port=4963 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1jTSpA-0006Uv-VN; Tue, 28 Apr 2020 12:11:09 -0400 In-Reply-To: <86wo5z1ui7.fsf@gmail.com> (message from =?UTF-8?Q?andr=C3=A9s_?= =?UTF-8?Q?ram=C3=ADrez?= on Tue, 28 Apr 2020 15:48:32 +0000) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:179221 Archived-At: > From: andrés ramírez > Cc: 40914@debbugs.gnu.org > Date: Tue, 28 Apr 2020 15:48:32 +0000 > > Eli> What does the following yield in a session that fails like > Eli> this? > > Eli> M-: (erc-coding-system-for-target nil) RET > > --8<---------------cut here---------------start------------->8--- > utf-8 > --8<---------------cut here---------------end--------------->8--- That's the problem. The question is: how did that happen? And here's the answer: > (setq > erc-nick-uniquifier "_" > erc-kill-queries-on-quit t > erc-server-coding-system (quote utf-8) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ So does the patch below fix the problem? diff --git a/lisp/erc/erc-backend.el b/lisp/erc/erc-backend.el index 0e3495e..526e854 100644 --- a/lisp/erc/erc-backend.el +++ b/lisp/erc/erc-backend.el @@ -466,7 +466,8 @@ erc-split-line The length is specified in `erc-split-line-length'. Currently this is called by `erc-send-input'." - (let ((charset (car (erc-coding-system-for-target nil)))) + (let* ((coding (erc-coding-system-for-target nil)) + (charset (if (consp coding) (car coding) coding))) (with-temp-buffer (insert longline) ;; The line lengths are in octets, not characters (because these