all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: "andrés ramírez" <rrandresf@gmail.com>
Cc: 40914@debbugs.gnu.org
Subject: bug#40914: 27.0.91; erc send is failing on pretest
Date: Tue, 28 Apr 2020 19:10:48 +0300	[thread overview]
Message-ID: <831ro7381j.fsf@gnu.org> (raw)
In-Reply-To: <86wo5z1ui7.fsf@gmail.com> (message from andrés ramírez on Tue, 28 Apr 2020 15:48:32 +0000)

> From: andrés ramírez <rrandresf@gmail.com>
> Cc: 40914@debbugs.gnu.org
> Date: Tue, 28 Apr 2020 15:48:32 +0000
> 
>     Eli> What does the following yield in a session that fails like
>     Eli> this?
> 
>     Eli>   M-: (erc-coding-system-for-target nil) RET
> 
> --8<---------------cut here---------------start------------->8---
> utf-8
> --8<---------------cut here---------------end--------------->8---

That's the problem.  The question is: how did that happen?

And here's the answer:

>   (setq
>    erc-nick-uniquifier "_"
>    erc-kill-queries-on-quit t
>    erc-server-coding-system (quote utf-8)
     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

So does the patch below fix the problem?

diff --git a/lisp/erc/erc-backend.el b/lisp/erc/erc-backend.el
index 0e3495e..526e854 100644
--- a/lisp/erc/erc-backend.el
+++ b/lisp/erc/erc-backend.el
@@ -466,7 +466,8 @@ erc-split-line
 The length is specified in `erc-split-line-length'.
 
 Currently this is called by `erc-send-input'."
-  (let ((charset (car (erc-coding-system-for-target nil))))
+  (let* ((coding (erc-coding-system-for-target nil))
+         (charset (if (consp coding) (car coding) coding)))
     (with-temp-buffer
       (insert longline)
       ;; The line lengths are in octets, not characters (because these





  reply	other threads:[~2020-04-28 16:10 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-27 22:22 bug#40914: 27.0.91; erc send is failing on pretest Andrés Ramírez
2020-04-28  9:10 ` Eli Zaretskii
2020-04-28 15:48   ` andrés ramírez
2020-04-28 16:10     ` Eli Zaretskii [this message]
2020-04-28 17:03       ` andrés ramírez
2020-04-28 17:25         ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=831ro7381j.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=40914@debbugs.gnu.org \
    --cc=rrandresf@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.