From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#41276: Acknowledgement ([PATCH 0/9] Various small improvements to EasyPG) Date: Fri, 15 May 2020 20:42:11 +0300 Message-ID: <831rnlgkng.fsf@gnu.org> References: <20200514191325.22061-1-jonas@bernoul.li> <87sgg26zpv.fsf@bernoul.li> <83o8qp3bgq.fsf@gnu.org> <87pnb5781d.fsf@bernoul.li> <83wo5d1klq.fsf@gnu.org> <87lflt6st5.fsf@bernoul.li> Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="58031"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 41276@debbugs.gnu.org To: Jonas Bernoulli Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri May 15 19:43:10 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jZeMX-000Ezp-UT for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 15 May 2020 19:43:09 +0200 Original-Received: from localhost ([::1]:60024 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jZeMW-00026z-TK for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 15 May 2020 13:43:08 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:47362) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jZeMQ-00026s-PT for bug-gnu-emacs@gnu.org; Fri, 15 May 2020 13:43:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:55358) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jZeMQ-0005Is-Gr for bug-gnu-emacs@gnu.org; Fri, 15 May 2020 13:43:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jZeMQ-000271-Ez for bug-gnu-emacs@gnu.org; Fri, 15 May 2020 13:43:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 15 May 2020 17:43:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 41276 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 41276-submit@debbugs.gnu.org id=B41276.15895645538084 (code B ref 41276); Fri, 15 May 2020 17:43:02 +0000 Original-Received: (at 41276) by debbugs.gnu.org; 15 May 2020 17:42:33 +0000 Original-Received: from localhost ([127.0.0.1]:38671 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jZeLx-00026J-9J for submit@debbugs.gnu.org; Fri, 15 May 2020 13:42:33 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:39912) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jZeLu-000261-Ki for 41276@debbugs.gnu.org; Fri, 15 May 2020 13:42:31 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:46631) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jZeLo-0004gg-Ts; Fri, 15 May 2020 13:42:24 -0400 Original-Received: from [176.228.60.248] (port=1404 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1jZeLo-0006dg-Ba; Fri, 15 May 2020 13:42:24 -0400 In-Reply-To: <87lflt6st5.fsf@bernoul.li> (message from Jonas Bernoulli on Fri, 15 May 2020 18:56:06 +0200) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:180345 Archived-At: > From: Jonas Bernoulli > Cc: 41276@debbugs.gnu.org > Date: Fri, 15 May 2020 18:56:06 +0200 > > > Right, that's the header line. I meant the part after it, which > > mentions the file(s) and the function(s) where the changes are done. > > I can only see one commit that lacks a commit message body in addition > to the commit message summary line. > > [I am a little confused because while I agree that I failed to follow > the conventions and need to fix that, you do talk about multiple commits > that have this particular defect while I can see only a single commit, > which might potentially have that defect.] > > The subject of the respective mail is: > > [PATCH 3/9] * lisp/epg-config.el (epg-config--make-gpg-configuration): Fix indentation Ah, okay. Please forgive me, I almost never read the Subject line, and expect all the important stuff to be in the body. So I will blame Git in this case ;-) > However I feel it would make more sense for the first rule to override > the second. From recent commits it looks like you and some others seem > to agree with me: > > ,---- > | ; * src/xdisp.c: Improve the introductory commentary. > `---- > > but Stefan does not: > > ,---- > | * lisp/emacs-lisp/pcase.el (pcase--fgrep): Look inside vectors > `---- You need to keep in mind how these are used: they are copied into the ChangeLog file we generate when we are about to release a new Emacs version. So if the header line is followed by a series of ChangeLog-formatted entries, it should not end in a period, but when the header line is _itself_ a ChangeLog-formatted entry, then it should follow the ChangeLog rules, which is that every entry shall end in a period. IOW, the second rule in this case overrides the first. And while we are at that: please don't follow examples like this: * foobarbz/barfooquux/baz.xx (some_long_function_name): Fix this and that. That is, if the log entry takes more than one line, do NOT try to avoid adding the header line by "reusing" the first line of the entry as a header line, and leaving an empty line between the first line of the log message and the rest of them. The reason is still the same: this will look awkward, to say the least, in the generated ChangeLog.