Current documentation of current emacs patch-submission procedures?

Current documentation of current emacs patch-submission procedures?

[Ken Manheimer]

[-- Attachment #1: Type: text/plain, Size: 1352 bytes --]

Hi! After a long while since submitting patches (for allout.el and related
stuff) I have a few new ones to submit, and am trying to track down
canonical guidance on proper procedures for submitting them. (This was
spurred by bug@11312 <https://debbugs.gnu.org/cgi/bugreport.cgi?bug=11312>,
but I have some fixes for independent bugs as well.)

Traversing a maze of twisty passages (all vaguely similar) I found my way
to Sending Patches
<https://www.gnu.org/software/emacs/manual/html_node/emacs/Sending-Patches.html>,
which describes a process that seems like what I used to do. But I'm
perplexed when it comes to the part that mentions "commit log" with links
to Change Log
<https://www.gnu.org/software/emacs/manual/html_node/emacs/Change-Log.html>
(and
Change Log Concepts
<https://www.gnu.org/software/emacs/manual/html_node/emacs/Change-Log.html#Change-Log>
in
a few ways!), seemingly interchangeably, particularly because the
lisp/Changelog.* files in my current checkout of the git repository (with
new commits from yesterday, for instance) have no updates since Emacs 24.3,
as far as I can see.

I'm guessing that I should put the equivalent of what would have been in
the ChangeLog in the commit messages, but thought I'd ask here for proper
guidance. I welcome pointers to documents I missed that would have made
this simpler, as well!

Ken

[-- Attachment #2: Type: text/html, Size: 1583 bytes --]

Re: Current documentation of current emacs patch-submission procedures?

[Eli Zaretskii]

> From: Ken Manheimer <ken.manheimer@gmail.com>
> Date: Sun, 5 Jul 2020 12:07:47 -0400
> 
> Hi! After a long while since submitting patches (for allout.el and related stuff) I have a few new ones to
> submit, and am trying to track down canonical guidance on proper procedures for submitting them. (This
> was spurred by bug@11312, but I have some fixes for independent bugs as well.)
> 
> Traversing a maze of twisty passages (all vaguely similar) I found my way to Sending Patches, which
> describes a process that seems like what I used to do. But I'm perplexed when it comes to the part that
> mentions "commit log" with links to Change Log (and Change Log Concepts in a few ways!), seemingly
> interchangeably, particularly because the lisp/Changelog.* files in my current checkout of the git repository
> (with new commits from yesterday, for instance) have no updates since Emacs 24.3, as far as I can see.
> 
> I'm guessing that I should put the equivalent of what would have been in the ChangeLog in the commit
> messages, but thought I'd ask here for proper guidance. I welcome pointers to documents I missed that
> would have made this simpler, as well!

Yes.  Try reading CONTRIBUTE in the repository, I hope it is less
confusing.  You can also look at the style of commit log messages with
"git log".

Thanks.

Re: Current documentation of current emacs patch-submission procedures?

[Ken Manheimer]

[-- Attachment #1: Type: text/plain, Size: 1208 bytes --]

On Sun, Jul 5, 2020 at 12:23 PM Eli Zaretskii <eliz@gnu.org> wrote:

> > From: Ken Manheimer <ken.manheimer@gmail.com>
> > Date: Sun, 5 Jul 2020 12:07:47 -0400
> >
> > Hi! After a long while since submitting patches (for allout.el and
> related stuff) I have a few new ones to
> > submit, and am trying to track down canonical guidance on proper
> procedures for submitting them. (This
> > was spurred by bug@11312, but I have some fixes for independent bugs as
> well.)
> > [...]
> > I'm guessing that I should put the equivalent of what would have been in
> the ChangeLog in the commit
> > messages, but thought I'd ask here for proper guidance. I welcome
> pointers to documents I missed that
> > would have made this simpler, as well!
>
> Yes.  Try reading CONTRIBUTE in the repository, I hope it is less
> confusing.  You can also look at the style of commit log messages with
> "git log".
>

CONTRIBUTE seems to be more current and clear. Together with
your confirmation, I feel I have the info I need. (It might make sense to
put notes in documents like Submitting Patches deferring to CONTRIBUTE,
though that might also require some time and attention to reconcile them...)


> Thanks.
>

Thank you!

[-- Attachment #2: Type: text/html, Size: 1801 bytes --]