From: Eli Zaretskii <eliz@gnu.org>
To: Tino Calancha <tino.calancha@gmail.com>
Cc: 42655@debbugs.gnu.org, eggert@cs.ucla.edu,
monnier@iro.umontreal.ca, uyennhi.qm@gmail.com
Subject: bug#42655: 27.1; iconify-frame on a Lucid build may stuck the frame
Date: Sun, 02 Aug 2020 17:34:16 +0300 [thread overview]
Message-ID: <831rkpce1j.fsf@gnu.org> (raw)
In-Reply-To: <87mu3dfb6z.fsf@gmail.com> (message from Tino Calancha on Sun, 02 Aug 2020 15:07:32 +0200)
> From: Tino Calancha <tino.calancha@gmail.com>
> Date: Sun, 02 Aug 2020 15:07:32 +0200
> Cc: paul eggert <eggert@cs.ucla.edu>, stefan monnier <monnier@iro.umontreal.ca>,
> uyennhi.qm@gmail.com
>
> Tino Calancha <tino.calancha@gmail.com> writes:
>
> > emacs -Q
> > C-z
> > ;; select again the window displaying the Emacs GUI
> > -------------------------------------------------------------------------------
> >
> > - You cannot insert characters in the *scratch* buffer.
> > - Normal movement, for intance, `C-n' or `C-f' doesn't work.
>
> It is a regression from Emacs 26.? with the following commit:
>
> commit dee8674414fae2323fd9cbf05aa762e72fa575e5
> Author: Stefan Monnier <monnier@iro.umontreal.ca>
> Date: Thu Feb 23 21:17:04 2017 -0500
>
> Minor redisplay optimisations
>
> * src/frame.c (Ficonify_frame): No need to redisplay everything.
>
> The following patch fixed it:
>
> --8<-----------------------------cut here---------------start------------->8---
> commit 96e56d237d27d0873914319812a576969f60486f
> Author: Tino Calancha <ccalancha@suse.com>
> Date: Sun Aug 2 14:45:56 2020 +0200
>
> Notify when a frame is iconified in Lucid builds
>
> If Emacs is built without x toolkit or built with Lucid,
> then we have to notify when a frame is iconified (Bug#42655).
> - src/frame (iconify-frame):
> Set windows_or_buffers_changed to a non-zero value.
>
> diff --git a/src/frame.c b/src/frame.c
> index 4dd8bb1804..640aa5c4e3 100644
> --- a/src/frame.c
> +++ b/src/frame.c
> @@ -2738,6 +2738,11 @@ DEFUN ("iconify-frame", Ficonify_frame, Siconify_frame,
> if (FRAME_WINDOW_P (f) && FRAME_TERMINAL (f)->iconify_frame_hook)
> FRAME_TERMINAL (f)->iconify_frame_hook (f);
>
> +#if (!defined USE_X_TOOLKIT || defined USE_LUCID) /* (Bug#42655) */
> + /* Make menu bar update for the Buffers and Frames menus. */
> + windows_or_buffers_changed = 17;
> +#endif
Thanks, but I'm afraid this is not necessarily TRT. You simply revert
part of Stefan's change for some configurations, but I don't
understand why not setting windows_or_buffers_changed affects Lucid,
but not GTK. Did you succeed in understanding the reason?
And btw, why do you also add this for non-toolkit builds: did you see
the same problem in that configuration?
next prev parent reply other threads:[~2020-08-02 14:34 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-01 18:46 bug#42655: 27.1; iconify-frame on a Lucid build may stuck the frame Tino Calancha
2020-08-01 18:53 ` Eli Zaretskii
2020-08-02 13:07 ` Tino Calancha
2020-08-02 14:34 ` Eli Zaretskii [this message]
2020-08-03 19:46 ` Tino Calancha
2020-08-03 21:29 ` Stefan Monnier
2020-08-04 2:21 ` Eli Zaretskii
2020-08-04 3:59 ` Eli Zaretskii
2020-08-04 14:20 ` Eli Zaretskii
2020-08-04 15:14 ` Bhavin Gandhi
2020-08-04 16:40 ` Eli Zaretskii
2020-08-04 18:53 ` Bhavin Gandhi
2020-08-04 19:07 ` Eli Zaretskii
2020-08-05 17:23 ` Bhavin Gandhi
2020-08-05 18:43 ` Eli Zaretskii
2020-08-05 18:57 ` Tino Calancha
2020-08-06 2:29 ` Eli Zaretskii
2020-08-06 5:41 ` Bhavin Gandhi
2020-08-06 7:43 ` Eli Zaretskii
2020-08-06 8:13 ` Tino Calancha
2020-08-06 13:47 ` Eli Zaretskii
2020-08-06 13:57 ` Eli Zaretskii
2020-08-06 14:18 ` Tino Calancha
2020-08-06 14:37 ` Tino Calancha
2020-08-07 5:53 ` Eli Zaretskii
2020-08-07 11:47 ` Tino Calancha
2020-08-07 12:05 ` Eli Zaretskii
2020-08-07 12:20 ` Bhavin Gandhi
2020-08-07 14:01 ` Tino Calancha
2020-08-07 15:06 ` Eli Zaretskii
2020-08-08 11:52 ` Tino Calancha
2020-08-09 14:26 ` Eli Zaretskii
2020-08-10 17:52 ` Tino Calancha
2020-08-12 16:50 ` Eli Zaretskii
2020-08-15 14:23 ` Tino Calancha
2020-08-05 18:24 ` Tino Calancha
2020-08-05 18:31 ` Bhavin Gandhi
2020-08-05 18:34 ` Tino Calancha
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=831rkpce1j.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=42655@debbugs.gnu.org \
--cc=eggert@cs.ucla.edu \
--cc=monnier@iro.umontreal.ca \
--cc=tino.calancha@gmail.com \
--cc=uyennhi.qm@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.