From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#43702: Emacs master: Incorrect highlighting in regexp isearch. Date: Wed, 07 Oct 2020 12:14:11 +0300 Message-ID: <831ria9z4s.fsf@gnu.org> References: <20200929121317.GA27007@ACM> <83wo0ck5ig.fsf@gnu.org> <20200929153355.GB27007@ACM> <87y2ks819k.fsf@gnus.org> <87y2krdqsk.fsf@mail.linkov.net> <87y2kp93dn.fsf@mail.linkov.net> <87mu0z3zxf.fsf@mail.linkov.net> <83ft6qa4ky.fsf@gnu.org> <87imbmqvki.fsf@mail.linkov.net> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="23051"; mail-complaints-to="usenet@ciao.gmane.io" Cc: acm@muc.de, larsi@gnus.org, 43702@debbugs.gnu.org To: Juri Linkov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Oct 07 11:15:23 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kQ5Xf-0005oO-6f for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 07 Oct 2020 11:15:23 +0200 Original-Received: from localhost ([::1]:57768 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kQ5Xe-00035L-9L for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 07 Oct 2020 05:15:22 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:56686) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kQ5XK-0002q4-2n for bug-gnu-emacs@gnu.org; Wed, 07 Oct 2020 05:15:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:43686) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kQ5XJ-0006II-OY for bug-gnu-emacs@gnu.org; Wed, 07 Oct 2020 05:15:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kQ5XJ-0000vU-K3 for bug-gnu-emacs@gnu.org; Wed, 07 Oct 2020 05:15:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 07 Oct 2020 09:15:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 43702 X-GNU-PR-Package: emacs Original-Received: via spool by 43702-submit@debbugs.gnu.org id=B43702.16020620583491 (code B ref 43702); Wed, 07 Oct 2020 09:15:01 +0000 Original-Received: (at 43702) by debbugs.gnu.org; 7 Oct 2020 09:14:18 +0000 Original-Received: from localhost ([127.0.0.1]:55232 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kQ5Wb-0000uF-Pn for submit@debbugs.gnu.org; Wed, 07 Oct 2020 05:14:18 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:49728) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kQ5WX-0000tx-UM for 43702@debbugs.gnu.org; Wed, 07 Oct 2020 05:14:16 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:42159) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kQ5WR-0006BW-1W; Wed, 07 Oct 2020 05:14:07 -0400 Original-Received: from [176.228.60.248] (port=2303 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1kQ5WQ-0004OZ-Gx; Wed, 07 Oct 2020 05:14:06 -0400 In-Reply-To: <87imbmqvki.fsf@mail.linkov.net> (message from Juri Linkov on Wed, 07 Oct 2020 11:09:09 +0300) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:190007 Archived-At: > From: Juri Linkov > Cc: drew.adams@oracle.com, acm@muc.de, larsi@gnus.org, 43702@debbugs.gnu.org > Date: Wed, 07 Oct 2020 11:09:09 +0300 > > > I don't think I understand the change, and the documentation doesn't > > seem to help. It seems like now there are just two faces that are > > used alternately, i.e. one face for odd-numbered groups, the other for > > even-numbered groups? If this is the case, why doesn't the > > documentation say so explicitly? And if this is not the case, what > > did I miss? > > Yes, by default isearch-group-1 is used for odd-numbered groups, > and isearch-group-2 for even-numbered groups. > > But when a user or a theme author will define a new face > isearch-group-3, then isearch-group-3 will be used to highlight > groups 3, 6, 9, 12, ..., the isearch-group-2 face to highlight > groups 2, 5, 8, 11, ..., the isearch-group-1 face to highlight > groups 1, 4, 7, 10, ... OK, I clarified this in the docs. > >> I suppose you agree that the previous color palette in isearch > >> with a color gradient is not suitable for highlighting of group matches > >> because while looking at highlighted matches it's quite impossible to > >> say which color corresponds to which group number. > > > > And with the current implementation on master it is possible? If so, > > how? > > With only 2 default group faces it's possible to see that one of them > isearch-group-1 is brighter than the default isearch face, and another > isearch-group-2 is darker than the default isearch face. No, I meant to ask if it's possible to say which color corresponds to which group number.