From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: mouse-face and help echo support for xterm mouse Date: Fri, 06 Nov 2020 08:00:20 +0200 Message-ID: <831rh79g97.fsf@gnu.org> References: <946d9ea094642758037d1881a97e8d0c@finder.org> <6e5a5cde54359702c36d1371861f30c3@finder.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="18916"; mail-complaints-to="usenet@ciao.gmane.io" Cc: monnier@iro.umontreal.ca, emacs-devel@gnu.org To: Jared Finder Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Fri Nov 06 07:01:43 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kauog-0004q6-RL for ged-emacs-devel@m.gmane-mx.org; Fri, 06 Nov 2020 07:01:42 +0100 Original-Received: from localhost ([::1]:52352 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kauof-0000Dr-UJ for ged-emacs-devel@m.gmane-mx.org; Fri, 06 Nov 2020 01:01:41 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:49166) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kaunR-00083G-KJ for emacs-devel@gnu.org; Fri, 06 Nov 2020 01:00:25 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:47129) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kaunQ-0002KW-LI; Fri, 06 Nov 2020 01:00:24 -0500 Original-Received: from [176.228.60.248] (port=2926 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1kaunP-0001Dv-MS; Fri, 06 Nov 2020 01:00:24 -0500 In-Reply-To: <6e5a5cde54359702c36d1371861f30c3@finder.org> (emacs-devel@gnu.org) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:258776 Archived-At: > Date: Thu, 05 Nov 2020 21:23:26 -0800 > Cc: "Jared Finder via \"Emacs development discussions.\"" > From: Jared Finder via "Emacs development discussions." > > All points addressed. New patch attached. Thanks. > * src/dispnew.c (update_mouse_position): New function for mouse movement > logic in 'handle_one_term_event' that can be shared across different > mouse backends. > (display--update-for-mouse-movement): New lisp function, call it. > * lisp/xt-mouse.el (xterm-mouse--handle-mouse-movement): New function that > calls 'display--update-for-mouse-movement'. > (xterm-mouse-translate-1): Call it. > * src/term.c (handle_one_term_event): Inline logic from > 'term_mouse_movement' and call 'update_mouse_position'. > (term_mouse_movement): Delete. Nitpicking: the lines in the change log are too long, they will overflow 80 columns when indented by TABs (which happens when we generate a ChangeLog file from Git log). Please use one of the Emacs commands available for generating ChangeLog entries, they will keep you from making these mistakes. > + XSETFRAME(frame, f); ^ Please leave a space before the opening parenthesis, to conform to our coding conventsions. > + update_mouse_position (XFRAME (selected_frame), XFIXNUM (mouse_x), ^^^^^^^^^^^^^^^^^^^^^^^ A.k.a. SELECTED_FRAME(). > (defface mode-line-highlight > - '((((class color) (min-colors 88)) > + '((((type graphic) (class color) (min-colors 88)) > :box (:line-width 2 :color "grey40" :style released-button)) I don't think I understand the rationale. With TTYs supporting many colors nowadays, and mode-line-highlight available on TTYs, what is the problem you tried to fix here?