From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#34765: 26.1; with-temp-buffer should not run buffer-list-update-hook Date: Sat, 19 Dec 2020 12:33:36 +0200 Message-ID: <831rfmultr.fsf@gnu.org> References: <5C7FD591.9090505@gmx.at> <83lg1sc8ob.fsf@gnu.org> <5C8009F3.5000405@gmx.at> <767e1b59-6ac2-cd11-076e-82a56ac53e29@gmx.at> <11be4631-b087-52a3-92fe-4cbd5248908d@gmx.at> <838svxxk41.fsf@gnu.org> <49c11920-0909-dcc2-4a39-4cdcfaf20453@gmx.at> <87h7sp1xay.fsf@gnus.org> <83r1rgpusx.fsf@gnu.org> <87pn5u7m0y.fsf@gnus.org> <5bdc73dd-af73-1b9a-9bb4-e154787e1976@gmx.at> <87a6uzan9s.fsf@tcd.ie> <71b78484-b0a7-3e0e-a999-afa07f8b4832@gmx.at> <87lfeioh0v.fsf@tcd.ie> <83tut6iqbp.fsf@gnu.org> <87360qoa6o.fsf@tcd.ie> <878sa9cle0.fsf@tcd.ie> <87eejnaqzz.fsf@tcd.ie> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="7157"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 34765@debbugs.gnu.org, larsi@gnus.org, monnier@iro.umontreal.ca, alexanderm@web.de To: "Basil L. Contovounesios" Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Dec 19 11:35:09 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kqZZt-0001j1-A9 for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 19 Dec 2020 11:35:09 +0100 Original-Received: from localhost ([::1]:42250 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kqZZr-0002Uo-US for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 19 Dec 2020 05:35:07 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:47696) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kqZZl-0002Ug-Vi for bug-gnu-emacs@gnu.org; Sat, 19 Dec 2020 05:35:01 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:57543) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kqZZl-0000IQ-OC for bug-gnu-emacs@gnu.org; Sat, 19 Dec 2020 05:35:01 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kqZZl-0001f2-K4 for bug-gnu-emacs@gnu.org; Sat, 19 Dec 2020 05:35:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 19 Dec 2020 10:35:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 34765 X-GNU-PR-Package: emacs Original-Received: via spool by 34765-submit@debbugs.gnu.org id=B34765.16083740446309 (code B ref 34765); Sat, 19 Dec 2020 10:35:01 +0000 Original-Received: (at 34765) by debbugs.gnu.org; 19 Dec 2020 10:34:04 +0000 Original-Received: from localhost ([127.0.0.1]:40856 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kqZYq-0001dh-5F for submit@debbugs.gnu.org; Sat, 19 Dec 2020 05:34:04 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:54402) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kqZYo-0001dE-Lt for 34765@debbugs.gnu.org; Sat, 19 Dec 2020 05:34:03 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:53993) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kqZYh-0008PI-Oz; Sat, 19 Dec 2020 05:33:55 -0500 Original-Received: from [176.228.60.248] (port=3728 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1kqZYg-0003Bd-TG; Sat, 19 Dec 2020 05:33:55 -0500 In-Reply-To: <87eejnaqzz.fsf@tcd.ie> (contovob@tcd.ie) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:196373 Archived-At: > From: "Basil L. Contovounesios" > Cc: Eli Zaretskii , rudalics@gmx.at, larsi@gnus.org, > 34765@debbugs.gnu.org, alexanderm@web.de > Date: Fri, 18 Dec 2020 18:49:52 +0000 > > * .dir-locals.el (c-mode): Enforce existing indent-tabs-mode policy. This should be in a separate commit, IMO. > +By default, undo information (@pxref{Undo}) is not recorded in the > +buffer created by this macro (but @var{body} can enable that, if > +needed). The temporary buffer also does not run the hooks > +@code{kill-buffer-hook}, @code{kill-buffer-query-functions} > +(@pxref{Killing Buffers}), and @code{buffer-list-update-hook} > +(@pxref{Buffer List}). It would be good to have here index entries about undo and those hooks not being used by default in temporary buffers. > +Like @code{with-temp-buffer} (@pxref{Definition of with-temp-buffer,, ^^^^^^^^^^ I think this word will look better if not capitalized. > +static void > +run_buffer_list_update_hook (struct buffer *buf) > +{ > + if (! (NILP (Vrun_hooks) || (buf && buf->inhibit_buffer_hooks))) ^^^ Why this test? is it possible for this function to be called with buf a NULL pointer? Thanks.