all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Philipp Stephani <p.stephani2@gmail.com>
Cc: emacs-devel@gnu.org
Subject: Re: What's the line length limit in the Emacs codebase?
Date: Sat, 26 Dec 2020 13:14:20 +0200	[thread overview]
Message-ID: <831rfcn7jn.fsf@gnu.org> (raw)
In-Reply-To: <CAArVCkQuATUXjcxpGFTRjguodFTu_kHx_GUjm=iW69GgG4o9AA@mail.gmail.com> (message from Philipp Stephani on Sat, 26 Dec 2020 12:09:17 +0100)

> From: Philipp Stephani <p.stephani2@gmail.com>
> Date: Sat, 26 Dec 2020 12:09:17 +0100
> Cc: Emacs developers <emacs-devel@gnu.org>
> 
> > You are counting long strings and lines with long URLs?  Is that
> > reasonable?
> 
> If you look at emacs.c, you'll see lots of lines that are not long
> URLs etc., but e.g. comment blocks that could easily be reflowed, and
> I was wondering why that didn't happen when these comments were
> introduced.

History, I suppose.  I usually reformat any comment line around the
code I change when it's too long.  It's a slow process.

> Just to give some context, I became aware of this when editing various
> parts of the Emacs codebase while having the fill column indicator
> enabled. I then realized that large parts of the code seem to use an
> 80-column limit, while others seem to use a 70-column limit, and I was
> wondering why that's the case.

The value of fill-column is not for judging the length of code lines,
it's for comments and strings.  Code lines can use 80 lines, provided
that they are broken in reasonable places, and that the continuation
lines are indented consistently with the code structure.



  reply	other threads:[~2020-12-26 11:14 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-23  9:58 What's the line length limit in the Emacs codebase? Philipp Stephani
2020-12-23 15:42 ` Eli Zaretskii
2020-12-23 16:55   ` Stefan Monnier
2020-12-23 21:21     ` Karl Fogel
2020-12-24  3:37       ` Eli Zaretskii
2020-12-25 17:11     ` Philipp Stephani
2020-12-25 17:43       ` Stefan Monnier
2020-12-26 11:02         ` Philipp Stephani
2020-12-26 16:30           ` Stefan Monnier
2020-12-27  5:38           ` Richard Stallman
2020-12-25 20:32       ` tomas
2020-12-26 10:38         ` Michael Albinus
2020-12-26 11:17           ` Yuri Khan
2020-12-26 11:22             ` Michael Albinus
2020-12-26 11:36               ` Yuri Khan
2020-12-26 12:21                 ` tomas
2020-12-26 18:31           ` Drew Adams
2020-12-26 11:12         ` Philipp Stephani
2020-12-25 17:10   ` Philipp Stephani
2020-12-25 19:04     ` Eli Zaretskii
2020-12-26 11:09       ` Philipp Stephani
2020-12-26 11:14         ` Eli Zaretskii [this message]
2020-12-26 10:24     ` Richard Stallman
2020-12-26 11:04       ` Philipp Stephani
2020-12-26 18:43         ` Drew Adams

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=831rfcn7jn.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=emacs-devel@gnu.org \
    --cc=p.stephani2@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.