From: Eli Zaretskii <eliz@gnu.org>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: larsi@gnus.org, aaronjensen@gmail.com, emacs-devel@gnu.org
Subject: Re: A whole lotta auto-saving going
Date: Mon, 11 Jan 2021 18:54:34 +0200 [thread overview]
Message-ID: <831rerfm7p.fsf@gnu.org> (raw)
In-Reply-To: <jwvft377ai8.fsf-monnier+emacs@gnu.org> (message from Stefan Monnier on Mon, 11 Jan 2021 11:00:04 -0500)
> From: Stefan Monnier <monnier@iro.umontreal.ca>
> Cc: larsi@gnus.org, aaronjensen@gmail.com, emacs-devel@gnu.org
> Date: Mon, 11 Jan 2021 11:00:04 -0500
>
> > I think sitting for the entire period is undesirable, since receiving
> > output from a process might require redisplay.
> > In that case, waiting could make Emacs seem unresponsive or busy,
> > whereas it really isn't.
>
> But the `do_display` argument indicates that if redisplay is needed it
> can happen without returning from `wait_reading_process_output`.
Do we get to where that causes redisplay in this case?
> > I think a simple solution to this would be to check the time passed
> > after sit_for returns, and if some of the wait time is left, not call
> > auto-save. This would mimic what happened before the offending
> > changeset.
>
> The patch below implements that option.
Thanks.
I see you look at the number of bytes read, but what about the case
that a process exited?
> There's one other call to `sit_for` which can be affected:
>
> tem0 = sit_for (Vecho_keystrokes, 1, 1);
> unbind_to (count, Qnil);
> if (EQ (tem0, Qt)
> && ! CONSP (Vunread_command_events))
> echo_now ();
>
> I believe it's an improvement there as well.
Why do you believe that? It's a different use case, and I don't think
we saw any adverse effects there from the removal of the buffer-switch
"event". Are there any adverse effects?
next prev parent reply other threads:[~2021-01-11 16:54 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-06 22:05 A whole lotta auto-saving going Aaron Jensen
2021-01-07 12:24 ` Lars Ingebrigtsen
2021-01-07 15:21 ` Stefan Monnier
2021-01-08 14:05 ` Aaron Jensen
2021-01-08 14:19 ` Aaron Jensen
2021-01-10 11:10 ` Lars Ingebrigtsen
2021-01-10 15:08 ` Aaron Jensen
2021-01-10 15:24 ` Lars Ingebrigtsen
2021-01-10 17:27 ` Eli Zaretskii
2021-01-10 17:38 ` Stefan Monnier
2021-01-11 4:23 ` Stefan Monnier
2021-01-11 15:04 ` Eli Zaretskii
2021-01-11 16:00 ` Stefan Monnier
2021-01-11 16:54 ` Eli Zaretskii [this message]
2021-01-11 18:00 ` Stefan Monnier
2021-01-12 14:58 ` Eli Zaretskii
2021-01-12 15:18 ` Stefan Monnier
2021-01-13 22:25 ` Stefan Monnier
2021-01-18 16:06 ` Lars Ingebrigtsen
2021-01-10 17:18 ` Stefan Monnier
2021-01-10 18:34 ` T.V Raman
2021-01-10 18:54 ` Aaron Jensen
2021-01-12 16:02 ` T.V Raman via Emacs development discussions.
2021-01-07 14:55 ` Eli Zaretskii
2021-01-10 11:09 ` Lars Ingebrigtsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=831rerfm7p.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=aaronjensen@gmail.com \
--cc=emacs-devel@gnu.org \
--cc=larsi@gnus.org \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.