From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: 'M-o' ('facemap-keymap') has now been removed until March 10th 2021 Date: Fri, 19 Mar 2021 10:06:11 +0200 Message-ID: <831rcbftzg.fsf@gnu.org> References: <87a6sbg41o.fsf@gnus.org> <87lfatirk1.fsf@gnus.org> <878s6lumf0.fsf@gnus.org> <837dm4defe.fsf@gnu.org> <83wnu4bvtk.fsf@gnu.org> <87y2ejoaap.fsf@gnus.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="34413"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org To: Lars Ingebrigtsen Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Fri Mar 19 09:07:24 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lNAAG-0008sd-9t for ged-emacs-devel@m.gmane-mx.org; Fri, 19 Mar 2021 09:07:24 +0100 Original-Received: from localhost ([::1]:41868 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lNAAF-0005H5-Bl for ged-emacs-devel@m.gmane-mx.org; Fri, 19 Mar 2021 04:07:23 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:48836) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lNA95-0004gw-BM for emacs-devel@gnu.org; Fri, 19 Mar 2021 04:06:11 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:45894) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lNA95-0005v0-2M; Fri, 19 Mar 2021 04:06:11 -0400 Original-Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:4537 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1lNA92-0006b4-6P; Fri, 19 Mar 2021 04:06:09 -0400 In-Reply-To: <87y2ejoaap.fsf@gnus.org> (message from Lars Ingebrigtsen on Fri, 19 Mar 2021 08:46:38 +0100) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:266587 Archived-At: > From: Lars Ingebrigtsen > Cc: emacs-devel@gnu.org > Date: Fri, 19 Mar 2021 08:46:38 +0100 > > Eli Zaretskii writes: > > >> Fair enough, but please include in NEWS a recipe to get back the old > >> behavior. Is the following enough? > >> > >> (require 'facemenu) > >> (define-key global-map "\M-o" 'facemenu-keymap) > > Yup; I've now added this to NEWS. Thanks. > > Actually, it looks like the following is needed to get back the old > > bindings: > > > > (require 'facemenu) > > (define-key global-map "\M-o" 'facemenu-keymap) > > (define-key facemenu-keymap "\es" 'center-line) > > (define-key facemenu-keymap "\eS" 'center-paragraph) > > These two functions aren't really related to the facemenu functionality, > so I think that just confuses the issue. If somebody wants to have a > binding for these two commands, that's presumably orthogonal to whether > they want to have the facemenu-keymap functionality. So these people > should just put them on `C-c LETTER' or wherever they put things. We are talking about getting back the old behavior, so we should let users have _all_ of it back. We could, of course, clarify that the last two bindings are unrelated to faces, and that they are needed only if the user wants them back. (FWIW, I'm a long-time and happy user of center-line, and was quite annoyed when it moved from its original M-s to a longer "M-o M-s", but that's water under the bridge.)