From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#48307: Feature request: provide default keybindings to change the font size in all windows Date: Tue, 25 May 2021 16:12:26 +0300 Message-ID: <831r9vc5z9.fsf@gnu.org> References: <603bbc01-b1a2-b367-f54e-59a57475cbfe@gmail.com> <333cb576-85c8-6da6-2312-293fa5c44865@gmail.com> <5009beed-08d3-592b-86a6-136b994cbc5b@gmx.at> <0ca4bc1d-a396-6948-83e9-6f82f3e77c0c@gmail.com> <83im3q5swn.fsf@gnu.org> <4363ab35-b2d0-4d10-dd51-6447b58d705e@gmail.com> <838s43c7v8.fsf@gnu.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="14012"; mail-complaints-to="usenet@ciao.gmane.io" Cc: cpitclaudel@gmail.com, 48307@debbugs.gnu.org To: Gregory Heytings Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue May 25 15:13:50 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1llWsX-0003OW-Vx for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 25 May 2021 15:13:49 +0200 Original-Received: from localhost ([::1]:39964 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1llWsW-00049y-1y for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 25 May 2021 09:13:48 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:56468) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1llWrm-00049i-UT for bug-gnu-emacs@gnu.org; Tue, 25 May 2021 09:13:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:33428) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1llWrm-0002aA-LX for bug-gnu-emacs@gnu.org; Tue, 25 May 2021 09:13:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1llWrm-00063d-G1 for bug-gnu-emacs@gnu.org; Tue, 25 May 2021 09:13:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 25 May 2021 13:13:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 48307 X-GNU-PR-Package: emacs Original-Received: via spool by 48307-submit@debbugs.gnu.org id=B48307.162194836223257 (code B ref 48307); Tue, 25 May 2021 13:13:02 +0000 Original-Received: (at 48307) by debbugs.gnu.org; 25 May 2021 13:12:42 +0000 Original-Received: from localhost ([127.0.0.1]:44974 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1llWrS-000632-7X for submit@debbugs.gnu.org; Tue, 25 May 2021 09:12:42 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:34418) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1llWrM-00062k-UB for 48307@debbugs.gnu.org; Tue, 25 May 2021 09:12:40 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:44178) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1llWrH-0002CK-2P; Tue, 25 May 2021 09:12:31 -0400 Original-Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:3268 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1llWrG-0007M6-3h; Tue, 25 May 2021 09:12:30 -0400 In-Reply-To: (message from Gregory Heytings on Tue, 25 May 2021 12:58:59 +0000) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:207208 Archived-At: > Date: Tue, 25 May 2021 12:58:59 +0000 > From: Gregory Heytings > cc: cpitclaudel@gmail.com, 48307@debbugs.gnu.org > > Thanks for your feedback, a few comments before updating the patch: > > >> The main added feature is that face resizing is now bounded (between 10 > >> and 500). > > > > Hmm, the GCS frowns on arbitrary limits, > > > > What is "the GCS"? GNU Coding Standards. > > so perhaps we should have a defcustom to control the limits? > > > > I'd rather wait for a feature request to add a defcustom for this. IMO > 10-500 is a reasonable range for that feature, 10 is really small and 500 > is really huge. We could avoid arguing about what's reasonable by providing an option. Lars, WDYT? > > Also, I wonder whether we should say "height of the default face's > > font", because this is what this actually does. I'm not sure every user > > will understand the notion of the height of a face. > > > > I used "height" because it's what text-scale-{adjust,increase,decrease} > use. Otherwise I would have used the word "size" indeed. WDYT? I prefer "size". > >> +Buffer-local face adjustements remain in effect when global face > >> +adjustments are made. > > > > I don't think I understand what this means, so it would be good to > > clarify that. > > > > It means that if you C-x C-+ in a buffer B (buffer-local face adjustment), > and then C-x C-M-+, the buffer-local adjustment in B remains in effect, or > IOW that after C-x C-M-+ the buffer B will still have a larger font than > the other buffers. I think what's missing is the last part you wrote, or some variant thereof. "Remains in effect" is ambiguous because it isn't clear whether the absolute size remains in effect or the relative size does.