From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#12925: 24.1; string-make-unibyte instead of string-as-unibyte Date: Wed, 02 Jun 2021 15:07:24 +0300 Message-ID: <831r9kzczn.fsf@gnu.org> References: <87wqxi24b3.fsf@betacantrips.com> <87lf7udq4q.fsf@gnus.org> <83fsy123yg.fsf@gnu.org> <87r1hkam7m.fsf@gnus.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="30072"; mail-complaints-to="usenet@ciao.gmane.io" Cc: monnier@iro.umontreal.ca, 12925@debbugs.gnu.org, ethan.glasser.camp@gmail.com To: Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Jun 02 14:08:52 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1loPg3-0007bU-43 for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 02 Jun 2021 14:08:51 +0200 Original-Received: from localhost ([::1]:60350 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1loPg2-0004J0-6e for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 02 Jun 2021 08:08:50 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:46120) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1loPfG-00038I-E1 for bug-gnu-emacs@gnu.org; Wed, 02 Jun 2021 08:08:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:55798) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1loPfG-0006HL-48 for bug-gnu-emacs@gnu.org; Wed, 02 Jun 2021 08:08:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1loPfF-0007Gl-VS for bug-gnu-emacs@gnu.org; Wed, 02 Jun 2021 08:08:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 02 Jun 2021 12:08:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 12925 X-GNU-PR-Package: emacs Original-Received: via spool by 12925-submit@debbugs.gnu.org id=B12925.162263566527918 (code B ref 12925); Wed, 02 Jun 2021 12:08:01 +0000 Original-Received: (at 12925) by debbugs.gnu.org; 2 Jun 2021 12:07:45 +0000 Original-Received: from localhost ([127.0.0.1]:39111 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1loPez-0007GE-Bs for submit@debbugs.gnu.org; Wed, 02 Jun 2021 08:07:45 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:52384) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1loPey-0007Fw-HM for 12925@debbugs.gnu.org; Wed, 02 Jun 2021 08:07:44 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:44968) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1loPes-000635-SG; Wed, 02 Jun 2021 08:07:38 -0400 Original-Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:3962 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1loPes-0002HU-Ee; Wed, 02 Jun 2021 08:07:38 -0400 In-Reply-To: <87r1hkam7m.fsf@gnus.org> (message from Lars Ingebrigtsen on Wed, 02 Jun 2021 07:07:25 +0200) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:207858 Archived-At: > From: Lars Ingebrigtsen > Cc: monnier@iro.umontreal.ca, 12925@debbugs.gnu.org, > ethan.glasser.camp@gmail.com > Date: Wed, 02 Jun 2021 07:07:25 +0200 > > Eli Zaretskii writes: > > > Why not make both methods do the same: insert the bytes of the > > multibyte text into the unibyte buffer? > > I think it's still common to have raw bytes in multibyte buffers. > Inserting data from these buffers into unibyte buffers works fine. > (That's the rationale for inserting the "lower byte" in these > situations.) > > So I don't think we should change this to insert the multibyte text, > because that'd break stuff. And signaling an error won't break stuff? > The question is what to do when inserting multibyte characters in > unibyte buffers, and I think that's always an error (i.e., it's never > what the person who wrote the code wanted to happen). Now I'm confused: you have just explained above that it should continue working. What am I missing? Please note that I wasn't talking about inserting raw bytes, whether they come from unibyte or multibyte buffers, I was talking about inserting multibyte text that represents human-readable characters.