From: Eli Zaretskii <eliz@gnu.org>
To: Dmitry Gutov <dgutov@yandex.ru>
Cc: emacs-devel@gnu.org
Subject: Re: master 2ed2999: Improve documentation of new Xref options
Date: Mon, 06 Sep 2021 18:33:13 +0300 [thread overview]
Message-ID: <831r61soqu.fsf@gnu.org> (raw)
In-Reply-To: <7fe2eafb-e15a-beab-f485-9c80b2913121@yandex.ru> (message from Dmitry Gutov on Mon, 6 Sep 2021 15:47:57 +0300)
> Cc: emacs-devel@gnu.org
> From: Dmitry Gutov <dgutov@yandex.ru>
> Date: Mon, 6 Sep 2021 15:47:57 +0300
>
> On 06.09.2021 15:28, Eli Zaretskii wrote:
> > My responses were only about a separate boolean option for
> > xref-find-references. AFAIU, that's not what you described,
> > disregarding the "boolean" part.
>
> We already differentiate between the -definitions[-*] commands and all
> other Xref commands, e.g. we have xref-show-definitions-function and
> xref-show-xrefs-function. This change follows the same pattern.
>
> We could have gone the one-defcustom-per-command route, but that's a lot
> of micromanagement for the users, with seemingly little benefit.
I'm okay with 2 options, there's no need to argue about that.
> > So, bottom line: which commands are affected by each option? E.g.,
> > what about the -other-window and -at-mouse etc. variants: I guess they
> > are affected by the corresponding options? Also, what other commands
> > are affected, in addition to the "families" of xref-find-definitions
>
> Right. To clarify: all of xref-find-definitions-* are affected by
> xref-auto-jump-to-first-definition.
>
> > and xref-find-references?
>
> Also xref-find-apropos, project-find-regexp, dired-do-find-regexp and
> any other third-party or future callers of xref-show-xrefs-function will
> be affected by xref-auto-jump-to-first-xref.
So basically xref-auto-jump-to-first-xref affects any command that is
expected to display many matches, would that be a correct summary?
> > And what about stuff like
> > dired-do-find-regexp-and-replace -- is that affected by any of these?
>
> dired-do-find-regexp-and-replace is affected as well right now, but
> that's a bug to be fixed (thanks for bringing it up).
I see you fixed that already, but what about dired-do-find-regexp?
next prev parent reply other threads:[~2021-09-06 15:33 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20210905075953.20536.20920@vcs0.savannah.gnu.org>
[not found] ` <20210905075955.0F6B720A0A@vcs0.savannah.gnu.org>
2021-09-05 19:38 ` master 2ed2999: Improve documentation of new Xref options Dmitry Gutov
2021-09-06 4:30 ` Eli Zaretskii
2021-09-06 11:24 ` Dmitry Gutov
2021-09-06 12:28 ` Eli Zaretskii
2021-09-06 12:47 ` Dmitry Gutov
2021-09-06 15:33 ` Eli Zaretskii [this message]
2021-09-06 15:43 ` Dmitry Gutov
2021-09-07 13:05 ` Eli Zaretskii
2021-09-07 15:24 ` Dmitry Gutov
2021-09-07 15:27 ` Dmitry Gutov
2021-09-07 16:07 ` Eli Zaretskii
2021-09-07 15:47 ` Eli Zaretskii
2021-09-07 16:01 ` Dmitry Gutov
2021-09-07 16:18 ` Eli Zaretskii
2021-09-07 16:27 ` Dmitry Gutov
2021-09-07 17:03 ` [External] : " Drew Adams
2021-09-07 17:21 ` Dmitry Gutov
2021-09-07 17:28 ` Drew Adams
2021-09-07 17:40 ` Dmitry Gutov
2021-09-07 19:44 ` Drew Adams
2021-09-07 20:08 ` ARG and Dired commands, was: " Dmitry Gutov
2021-09-07 20:42 ` Drew Adams
2021-09-07 20:49 ` Dmitry Gutov
2021-09-07 21:47 ` Drew Adams
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=831r61soqu.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=dgutov@yandex.ru \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.