From: Eli Zaretskii <eliz@gnu.org>
To: "Basil L. Contovounesios" <contovob@tcd.ie>
Cc: 51076@debbugs.gnu.org
Subject: bug#51076: 28.0.60; Null dereference warning with nox build in make_lispy_position
Date: Thu, 07 Oct 2021 16:10:41 +0300 [thread overview]
Message-ID: <831r4x0ylq.fsf@gnu.org> (raw)
In-Reply-To: <87wnmp2hkz.fsf@tcd.ie> (bug-gnu-emacs@gnu.org)
> Date: Thu, 07 Oct 2021 12:35:24 +0100
> From: "Basil L. Contovounesios" via "Bug reports for GNU Emacs,
> the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org>
>
> In file included from keyboard.c:29:
> keyboard.c: In function ‘make_lispy_position’:
> frame.h:949:35: warning: null pointer dereference [-Wnull-dereference]
> 949 | #define FRAME_TAB_BAR_LINES(f) (f)->tab_bar_lines
> | ~~~^~~~~~~~~~~~~~~
> keyboard.c:5134:10: note: in expansion of macro ‘FRAME_TAB_BAR_LINES’
> 5134 | && FRAME_TAB_BAR_LINES (f) > 0
> | ^~~~~~~~~~~~~~~~~~~
>
> AFAICT the preceding condition '!FRAME_WINDOW_P (f)' will always be true
> in a nox build
Yes, but what about a build with X support that displays a TTY frame?
I installed a trivial fix.
next prev parent reply other threads:[~2021-10-07 13:10 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-07 11:35 bug#51076: 28.0.60; Null dereference warning with nox build in make_lispy_position Basil L. Contovounesios via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-10-07 13:10 ` Eli Zaretskii [this message]
2021-10-08 10:20 ` Basil L. Contovounesios via Bug reports for GNU Emacs, the Swiss army knife of text editors
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=831r4x0ylq.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=51076@debbugs.gnu.org \
--cc=contovob@tcd.ie \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.