From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#52734: 28.0.90; [PATCH] xref-backend-definitions in etags.el duplicates list Date: Thu, 23 Dec 2021 11:12:33 +0200 Message-ID: <831r23wupq.fsf@gnu.org> References: Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="2896"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 52734@debbugs.gnu.org To: David Fussner , Dmitry Gutov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Dec 23 10:13:30 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1n0KAE-0000ZM-0H for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 23 Dec 2021 10:13:30 +0100 Original-Received: from localhost ([::1]:36772 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1n0KAC-0000JM-Cz for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 23 Dec 2021 04:13:28 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:51092) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n0K9m-0000Hp-8p for bug-gnu-emacs@gnu.org; Thu, 23 Dec 2021 04:13:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:48810) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1n0K9l-0007F0-SO for bug-gnu-emacs@gnu.org; Thu, 23 Dec 2021 04:13:01 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1n0K9l-00026I-Ka for bug-gnu-emacs@gnu.org; Thu, 23 Dec 2021 04:13:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 23 Dec 2021 09:13:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 52734 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 52734-submit@debbugs.gnu.org id=B52734.16402507568037 (code B ref 52734); Thu, 23 Dec 2021 09:13:01 +0000 Original-Received: (at 52734) by debbugs.gnu.org; 23 Dec 2021 09:12:36 +0000 Original-Received: from localhost ([127.0.0.1]:60356 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n0K9L-00025Z-NQ for submit@debbugs.gnu.org; Thu, 23 Dec 2021 04:12:35 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:50242) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n0K9J-00025K-Vq for 52734@debbugs.gnu.org; Thu, 23 Dec 2021 04:12:34 -0500 Original-Received: from [2001:470:142:3::e] (port=47986 helo=fencepost.gnu.org) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n0K9E-0007AQ-M4; Thu, 23 Dec 2021 04:12:28 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=lBLjZUSAeKgcmS5pYsbdEipZzzytBp+T4GzH9hYEAGM=; b=r3fBB6Z5blu/ 1Gc6jasC/UKQExpwKOrS/aAblT0C6Q7ThsuAPH2YdlAOAD3Rqabeef1idwNb7mIhWrtNfOO7knBBg Ni+/zVFXs/STy8l6RGGc4Vl138ebVTVXIM6qJdp3wZtUVOuVNhBKrySzTmaNDHBpxlgjV5vwS+F6g o37Y4l8oQ+UtFjKI0VR0Tt7paaJ05Ida92x30EBeioyiiU22zSrflTIEYpTla2lAtcad25+OS6Fq6 Kzz/X6WqZpEzTplAwwyyJWFg0dznzJNPYx3ze48hrtsgOa2BRK6rORpS5b8Gsyc0vXijFinfIl9Is EeMY+JwHPAi1yMgDo7l74g==; Original-Received: from [87.69.77.57] (port=1672 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n0K9E-0000k6-Jq; Thu, 23 Dec 2021 04:12:28 -0500 In-Reply-To: (bug-gnu-emacs@gnu.org) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:222969 Archived-At: > Date: Wed, 22 Dec 2021 15:01:54 +0000 > From: David Fussner via "Bug reports for GNU Emacs, > the Swiss army knife of text editors" > > When `etags-xref-prefer-current-file' is t and only the current file > contains (multiple) definitions of the same function, the list returns > each tag twice. To reproduce: > > cd src/ > ../lib-src/etags term.c > ./emacs -Q term.c > C-s tty_free_frame_resources RTN > M-. RTN > > src/term.c > 3786: tty_free_frame_resources > 3798: tty_free_frame_resources > > (setq etags-xref-prefer-current-file t) > M-. > > src/term.c > 3786: tty_free_frame_resources > 3798: tty_free_frame_resources > 3786: tty_free_frame_resources > 3798: tty_free_frame_resources > > The variable is new in 28.1, so I thought the bug might want fixing on > this branch. In my testing, cl-delete appears not to delete ITEMs from > SEQ if such deletion would leave SEQ empty. I can't find this behavior > documented anywhere, but I may be looking in the wrong places. > > Patch attached, which just tests for equality of the two lists of > definitions, and only returns one of them in that case. Dmitry, any comments? The patch LGTM, FWIW.