From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#53638: [PATCH] newsticker better path handling and data storage Date: Tue, 01 Feb 2022 05:25:56 +0200 Message-ID: <831r0n8dyz.fsf@gnu.org> References: <87h79lgg5n.fsf@protonmail.com> <87h79j29ha.fsf@gnus.org> <875ypzhdkd.fsf@protonmail.com> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="31567"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 53638@debbugs.gnu.org, larsi@gnus.org To: mailj2@protonmail.com Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Feb 01 04:27:09 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nEjoy-00081Z-Q2 for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 01 Feb 2022 04:27:08 +0100 Original-Received: from localhost ([::1]:36924 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nEjox-0007gW-RO for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 31 Jan 2022 22:27:07 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:40042) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nEjos-0007gA-07 for bug-gnu-emacs@gnu.org; Mon, 31 Jan 2022 22:27:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:48466) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nEjor-0007dW-Mu for bug-gnu-emacs@gnu.org; Mon, 31 Jan 2022 22:27:01 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nEjor-0001ua-Hf for bug-gnu-emacs@gnu.org; Mon, 31 Jan 2022 22:27:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 01 Feb 2022 03:27:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 53638 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 53638-submit@debbugs.gnu.org id=B53638.16436859727278 (code B ref 53638); Tue, 01 Feb 2022 03:27:01 +0000 Original-Received: (at 53638) by debbugs.gnu.org; 1 Feb 2022 03:26:12 +0000 Original-Received: from localhost ([127.0.0.1]:41369 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nEjo2-0001tJ-75 for submit@debbugs.gnu.org; Mon, 31 Jan 2022 22:26:11 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:33300) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nEjnw-0001sf-Fa for 53638@debbugs.gnu.org; Mon, 31 Jan 2022 22:26:07 -0500 Original-Received: from [2001:470:142:3::e] (port=33768 helo=fencepost.gnu.org) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nEjnq-0007SA-Vh; Mon, 31 Jan 2022 22:25:59 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=XkSa3Wkq0JI8Z+8Ipy2qJsdc7lB/iWcqY+cKMPCSMK8=; b=KdtOXwbFn0pG +08PC17/tlrhyMeGxT+JJoh0jExq68kQUKFqYYhPAO5LxNN3X/1GqDKsGyb/Fd5Ay1zw7R+kf7T/s Ix4oUm+NpJXTLivxxdMvKCxUHuVYCY2bX7rYNZZTGwEln5BMV/GVXC5r14KpLuN0XpvaY70dCvyGw VeeXl4+TC0Tb4sOaWirIHyO3Rvnap2CQhh5aQTX0Ieq6bqMMH24lmjmrHb2J7S9A9Xv5ElEehpntr lAkTIXf536gzJpELPptHYD8Eu3xRt0UgOu1eAzXWE3IQPVhu55pYi89nAuXvtl6uBUkGTRuVkkfAx d7ukuU2MU+whnZPPebxr9A==; Original-Received: from [87.69.77.57] (port=4823 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nEjnq-0002CV-7q; Mon, 31 Jan 2022 22:25:58 -0500 In-Reply-To: <875ypzhdkd.fsf@protonmail.com> (bug-gnu-emacs@gnu.org) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:225735 Archived-At: > Cc: Lars Ingebrigtsen > Date: Mon, 31 Jan 2022 20:09:58 +0000 > From: mailj2--- via "Bug reports for GNU Emacs, > the Swiss army knife of text editors" > > "Lars Ingebrigtsen" writes: > > > Can you rework the patch to use > > `expand-file-name', which is how file names are supposed to be constructed? > > I've refactored it to use `expand-file-name' and `file-name-concat'. It > appears the current convention (correct me if I'm wrong) is to use > `expand-file-name' for joining only one path and one directory, and > `file-name-concat' for multiple together. No, you can chain calls to expand-file-name as you need: (expand-file-name "foo" (expand-file-name "bar" my-directory))