From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: master b1e9151: Enable the native display of BMP images on Haiku Date: Sat, 26 Mar 2022 16:58:22 +0300 Message-ID: <831qyobytd.fsf@gnu.org> References: <835yo0c2xa.fsf@gnu.org> <87h77k51wf.fsf@yahoo.com> <834k3kc0n5.fsf@gnu.org> <87bkxs4zmm.fsf@yahoo.com> <8335j4c060.fsf@gnu.org> <875yo04ygp.fsf@yahoo.com> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="32357"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org To: Po Lu Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sat Mar 26 15:18:52 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nY7Fj-0008Ir-DJ for ged-emacs-devel@m.gmane-mx.org; Sat, 26 Mar 2022 15:18:51 +0100 Original-Received: from localhost ([::1]:33830 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nY7Fi-0008QA-BQ for ged-emacs-devel@m.gmane-mx.org; Sat, 26 Mar 2022 10:18:50 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:38008) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nY6vx-0001vu-Pg for emacs-devel@gnu.org; Sat, 26 Mar 2022 09:58:25 -0400 Original-Received: from [2001:470:142:3::e] (port=56514 helo=fencepost.gnu.org) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nY6vx-0001UY-GK; Sat, 26 Mar 2022 09:58:25 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=8y2Ci3+Z3TSsSXTdWMqwkMw1L8iTif767kcIuRDlsnM=; b=j6rkgqbSDsRC tFelVkKR8b5fGBwjRK8hpw6V9My605nYP6eTrEiezhmRLPf4IqIXTHoCjYDdqwQivzXXUJPpgLemP AO9+xUt9JCUT+Nqu13Ma0HZNsKceSy0qOUi+ahqgz7jsWqtg0a1Vrd2iBmBsH9tV47macoK2mI183 8IZhhtnL6iwb6SAFP+AZUqGotfvooIaCrM02Bu5KXiXQUU7ctugPlAkkMqFaaYy4KIKI8/DxTH26F oSclH4mPNbh9PYgcZTMSx/WCS+Mpdhg2EKOcwuNtbAI/GhD/dmlWWS6/Qtk0tfbRLYgq1Jq+PsZuF J7Fzb0itNJHYO19PH/OWQg==; Original-Received: from [87.69.77.57] (port=2846 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nY6vw-0004Kj-WA; Sat, 26 Mar 2022 09:58:25 -0400 In-Reply-To: <875yo04ygp.fsf@yahoo.com> (message from Po Lu on Sat, 26 Mar 2022 21:47:50 +0800) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:287481 Archived-At: > From: Po Lu > Cc: emacs-devel@gnu.org > Date: Sat, 26 Mar 2022 21:47:50 +0800 > > Eli Zaretskii writes: > > >> From: Po Lu > >> Cc: emacs-devel@gnu.org > >> Date: Sat, 26 Mar 2022 21:22:41 +0800 > >> > >> Eli Zaretskii writes: > >> > >> > It's better not, I think. We don't do that elsewhere, do we? > >> > >> I think there are a few cases, though probably not deliberate. If you > >> insist on removing the definition in haikuimage.c, I don't see why not. > > > > What are the arguments for leaving it in haikuimage.c? > > Mainly so that if the DEFSYM in image.c is moved under some different > conditionals (or removed entirely), haikuimage.c will continue to work. Then I don't think we should keep it in haikuimage.c. If it is ever removed, haikuimage.c will fail to compile, and the error message will tell exactly what's wrong. We have similar issues with symbols used in w32font.c that are declared elsewhere, for example. Why would haikuimage.c be treated differently?