From: Eli Zaretskii <eliz@gnu.org>
To: Po Lu <luangruo@yahoo.com>
Cc: emacs-devel@gnu.org
Subject: Re: master 4fb028be6c 3/3: Fix releasing the mouse on top of the tool bar on MS Windows
Date: Sat, 30 Apr 2022 10:17:06 +0300 [thread overview]
Message-ID: <831qxf9h1p.fsf@gnu.org> (raw)
> branch: master
> commit 4fb028be6c2de5a556f56bb40a3f948a143cef37
> Author: Po Lu <luangruo@yahoo.com>
> Commit: Po Lu <luangruo@yahoo.com>
>
> Fix releasing the mouse on top of the tool bar on MS Windows
>
> * src/w32term.c (w32_read_socket): Don't handle tool bar clicks
> specially for button up events if no tool bar item was
> previously pressed.
> ---
> src/w32term.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/src/w32term.c b/src/w32term.c
> index 1937f94645..205ac74966 100644
> --- a/src/w32term.c
> +++ b/src/w32term.c
> @@ -5365,7 +5365,9 @@ w32_read_socket (struct terminal *terminal,
>
> window = window_from_coordinates (f, x, y, 0, 1, 1);
>
> - if (EQ (window, f->tool_bar_window))
> + if (EQ (window, f->tool_bar_window)
> + && (inev.modifiers & down_modifier
> + || f->last_tool_bar_item != -1))
> {
> w32_handle_tool_bar_click (f, &inev);
> tool_bar_p = 1;
>
Can you tell what was the problem, and how to see it happening before
the change?
Thanks.
next reply other threads:[~2022-04-30 7:17 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-30 7:17 Eli Zaretskii [this message]
2022-04-30 7:50 ` master 4fb028be6c 3/3: Fix releasing the mouse on top of the tool bar on MS Windows Po Lu
2022-04-30 9:36 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=831qxf9h1p.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=luangruo@yahoo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.