Re: master edd11a2c6e 1/2: Update comments in some X code

Re: master edd11a2c6e 1/2: Update comments in some X code

[Eli Zaretskii]

> +  DEFVAR_INT ("x-color-cache-bucket-size", x_color_cache_bucket_size,
> +    doc: /* Most buckets allowed per display in the internal color cache.
               ^^^^^^^^^^^^
You meant "Max number of buckets", right?

Re: master edd11a2c6e 1/2: Update comments in some X code

[Po Lu]

Eli Zaretskii <eliz@gnu.org> writes:

> You meant "Max number of buckets", right?

Yes, but that makes the first line longer than 69 characters, which I
think is the limit.  Don't "most" and "max number of" mean the same here
anyway?

Re: master edd11a2c6e 1/2: Update comments in some X code

[Eli Zaretskii]

> From: Po Lu <luangruo@yahoo.com>
> Cc: emacs-devel@gnu.org
> Date: Fri, 27 May 2022 21:13:24 +0800
> 
> Eli Zaretskii <eliz@gnu.org> writes:
> 
> > You meant "Max number of buckets", right?
> 
> Yes, but that makes the first line longer than 69 characters, which I
> think is the limit.

Why 69?  The limit is 79.

> Don't "most" and "max number of" mean the same here anyway?

No.  "Most buckets" is simply incorrect and confusing English.

Re: master edd11a2c6e 1/2: Update comments in some X code

[Po Lu]

Eli Zaretskii <eliz@gnu.org> writes:

> No.  "Most buckets" is simply incorrect and confusing English.

Thanks.  I'll correct that then.

Re: master edd11a2c6e 1/2: Update comments in some X code

[tomas]

[-- Attachment #1: Type: text/plain, Size: 915 bytes --]

On Fri, May 27, 2022 at 09:13:24PM +0800, Po Lu wrote:
> Eli Zaretskii <eliz@gnu.org> writes:
> 
> > You meant "Max number of buckets", right?
> 
> Yes, but that makes the first line longer than 69 characters, which I
> think is the limit.  Don't "most" and "max number of" mean the same here
> anyway?

Oh, as a non-native speaker I feel your pain :)

"Most buckets" means given a fixed set of buckets, their majority.
Whereas the maximum number of buckets means "you can't have more
than so-many buckets". So the first is a subset of some existing
set of buckets (usually with a property characterising it), whereas
the second is a number.

As in "most people in this elevator wear a tie", as opposed to
"the maximum number of people in this elevator is 69".

If you are short of space, "max buckets" or even "max. buckets"
might do, although it isn't really good English.

Cheers
-- 
t

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]

x-color-cache-bucket-size (was: master edd11a2c6e 1/2: Update comments in some X code)

[Stefan Monnier]

>> +  DEFVAR_INT ("x-color-cache-bucket-size", x_color_cache_bucket_size,
>> +    doc: /* Most buckets allowed per display in the internal color cache.

Why do we need to expose this?


        Stefan

Re: x-color-cache-bucket-size

[Po Lu]

Stefan Monnier <monnier@iro.umontreal.ca> writes:

> Why do we need to expose this?

Debugging.  It's not something users are supposed to make use of.

Re: x-color-cache-bucket-size

[Stefan Monnier]

Po Lu [2022-05-28 08:38:31] wrote:
> Stefan Monnier <monnier@iro.umontreal.ca> writes:
>> Why do we need to expose this?
> Debugging.  It's not something users are supposed to make use of.

I usually give those kinds of variables a name that makes it more clear,
to try and avoid any surprise later on.


        Stefan

Re: x-color-cache-bucket-size

[Eli Zaretskii]

> From: Stefan Monnier <monnier@iro.umontreal.ca>
> Cc: Eli Zaretskii <eliz@gnu.org>,  emacs-devel@gnu.org
> Date: Fri, 27 May 2022 20:43:04 -0400
> 
> Po Lu [2022-05-28 08:38:31] wrote:
> > Stefan Monnier <monnier@iro.umontreal.ca> writes:
> >> Why do we need to expose this?
> > Debugging.  It's not something users are supposed to make use of.
> 
> I usually give those kinds of variables a name that makes it more clear,
> to try and avoid any surprise later on.

It should be enough to say something like "Internal use only."