From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#56323: 29.0.50; [v2] Add new customisable phonetic Tamil input method Date: Fri, 01 Jul 2022 19:09:36 +0300 Message-ID: <831qv4erwf.fsf@gnu.org> References: <87pmiqe4da.fsf@gmail.com> <878rpdq99n.fsf@gmail.com> <83fsjldl2b.fsf@gnu.org> <87tu81osgp.fsf@gmail.com> <83czepdj0z.fsf@gnu.org> <87pmioq51w.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="27200"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 56323@debbugs.gnu.org To: Visuwesh Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Jul 01 18:10:19 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1o7JDn-0006xi-AU for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 01 Jul 2022 18:10:19 +0200 Original-Received: from localhost ([::1]:37828 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1o7JDm-0006xz-0P for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 01 Jul 2022 12:10:18 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:46476) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o7JDX-0006si-46 for bug-gnu-emacs@gnu.org; Fri, 01 Jul 2022 12:10:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:45127) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1o7JDW-0007kG-QB for bug-gnu-emacs@gnu.org; Fri, 01 Jul 2022 12:10:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1o7JDW-0007Mu-BP for bug-gnu-emacs@gnu.org; Fri, 01 Jul 2022 12:10:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 01 Jul 2022 16:10:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 56323 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 56323-submit@debbugs.gnu.org id=B56323.165669177628282 (code B ref 56323); Fri, 01 Jul 2022 16:10:02 +0000 Original-Received: (at 56323) by debbugs.gnu.org; 1 Jul 2022 16:09:36 +0000 Original-Received: from localhost ([127.0.0.1]:39024 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o7JD6-0007M6-6W for submit@debbugs.gnu.org; Fri, 01 Jul 2022 12:09:36 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:33112) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o7JD1-0007Lo-Fq for 56323@debbugs.gnu.org; Fri, 01 Jul 2022 12:09:34 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:37756) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o7JCw-0006qW-9w; Fri, 01 Jul 2022 12:09:26 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=f264ayalhDUDZndKQnw2RvFN4dzneeib8OPLg0wsfKw=; b=OCxHtSORe76PdmmMKVR4 Of1xfyZtw1wzHDRrSMWZFoxHRCyluV3V1eJ/qav05IzZoQlTHV9MtVKT9ZaG/kE/OAsORx2SNgzY2 Mv56falzwmYqXw/4d9PE/gQjOtbpiW8d428KlTecCRtmEffwxySzu+C2plXjLa10sQsZ7Yfo1nZKa G0d0ztMSr/vGLm5wzSVnMMq2eUi6OPv8VY8QWkjrtiyhJOhzOLrtxWmIxZrEtc2QFWkRnHcpmGILZ ToFKMrP0JN7UF/tsNwiLbvRjoLKLfqucWLITzwvJoFvOmlkYtdtX+ptpBJ1WTbSDershLsK6FSw0Z TIKBCdTO8Olhrg==; Original-Received: from [87.69.77.57] (port=4853 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o7JCu-0002O9-Ty; Fri, 01 Jul 2022 12:09:26 -0400 In-Reply-To: <87pmioq51w.fsf@gmail.com> (message from Visuwesh on Fri, 01 Jul 2022 20:00:03 +0530) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:235824 Archived-At: > From: Visuwesh > Cc: 56323@debbugs.gnu.org > Date: Fri, 01 Jul 2022 20:00:03 +0530 > > > I don't think I understand what you want to achieve, and don't read > > Tamil in the first place, to tell you whether this is correct or not, > > sorry. > > > > I mostly meant to ask if the weighted approach was good but I wasn't > clear enough, sorry. Let me try to explain it better: > > Let's suppose that string-lessp does not work for English for the > discussion here. The task is to sort a list of jumbled English > alphabets in alphabetical order. What I'm currently doing is creating > an alist where the key is the alphabet and the value is the alphabet's > order (so a will be 1, b will be 2, etc.). Then in the sort function, I > look for this order. If the alphabet is not in this list, then I fall > back to a large number. > > So the code above would look like this if it were in English, > > (sort '("b" "z" "c" "n" "a" "aa" "p") > (lambda (x y) > (let ((cp '(("a" . 0) ("b" . 1) ("c" . 2) ("d" . 3) ("e" . 4) > ("f" . 5) ("g" . 6) ("h" . 7) ("i" . 8) ("j" . 9) > ("k" . 10) ("l" . 11) ("m" . 12) ("n" . 13) ("o" . 14) > ("p" . 15) ("q" . 16) ("r" . 17) ("s" . 18) ("t" . 19) > ("u" . 20) ("v" . 21) ("w" . 22) ("x" . 23) ("y" . 24) > ("z" . 25)))) > (< (or (assoc-default x cp) 10000) > (or (assoc-default y cp) 10000))))) > > and the sorted list comes out as ("a" "b" "c" "n" "p" "z" "aa") > which is exactly what I desire. I hope this is clear enough. The above just gives each letter its order in the alphabet. But if that is what you wanted, string-lessp (or even just direct comparison of characters) would have worked for you. So there's still something important missing from your description, I think. > > Looks like simple misalignment to me, which should be cured by using > > pixel-resolution alignment features. > > Yep, it is misalignment. I could try to use those pixel-resolution > alignment features but I really don't think I can do a good enough job. > It is something I tried in the past but gave up since it was too complex > for me. The current code produces a Good Enough™ table and I think I > will just leave it unless Someone™ complains since after all, the > current situation is much better than what we have in Emacs 28 (the > docfix that happened as part of bug#50143 isn't in Emacs 28). I thought vtable.el was about solving such problems? > BTW, do you have any other code/documentation review? And what about > the patch I posted in https://lists.gnu.org/archive/html/bug-gnu-emacs/2022-06/msg02256.html? > No rush but I would like to know if it can go in since it only addresses > fallouts from the previous bug in this area. Thanks. It sounded to me like you are still working on the code, so I didn't see a need to review it. If you have specific parts that you'd like me to review nonetheless, please tell which parts are those.