all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: "Mattias Engdegård" <mattiase@acm.org>
Cc: emacs-devel@gnu.org
Subject: Re: master ac1d15e95c 1/2: ; * src/data.c (Fash): More precise doc string
Date: Tue, 19 Jul 2022 16:49:31 +0300	[thread overview]
Message-ID: <831quhnrf8.fsf@gnu.org> (raw)

> branch: master
> commit ac1d15e95c88592325afebb3d82c8c74a27d2627
> Author: Mattias Engdegård <mattiase@acm.org>
> Commit: Mattias Engdegård <mattiase@acm.org>
> 
>     ; * src/data.c (Fash): More precise doc string
> ---
>  src/data.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/src/data.c b/src/data.c
> index 568349ba83..b2fcdaebee 100644
> --- a/src/data.c
> +++ b/src/data.c
> @@ -3519,7 +3519,9 @@ representation.  */)
>  DEFUN ("ash", Fash, Sash, 2, 2, 0,
>         doc: /* Return VALUE with its bits shifted left by COUNT.
>  If COUNT is negative, shifting is actually to the right.
> -In this case, the sign bit is duplicated.  */)
> +The return value is always VALUE multiplied by 2 to the power of COUNT,
> +rounding down (towards negative infinity).
> +VALUE and COUNT must be integers.  */)
>    (Lisp_Object value, Lisp_Object count)

I'm afraid I find the modified doc string less self-explanatory wrt
what happens when VALUE is negative.  It might be more accurate, but
makes it harder to understand what happens in that case.

Can we do better here, please?

Thanks.



             reply	other threads:[~2022-07-19 13:49 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-07-19 13:49 Eli Zaretskii [this message]
2022-07-19 14:19 ` master ac1d15e95c 1/2: ; * src/data.c (Fash): More precise doc string Mattias Engdegård
2022-07-19 14:26   ` Eli Zaretskii
2022-07-19 15:08     ` Mattias Engdegård
2022-07-19 15:54       ` Eli Zaretskii
2022-07-19 17:46         ` Mattias Engdegård
2022-07-19 19:04           ` Eli Zaretskii
2022-07-20  5:57         ` Richard Stallman
2022-07-19 16:29   ` Stefan Monnier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=831quhnrf8.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=emacs-devel@gnu.org \
    --cc=mattiase@acm.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.