From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#57400: 29.0.50; Support sending patches from VC directly Date: Thu, 13 Oct 2022 23:33:34 +0300 Message-ID: <831qrba2g1.fsf@gnu.org> References: <84v8qgn1z9.fsf@iki.fi> <87h71zo3p8.fsf@posteo.net> <87sfljmgwz.fsf@posteo.net> <87y1twvima.fsf@posteo.net> <84sfk2p846.fsf@iki.fi> <87h70i9ntt.fsf@posteo.net> <87edvl6vbj.fsf@gmail.com> <8735c1nn3y.fsf@posteo.net> <877d1d6rcy.fsf@gmail.com> <867d1cjc8w.fsf@mail.linkov.net> <87o7unkggk.fsf@posteo.net> <86edvids93.fsf@mail.linkov.net> <87zge52nx0.fsf@posteo.net> <86sfjvqz68.fsf@mail.linkov.net> <87edvecg45.fsf@posteo.net> <86r0ze2ldb.fsf@mail.linkov.net> <871qrchzli.fsf@posteo.net> <86tu471vhq.fsf@mail.linkov.net> <875ygnjyp0.fsf@posteo.net> <87mt9zii8w.fsf@posteo.net> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="37743"; mail-complaints-to="usenet@ciao.gmane.io" Cc: rpluim@gmail.com, 57400@debbugs.gnu.org, ane@iki.fi, juri@linkov.net To: Philip Kaludercic Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Oct 13 22:38:54 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oj4yj-0009ap-5M for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 13 Oct 2022 22:38:53 +0200 Original-Received: from localhost ([::1]:45196 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oj4yh-00013b-VX for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 13 Oct 2022 16:38:51 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:51092) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oj4u2-0002js-Ro for bug-gnu-emacs@gnu.org; Thu, 13 Oct 2022 16:34:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:35988) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oj4u2-0002BE-FW for bug-gnu-emacs@gnu.org; Thu, 13 Oct 2022 16:34:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oj4u1-0004q1-UC for bug-gnu-emacs@gnu.org; Thu, 13 Oct 2022 16:34:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 13 Oct 2022 20:34:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 57400 X-GNU-PR-Package: emacs Original-Received: via spool by 57400-submit@debbugs.gnu.org id=B57400.166569323618585 (code B ref 57400); Thu, 13 Oct 2022 20:34:01 +0000 Original-Received: (at 57400) by debbugs.gnu.org; 13 Oct 2022 20:33:56 +0000 Original-Received: from localhost ([127.0.0.1]:35066 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oj4tv-0004pg-M7 for submit@debbugs.gnu.org; Thu, 13 Oct 2022 16:33:55 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:43294) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oj4tt-0004pR-VH for 57400@debbugs.gnu.org; Thu, 13 Oct 2022 16:33:54 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:46502) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oj4tm-0002AF-QH; Thu, 13 Oct 2022 16:33:46 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=ZUHO52hgY4RBL2KoJ1QSxihbDPapWBo1nXvzzMh0eZY=; b=UCnph9JBHXYH iKdv72xgYnLua56B0Dmzjl3edFkCylp/eQJi5n3HXrJkoJozejHYXiVD/616x63u+dKav3oRgvTOV MrpCKOAMsrfDvrvqYsQHcMPImODv52p9oIXVbsIlTMht8iAo/XWM38PODcLGM1ofMxLOfrn/+ky0j 9qQCdX2UnLRdA6KtnBSvX3L43dCH5DNZ6kay/Q19qe2a+FVtZo4eXUyBab2fz97CifpID4/FeaJhX 6+2w/x8KuSGHhhwbaB6wZLrWR58/i8RWXbuxD4U9lOWoVKPtE16O0XW8Y+2jCmcvgkJYNkUZfQN1Z kyktblB4Gf9feEKh7ahwpg==; Original-Received: from [87.69.77.57] (port=3999 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oj4tm-0002sI-9T; Thu, 13 Oct 2022 16:33:46 -0400 In-Reply-To: <87mt9zii8w.fsf@posteo.net> (message from Philip Kaludercic on Thu, 13 Oct 2022 20:25:03 +0000) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:245355 Archived-At: > Cc: Robert Pluim , 57400@debbugs.gnu.org, > Antoine Kalmbach > From: Philip Kaludercic > Date: Thu, 13 Oct 2022 20:25:03 +0000 > > -(defun vc-git-symbolic-commit (commit) > +(defun vc-git-symbolic-commit (commit &optional force) > "Translate COMMIT string into symbolic form. > -Returns nil if not possible." > +Returns nil if not possible. And if possible? I guess the first sentence lacks something it should say about that? (Also, we use "Return", not "Returns", to be consistent with "Translate".) > If the optional argument FORCE is > +non-nil, revisions containing positional > +arguments (e.g. \"master~8\") will also be accepted." It is not a good idea to use "also" when you didn't explain before that what this does without FORCE. (Maybe this should be part of the explanation of what you mean by "not possible" above?) Also, there's a passive tense here... And finally, you use "positional arguments", but "man gitrevisions" doesn't use this term at all. So maybe we should use a more accepted terminology, or at least provide more than just one example to explain that via the examples? Thanks.