From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#59458: [PATCH] Fix tracing for advanced scoring Date: Thu, 24 Nov 2022 11:24:44 +0200 Message-ID: <831qpsyaar.fsf@gnu.org> References: <20221121213055.2387178-1-stlman@poczta.fm> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="31724"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 59458@debbugs.gnu.org To: =?UTF-8?Q?=C5=81ukasz?= Stelmach , Lars Ingebrigtsen , Eric Abrahamsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Nov 24 10:25:13 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oy8Tp-00084g-Ap for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 24 Nov 2022 10:25:13 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oy8Tg-0003OK-S6; Thu, 24 Nov 2022 04:25:04 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oy8Te-0003Ll-MD for bug-gnu-emacs@gnu.org; Thu, 24 Nov 2022 04:25:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oy8Te-0001bD-Co for bug-gnu-emacs@gnu.org; Thu, 24 Nov 2022 04:25:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oy8Td-0004kj-TS for bug-gnu-emacs@gnu.org; Thu, 24 Nov 2022 04:25:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 24 Nov 2022 09:25:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 59458 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 59458-submit@debbugs.gnu.org id=B59458.166928187818236 (code B ref 59458); Thu, 24 Nov 2022 09:25:01 +0000 Original-Received: (at 59458) by debbugs.gnu.org; 24 Nov 2022 09:24:38 +0000 Original-Received: from localhost ([127.0.0.1]:57271 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oy8TF-0004k3-Hd for submit@debbugs.gnu.org; Thu, 24 Nov 2022 04:24:37 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:49934) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oy8TD-0004jo-B4 for 59458@debbugs.gnu.org; Thu, 24 Nov 2022 04:24:36 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oy8T6-0001V3-LQ; Thu, 24 Nov 2022 04:24:28 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=yxghuoB3BLo2PyHuSfbJM3dv0wdAHfkd6K++8y+oLCs=; b=IX6OwdjcK61Wn09xDrzG TQJGc4dJUm0cZsXnqma6i9+r/zbRIeuyL9hFFcacpvfLb7X7xLLSrt6BNSPNImBe/wTpIlGMrEn7+ NFzi3KuT70audjj5jvgA+Pcd3i9ENdef9ZwYXJkv2cGHSHFQKt4jaOo0n3uXn6upWGAJBgZIn3TEI hAAc8dPBGe3102PHt0xnCuX54b+/IAUZlFQCJd9ovbG1G0U2mRGlbtkKtw9gvIEHJqMih6d4AY71G 0gMeN9sMOAgpZ0O912cqSGSkW+EjGZRwfFed1N3WktAW2h3aCZQAdwYGJhhEc2cUh9q+sf2GstsCs eSLacHRQqzCTuQ==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oy8T4-0004sm-NY; Thu, 24 Nov 2022 04:24:27 -0500 In-Reply-To: <20221121213055.2387178-1-stlman@poczta.fm> (message from =?UTF-8?Q?=C5=81ukasz?= Stelmach on Mon, 21 Nov 2022 22:30:55 +0100) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:248837 Archived-At: > Cc: Łukasz Stelmach > From: Łukasz Stelmach > Date: Mon, 21 Nov 2022 22:30:55 +0100 > > * lisp/gnus/gnus-logic.el (gnus-score-advanced): Move the tracing > code outside of if so it's executed for both branches. > --- > lisp/gnus/gnus-logic.el | 10 +++++----- > 1 file changed, 5 insertions(+), 5 deletions(-) > > diff --git a/lisp/gnus/gnus-logic.el b/lisp/gnus/gnus-logic.el > index c1b559ba6f4..346d8a28910 100644 > --- a/lisp/gnus/gnus-logic.el > +++ b/lisp/gnus/gnus-logic.el > @@ -71,11 +71,11 @@ > (+ (cdr score) new-score)) > (push (cons (mail-header-number gnus-advanced-headers) > new-score) > - gnus-newsgroup-scored) > - (when trace > - (push (cons "A file" rule) > - ;; Must be synced with `gnus-score-edit-file-at-point'. > - gnus-score-trace))))))) > + gnus-newsgroup-scored)) > + (when trace > + (push (cons "A file" rule) > + ;; Must be synced with `gnus-score-edit-file-at-point'. > + gnus-score-trace)))))) > > (defun gnus-advanced-score-rule (rule) > "Apply RULE to `gnus-advanced-headers'." > -- > 2.30.2 Lars, Eric, Any comments? Is this good to go in? Thanks.