From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#60054: 29.0.60; Infinite loop when there are cyclic path in the parse tree Date: Sun, 18 Dec 2022 08:00:39 +0200 Message-ID: <831qoxgsjc.fsf@gnu.org> References: <23FFD6B5-D97E-4BEC-9027-EF47EBE89BD6@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="31338"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 60054@debbugs.gnu.org To: Yuan Fu Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Dec 18 07:01:25 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1p6mjj-00080h-Jx for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 18 Dec 2022 07:01:23 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1p6mjY-00059l-Lt; Sun, 18 Dec 2022 01:01:12 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p6mjO-00058G-NN for bug-gnu-emacs@gnu.org; Sun, 18 Dec 2022 01:01:10 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1p6mjO-0006PZ-F1 for bug-gnu-emacs@gnu.org; Sun, 18 Dec 2022 01:01:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1p6mjO-0001Fd-4D for bug-gnu-emacs@gnu.org; Sun, 18 Dec 2022 01:01:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 18 Dec 2022 06:01:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 60054 X-GNU-PR-Package: emacs Original-Received: via spool by 60054-submit@debbugs.gnu.org id=B60054.16713432434791 (code B ref 60054); Sun, 18 Dec 2022 06:01:02 +0000 Original-Received: (at 60054) by debbugs.gnu.org; 18 Dec 2022 06:00:43 +0000 Original-Received: from localhost ([127.0.0.1]:60158 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p6mj4-0001FD-M8 for submit@debbugs.gnu.org; Sun, 18 Dec 2022 01:00:42 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:46348) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p6mj2-0001F5-Pf for 60054@debbugs.gnu.org; Sun, 18 Dec 2022 01:00:41 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p6miw-0006Nl-1Y; Sun, 18 Dec 2022 01:00:35 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=Y2gyyulh04LBrf70OYCT1jJ06g6YzxsFGUdYTMbwYqg=; b=pRVlVgMgsAPMmR8jO6u9 lxLkICyAIIB/xA91eKtCdhZAyB/1fThWAi1t18bgW4mEP999J+yO4/9+rCllmSGFnKy3KLY8YTyJK TV8oQPk95WtkVM3WDDUJjDk2AAuL2iisK15sURUJDUOsyCnuYG8TPyPwcVxCueKavyCpu9OUS7VvX I+M1dO3Lk8BnG7jASIQmtXQl8zyQwHzk+Q73FWViGn0r/0WIYplEWy9WBS7AkMo6ccp03r+aU8RQr mMXjx5PSAmTz6Ky7aJXyxcmpOecFazrIHEoUyajWqAyYpRX5U4me9ruNyEZZH4EvI+fjzkxE5FFlA Qo8ri7qUhrVN4g==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p6miu-0005cI-3e; Sun, 18 Dec 2022 01:00:33 -0500 In-Reply-To: <23FFD6B5-D97E-4BEC-9027-EF47EBE89BD6@gmail.com> (message from Yuan Fu on Sat, 17 Dec 2022 15:28:01 -0800) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:251333 Archived-At: > From: Yuan Fu > Date: Sat, 17 Dec 2022 15:28:01 -0800 > Cc: 60054@debbugs.gnu.org > > > In this particular case, it is the siblings’ parent that equals to the > > node. Ie, node->sibling->parent = node. If your intention is to protect > > us from this particular case, switching to use cursors will avoid this > > bug. > > Ok, I made the change to use cursor API with tests. Hopefully this is > the last time we need to change treesit.c before release. This broke the Windows build (I fixed it). You cannot start using new tree-sitter functions without adding the boilerplate code for loading them dynamically from the shared library at run time. > The node->sibling->parent = node cyclic path should be fixed by this > change, do you still want checks for it? If that problem can never happen, there's no need for the checks. Thanks.