From: Eli Zaretskii <eliz@gnu.org>
To: Yuan Fu <casouri@gmail.com>
Cc: 60054@debbugs.gnu.org
Subject: bug#60054: 29.0.60; Infinite loop when there are cyclic path in the parse tree
Date: Sun, 18 Dec 2022 08:00:39 +0200 [thread overview]
Message-ID: <831qoxgsjc.fsf@gnu.org> (raw)
In-Reply-To: <23FFD6B5-D97E-4BEC-9027-EF47EBE89BD6@gmail.com> (message from Yuan Fu on Sat, 17 Dec 2022 15:28:01 -0800)
> From: Yuan Fu <casouri@gmail.com>
> Date: Sat, 17 Dec 2022 15:28:01 -0800
> Cc: 60054@debbugs.gnu.org
>
> > In this particular case, it is the siblings’ parent that equals to the
> > node. Ie, node->sibling->parent = node. If your intention is to protect
> > us from this particular case, switching to use cursors will avoid this
> > bug.
>
> Ok, I made the change to use cursor API with tests. Hopefully this is
> the last time we need to change treesit.c before release.
This broke the Windows build (I fixed it). You cannot start using new
tree-sitter functions without adding the boilerplate code for loading
them dynamically from the shared library at run time.
> The node->sibling->parent = node cyclic path should be fixed by this
> change, do you still want checks for it?
If that problem can never happen, there's no need for the checks.
Thanks.
next prev parent reply other threads:[~2022-12-18 6:00 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-14 0:11 bug#60054: 29.0.60; Infinite loop when there are cyclic path in the parse tree Yuan Fu
2022-12-14 12:08 ` Eli Zaretskii
2022-12-14 20:27 ` Yuan Fu
2022-12-15 6:16 ` Eli Zaretskii
2022-12-16 1:14 ` Yuan Fu
2022-12-17 23:28 ` Yuan Fu
2022-12-18 6:00 ` Eli Zaretskii [this message]
2022-12-18 8:10 ` Yuan Fu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=831qoxgsjc.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=60054@debbugs.gnu.org \
--cc=casouri@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.