From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#61022: 28.2.50; Mouse tracking of high coordinates not working in rxvt-unicode Date: Tue, 24 Jan 2023 14:24:42 +0200 Message-ID: <831qnki0hh.fsf@gnu.org> References: <87sfg2nyy5.fsf@home.thecybershadow.net> <83y1ptie7y.fsf@gnu.org> <6f9506a6b306d47ef6064747c4cecb75@finder.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="10529"; mail-complaints-to="usenet@ciao.gmane.io" Cc: git@vladimir.panteleev.md, 61022@debbugs.gnu.org To: Jared Finder Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Jan 24 13:25:53 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pKIN6-0002U7-6e for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 24 Jan 2023 13:25:52 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pKIMK-0005R1-Tr; Tue, 24 Jan 2023 07:25:04 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pKIMI-0005GT-TN for bug-gnu-emacs@gnu.org; Tue, 24 Jan 2023 07:25:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pKIMI-0007aY-H1 for bug-gnu-emacs@gnu.org; Tue, 24 Jan 2023 07:25:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pKIMI-0000ju-1e for bug-gnu-emacs@gnu.org; Tue, 24 Jan 2023 07:25:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 24 Jan 2023 12:25:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 61022 X-GNU-PR-Package: emacs Original-Received: via spool by 61022-submit@debbugs.gnu.org id=B61022.16745630842815 (code B ref 61022); Tue, 24 Jan 2023 12:25:02 +0000 Original-Received: (at 61022) by debbugs.gnu.org; 24 Jan 2023 12:24:44 +0000 Original-Received: from localhost ([127.0.0.1]:56034 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pKIM0-0000jK-6R for submit@debbugs.gnu.org; Tue, 24 Jan 2023 07:24:44 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:55588) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pKILx-0000j8-My for 61022@debbugs.gnu.org; Tue, 24 Jan 2023 07:24:42 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pKILr-0007Tq-3r; Tue, 24 Jan 2023 07:24:35 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=ExEjf/qqBxoiZNuRMbTGFbCEbrVCs/WxCy67ohJBzmU=; b=R9Q7X8LUQNFYhK0Ym1gs PxmR8pCiYyvFIs98DQWdn6pPksVbBKYBAHhZbPmqvIAPLcrtWHUJI6v0lHsArLgYwy+iQp1kw0yTn 2yKZ16VQkAJf69+RsgpJaWMF9OLRAO/3u33iUYywb9TKlkgx4rdOl6lggVQzRpmCJL40AW4pOE8rB uTm+uzVQmfrCYJzFqtOkC870JFo04g6ieYwcUWp2gK+GjvspOGJCmluGrNbLgZ45bW+n0SDdF7LOI GEQmq7oRBaGUU0QR9KlgYMorFxQROqus2b3sJywPy5LfB2amwyld+S3nkEYog9MgZtf42QRUy7xr2 icTWpCY/6ggYcQ==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pKILo-0000FM-Pl; Tue, 24 Jan 2023 07:24:34 -0500 In-Reply-To: <6f9506a6b306d47ef6064747c4cecb75@finder.org> (message from Jared Finder on Mon, 23 Jan 2023 22:56:09 -0800) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:254043 Archived-At: > Date: Mon, 23 Jan 2023 22:56:09 -0800 > From: Jared Finder > Cc: git@vladimir.panteleev.md, 61022@debbugs.gnu.org > > The change mostly works as inherit-input-method also causes UTF-8 > decoding to happen deep in read_char at the C level. (Is this > intentional? I assume so because read-char just reads single bytes > normally.) Yes, that's how we decode keyboard input using keyboard-coding-system. > However, I think the following change is more appropriate: > > - (read-char nil nil 0.1)) > + ;; Read a character with input method conversion enabled > + ;; but no conversion to force read-char to decode UTF-8 > + ;; byte sequences. > + (let ((input-method-function nil)) > + (read-char nil t 0.1))) > > This way we don't apply an actual input method conversion to characters. > For example, without this additional change, if the 'british input > method was active, the # ==> £ conversion would > happen, causing mouse events with X=2 to instead have X=131. OK, but shouldn't we also use INHERIT-INPUT-METHOD = t in the call to read-char only when xterm-mouse-utf-8 option is set? Otherwise, we rely on read-char to not perform any conversions, but why rely on that if we already know we don't want any conversions in that case? Using nil when xterm-mouse-utf-8 is unset sounds like a more future-proof change, no? Thanks.