From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#60983: 29.0.60; Tree-sitter user-level control Date: Mon, 30 Jan 2023 15:45:18 +0200 Message-ID: <831qnc5e6p.fsf@gnu.org> References: <83tu0kkuqo.fsf@gnu.org> <87tu0k3y6t.fsf@thornhill.no> <83mt6ckqts.fsf@gnu.org> <87zgacgiwe.fsf@thornhill.no> <834jshhvjh.fsf@gnu.org> <806A8560-A675-423F-9CFC-67D50D14E304@thornhill.no> <83y1pl79el.fsf@gnu.org> <87pmaxqhnc.fsf@thornhill.no> <83v8kp5ds7.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="16140"; mail-complaints-to="usenet@ciao.gmane.io" Cc: casouri@gmail.com, 60983@debbugs.gnu.org, theo@thornhill.no To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Jan 30 14:46:20 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pMUUE-000407-U7 for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 30 Jan 2023 14:46:19 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pMUU3-0002GJ-Dt; Mon, 30 Jan 2023 08:46:07 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pMUTz-0002Ej-Ny for bug-gnu-emacs@gnu.org; Mon, 30 Jan 2023 08:46:06 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pMUTy-00037S-WF for bug-gnu-emacs@gnu.org; Mon, 30 Jan 2023 08:46:03 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pMUTy-0001MD-HU for bug-gnu-emacs@gnu.org; Mon, 30 Jan 2023 08:46:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 30 Jan 2023 13:46:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 60983 X-GNU-PR-Package: emacs Original-Received: via spool by 60983-submit@debbugs.gnu.org id=B60983.16750863345168 (code B ref 60983); Mon, 30 Jan 2023 13:46:02 +0000 Original-Received: (at 60983) by debbugs.gnu.org; 30 Jan 2023 13:45:34 +0000 Original-Received: from localhost ([127.0.0.1]:46717 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pMUTW-0001LI-Fm for submit@debbugs.gnu.org; Mon, 30 Jan 2023 08:45:34 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:53480) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pMUTU-0001L3-QI for 60983@debbugs.gnu.org; Mon, 30 Jan 2023 08:45:33 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pMUTP-0002uj-9M; Mon, 30 Jan 2023 08:45:27 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=yJyKt9evdViV4PnOiFjEzAX6lhRDLOaRWctTUgnRkM4=; b=r8w//IJja8uuyZYAMju9 E2Dzed0PuCXx2b/D6Ff2ZfYbcvoCo2yfiRlau3ZcIBa/8Nnk9dkfNVSyPWTybaJuFzuadPAfxLjuX J/0jOkz980bT4txkyvb1rbjb3zbDUPt+v84IRbfApku0vIOOEwjBfz6xtvCq5Q7Fb6rPRmFHEY7VW Thqi85Wh4TuPwfTskXxU7Ryb+SdfI78lRRv2SmgR56H4uRESKFVYmibAMzA5Z3jEBoIs1bKz5BE+A 0u6vFP+hWIImpbmCTfdYYQk8Qb4lVwjYpMypxIS+l4NHcEswJakEZLlIBC3lWLV9k5pfty9v3fSD/ cvIUVC/IMOuNEw==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pMUTN-0006VW-SU; Mon, 30 Jan 2023 08:45:27 -0500 In-Reply-To: (message from Stefan Monnier on Sun, 29 Jan 2023 21:28:29 -0500) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:254426 Archived-At: > From: Stefan Monnier > Cc: Theodor Thornhill , casouri@gmail.com, > 60983@debbugs.gnu.org > Date: Sun, 29 Jan 2023 21:28:29 -0500 > > > I asked Stefan to help precisely because I don't understand why we > > need anything beyond what we have already. I thought mode inheritance > > should have taken care of it, or at least the documentation of > > define-derived-mode seems to imply that. > > But the `define-derived-mode` uses `prog-mode` as parent, so while the > keymap does inherit from its parent mode's keymap, it's just > `prog-mode-map` rather than `c-ts-mode-map`. Ah, so it's this bit of define-derived-mode's documentation: • The new mode has its own sparse keymap, named ‘VARIANT-map’. ‘define-derived-mode’ makes the parent mode’s keymap the parent of the new map, unless ‘VARIANT-map’ is already set and already has a parent. ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^ IOW, the problem is that c-ts-base-mode defined c-ts-mode-map as its keymap, so when c-ts-mode is defined, its keymap variable "is already set and already has a parent". Thanks, this is now fixed.