From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] Fix display-buffer-use-some-window to honor reusable-frames Date: Sat, 11 Feb 2023 17:44:14 +0200 Message-ID: <831qmwjjg1.fsf@gnu.org> References: <30c3d810-ed96-a9bd-c622-1761a138515c@gmx.at> <115a6020-2b86-2653-844e-d19eb03cf62c@gmx.at> <94366f16-89d2-68dc-06cd-0989b9dd2698@gmx.at> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="34884"; mail-complaints-to="usenet@ciao.gmane.io" Cc: tgbugs@gmail.com, emacs-devel@gnu.org, larsi@gnus.org To: martin rudalics Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sat Feb 11 16:45:21 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pQs41-0008tc-CV for ged-emacs-devel@m.gmane-mx.org; Sat, 11 Feb 2023 16:45:21 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pQs3S-0004ue-6W; Sat, 11 Feb 2023 10:44:46 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pQs3Q-0004uI-9y for emacs-devel@gnu.org; Sat, 11 Feb 2023 10:44:44 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pQs3P-0005da-MQ; Sat, 11 Feb 2023 10:44:43 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=RCR95Bs9IvwbwBB/f6IX/GuKSXjNKW1ZGmgQFuEhfDQ=; b=Z3JJ4spaDhC9 +5Iz/q1UgjUz8rjkjyDx88Y2soAEa8l1nZZ5C7+zBCv2a0eXDv6vs7Ti88OJ6cj7xm+DZy6npMxhK T2b0HqodsUPsCkedg3OMXebDr0dB7zqNNielAvpvaO3kByehoZasSz53rv3e2joQ4dQSKbFlCrpfz TKPKJFSGtM1oEfU9fEXWBzgjdgLfO0MXy/vPq+QjyMVz9qVXRSlbls0ILnLopgcn5arm2Jkqr89qC TXUrIdteSspU+z4HDx+MwxqlFo10Q4DrucYxk8kKMFMPJKlVT1I+R9zbwEgrrFJbNJY/bUNmfZ8vk Kg2TCQ7MhPJRp+aalrwkBA==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pQs3P-0001ra-3W; Sat, 11 Feb 2023 10:44:43 -0500 In-Reply-To: <94366f16-89d2-68dc-06cd-0989b9dd2698@gmx.at> (message from martin rudalics on Fri, 3 Feb 2023 10:09:02 +0100) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:303143 Archived-At: > Date: Fri, 3 Feb 2023 10:09:02 +0100 > Cc: Eli Zaretskii , emacs-devel@gnu.org, larsi@gnus.org > From: martin rudalics > > > This patch produces the desired behavior for me and matches > > the xemacs behavior when I use the following. > > > > (setq display-buffer-base-action '((display-buffer-use-least-recent-window) > > (not-this-window . t))) > > > > The explicit not-this-window is required to get display-buffer-pop-up-window > > to trigger in a single window single frame case. It might be worth adding a > > note > > to that effect to the docstring? > > Silly me. Please try again with the attached. Then > > (setq display-buffer-base-action '((display-buffer-use-least-recent-window))) > (display-buffer "*Messages*") > > should work as expected. > > > This results in the behavior of the example matching that of xemacs. > > With the lru-time option enabled the display multiple buffers case seems > > to be served (I assume there is some other mechanism that can be used > > to restore the previous window configuration in such cases that is not > > included in this example). > > Sorry. I don't grok what you said in parentheses here. > > martin > > diff --git a/lisp/window.el b/lisp/window.el > index a11293d372..dffcc14ac3 100644 > --- a/lisp/window.el > +++ b/lisp/window.el Tom, would you please respond to Martin's latest message (quoted above)? I'd like to wrap up the investigation of this issue and install whatever changes you two agree upon, so that we could proceed with producing the first pretest of Emacs 29.1. TIA