From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#66183: elixir-ts-mode test failure Date: Fri, 29 Sep 2023 14:14:44 +0300 Message-ID: <831qeh1ba3.fsf@gnu.org> References: <87fs33wiki.fsf@pub.pink> <874jjg51mc.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="7408"; mail-complaints-to="usenet@ciao.gmane.io" Cc: wkirschbaum@gmail.com, 66183@debbugs.gnu.org, jm@pub.pink To: Yuan Fu Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Sep 29 13:16:12 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qmBTg-0001f0-4P for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 29 Sep 2023 13:16:12 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qmBTL-00079O-5u; Fri, 29 Sep 2023 07:15:51 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qmBTJ-000792-RI for bug-gnu-emacs@gnu.org; Fri, 29 Sep 2023 07:15:49 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qmBTI-0006Tb-Iy for bug-gnu-emacs@gnu.org; Fri, 29 Sep 2023 07:15:48 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qmBTW-0008JH-0J for bug-gnu-emacs@gnu.org; Fri, 29 Sep 2023 07:16:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 29 Sep 2023 11:16:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 66183 X-GNU-PR-Package: emacs Original-Received: via spool by 66183-submit@debbugs.gnu.org id=B66183.169598612931896 (code B ref 66183); Fri, 29 Sep 2023 11:16:01 +0000 Original-Received: (at 66183) by debbugs.gnu.org; 29 Sep 2023 11:15:29 +0000 Original-Received: from localhost ([127.0.0.1]:55422 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qmBSz-0008IM-9M for submit@debbugs.gnu.org; Fri, 29 Sep 2023 07:15:29 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:47454) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qmBSu-0008I3-9K for 66183@debbugs.gnu.org; Fri, 29 Sep 2023 07:15:27 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qmBSZ-0006IG-W1; Fri, 29 Sep 2023 07:15:04 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=3SRUR32MRvC/Y99OlApBx/dwmvDkxWFYXfL/fojGnBc=; b=aumZBszGizc/Kze/tpLe sGFxg/S80EUYLeyU4PZ+VQzgmpjJsV/BFehqHyEk9LCnIAVeLzuYayP2KknUF/K35t7Pke8nFPwL8 UuKtS8yf243ojOEHgl7kUwUxdPZeqxotCFSFh7+36mnuD0ztLpA2S73RJzuFcVu1Pyl/OYa0ndSjq 3214IlC9GVQdpX5YnhC5OMIXc9l/QW2KAQ5PSBgve6kOJpFGtK0sQ48lTCBMQJO6gYeIeUsajo7Cr r4YyfgA9VD7XHuIK/dzZXRrtX7zsq0UL2ocwaqfsOh+BBeOPG9CvrNipnvsRwIDGnAPQjmgDdsakh DGTyqN0i+3d7+g==; In-Reply-To: (message from Yuan Fu on Tue, 26 Sep 2023 11:00:23 -0700) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:271480 Archived-At: > Cc: 66183@debbugs.gnu.org, jm@pub.pink > From: Yuan Fu > Date: Tue, 26 Sep 2023 11:00:23 -0700 > > > On Sep 26, 2023, at 9:30 AM, Wilhelm Kirschbaum wrote: > > > > > > Yuan Fu writes: > > > >>> On Sep 24, 2023, at 9:53 AM, john muhl via Bug reports for GNU > >>> Emacs, the Swiss army knife of text editors > >>> wrote: > >>> The change in 5cba5ee8905 caused an elixir test to start failing. The > >>> white space at the start of the test is now in a heex range so pressing > >>> tab there matches a heex rule instead of the elixir one. Moving the > >>> dummy range to the end fixes the test. > >> > >> Thank you. I’ll make sure to remember also running elixir tests when I make a change. > >> > >> I looked around and found elixir-mode’s language-at-point function > >> works in a way that isn’t what tree-sitter functions > >> expect. Tree-sitter functions expect the major mode to derive language > >> at point by querying the host language and do some pattern matching, > >> rather than using language parser’s range. I took a quick look at > >> elixir’s grammar and came up with this version for a POC. You probably > > > > Sorry about that. I had absolutely no idea how it was expected to work. > > It’s absolutely my fault :-) Several people have had confusion about it, because the docstring wasn’t clear enough. I’ve updated the docstring so hopefully this confusion won’t occur in the future. Should this doc-string fix be cherry-picked to the release branch?