all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Yuan Fu <casouri@gmail.com>
Cc: wkirschbaum@gmail.com, 66183@debbugs.gnu.org, jm@pub.pink
Subject: bug#66183: elixir-ts-mode test failure
Date: Fri, 29 Sep 2023 14:14:44 +0300	[thread overview]
Message-ID: <831qeh1ba3.fsf@gnu.org> (raw)
In-Reply-To: <A0D74FBA-C568-4525-A283-650A3D7FC1D1@gmail.com> (message from Yuan Fu on Tue, 26 Sep 2023 11:00:23 -0700)

> Cc: 66183@debbugs.gnu.org, jm@pub.pink
> From: Yuan Fu <casouri@gmail.com>
> Date: Tue, 26 Sep 2023 11:00:23 -0700
> 
> > On Sep 26, 2023, at 9:30 AM, Wilhelm Kirschbaum <wkirschbaum@gmail.com> wrote:
> > 
> > 
> > Yuan Fu <casouri@gmail.com> writes:
> > 
> >>> On Sep 24, 2023, at 9:53 AM, john muhl via Bug reports for GNU
> >>> Emacs, the Swiss army knife of text editors <bug-gnu-emacs@gnu.org>
> >>> wrote:
> >>> The change in 5cba5ee8905 caused an elixir test to start failing. The
> >>> white space at the start of the test is now in a heex range so pressing
> >>> tab there matches a heex rule instead of the elixir one. Moving the
> >>> dummy range to the end fixes the test.
> >> 
> >> Thank you. I’ll make sure to remember also running elixir tests when I make a change.
> >> 
> >> I looked around and found elixir-mode’s language-at-point function
> >> works in a way that isn’t what tree-sitter functions
> >> expect. Tree-sitter functions expect the major mode to derive language
> >> at point by querying the host language and do some pattern matching,
> >> rather than using language parser’s range. I took a quick look at
> >> elixir’s grammar and came up with this version for a POC. You probably
> > 
> > Sorry about that.  I had absolutely no idea how it was expected to work.
> 
> It’s absolutely my fault :-) Several people have had confusion about it, because the docstring wasn’t clear enough. I’ve updated the docstring so hopefully this confusion won’t occur in the future.

Should this doc-string fix be cherry-picked to the release branch?





  parent reply	other threads:[~2023-09-29 11:14 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-09-24 16:53 bug#66183: elixir-ts-mode test failure john muhl via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-09-25  3:12 ` Yuan Fu
2023-09-25 16:01   ` john muhl via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-09-26  6:18     ` Wilhelm Kirschbaum
2023-09-26 16:30   ` Wilhelm Kirschbaum
2023-09-26 18:00     ` Yuan Fu
2023-09-26 20:26       ` Wilhelm Kirschbaum
2023-09-27  6:46         ` Yuan Fu
2023-09-27  7:17           ` Wilhelm Kirschbaum
2023-09-29 11:14       ` Eli Zaretskii [this message]
2023-10-05  7:18         ` Eli Zaretskii
2023-10-07  8:44           ` Wilhelm Kirschbaum
2023-10-07  9:05             ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=831qeh1ba3.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=66183@debbugs.gnu.org \
    --cc=casouri@gmail.com \
    --cc=jm@pub.pink \
    --cc=wkirschbaum@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.