From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#67452: 30.0.50; [PATCH] Make split-root-window functions handle argument Date: Sun, 26 Nov 2023 13:01:19 +0200 Message-ID: <831qccbwxs.fsf@gnu.org> References: Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="21158"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 67452@debbugs.gnu.org To: Cy , martin rudalics Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Nov 26 12:02:32 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1r7CuF-0005MA-Vx for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 26 Nov 2023 12:02:32 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1r7Cti-0003cq-Vm; Sun, 26 Nov 2023 06:01:58 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1r7Cth-0003cT-EZ for bug-gnu-emacs@gnu.org; Sun, 26 Nov 2023 06:01:57 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1r7Cth-00026h-4Y for bug-gnu-emacs@gnu.org; Sun, 26 Nov 2023 06:01:57 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1r7Ctm-0007wa-FS for bug-gnu-emacs@gnu.org; Sun, 26 Nov 2023 06:02:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 26 Nov 2023 11:02:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 67452 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 67452-submit@debbugs.gnu.org id=B67452.170099651230514 (code B ref 67452); Sun, 26 Nov 2023 11:02:02 +0000 Original-Received: (at 67452) by debbugs.gnu.org; 26 Nov 2023 11:01:52 +0000 Original-Received: from localhost ([127.0.0.1]:40780 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r7Ctb-0007w6-Hl for submit@debbugs.gnu.org; Sun, 26 Nov 2023 06:01:51 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:45382) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r7CtZ-0007vq-J5 for 67452@debbugs.gnu.org; Sun, 26 Nov 2023 06:01:50 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1r7CtN-000251-RZ; Sun, 26 Nov 2023 06:01:37 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=h4ILDf0cCNREZJh7OQDlu2ZKsP+O5ws6ShndLVovoK0=; b=Q1i+0DVjAgMi KajEx8fpmGoOVH89BEerNgBMF0Ag21BAOYYC5epzODNHYHtjMPIHTP16ePuHEzIFMEIb+1dAQKPFW HB5BWLcgYY5WtCkcFGYN84Wc8UdPqxuOEoHGKA5F6fYZ0EKIUZQ0g+Z1TOikAqmnJvNELB0nWqgkz RksjSrvqBkBg7lJtTefg/+90XeQQ0luSnwL0/s8YBM42fjl+9S3Sfjth88MRq+mLvoP5TPRngBi+m 7EyRNqE+kbamsZSx6LYJm/Hp5dLFmbtx1tFxnHlv2eeE2jowE0Jm8cEFXxrK8m8s+G6iegN6q5vXU RvH5iw0ng6vLKkPW0QDizQ==; In-Reply-To: (message from Cy on Sun, 26 Nov 2023 00:42:54 -0800) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:275050 Archived-At: > Date: Sun, 26 Nov 2023 00:42:54 -0800 > From: Cy > > I noticed the split-root-window-below and split-root-window-right > commands fail when passing an argument using C-u: > > split-root-window-right: Wrong type argument: number-or-marker-p, (4) > > I have edited these functions to remedy this error, and attached a > patch. I hope that the changes are satisfactory. I guess we should do this for consistency with other split-window-* commands? Martin, any reasons the split-root-window-* commands didn't follow the example of the corresponding split-window-* commands? In any case, to make the split-root-window-* commands support C-u we just need to change the interactive spec from "P" to "p", there's no need for anything more complex. Thanks.