From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Jostein =?UTF-8?Q?Kj=C3=B8nigsen?= Newsgroups: gmane.emacs.bugs Subject: bug#60376: 29.0.60; Standardize csharp-ts-mode's font-lock features Date: Mon, 2 Jan 2023 10:59:39 +0100 Message-ID: <83118080-231f-cadf-a903-58e609a82751@secure.kjonigsen.net> References: <0D5F2396-277A-4017-AE0B-371F591BD141@gmail.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="------------RIJRrmW16hTp0kN0GVkUmFCV" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="34959"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Cc: 60376@debbugs.gnu.org, eliz@gnu.org To: Yuan Fu , Theodor Thornhill Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Jan 02 11:00:16 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pCHc7-0008tE-Ck for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 02 Jan 2023 11:00:16 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pCHbw-0000tg-Gq; Mon, 02 Jan 2023 05:00:04 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pCHbv-0000t0-7z for bug-gnu-emacs@gnu.org; Mon, 02 Jan 2023 05:00:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pCHbu-0002o4-Um for bug-gnu-emacs@gnu.org; Mon, 02 Jan 2023 05:00:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pCHbu-000176-F5 for bug-gnu-emacs@gnu.org; Mon, 02 Jan 2023 05:00:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Jostein =?UTF-8?Q?Kj=C3=B8nigsen?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 02 Jan 2023 10:00:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 60376 X-GNU-PR-Package: emacs Original-Received: via spool by 60376-submit@debbugs.gnu.org id=B60376.16726535934211 (code B ref 60376); Mon, 02 Jan 2023 10:00:02 +0000 Original-Received: (at 60376) by debbugs.gnu.org; 2 Jan 2023 09:59:53 +0000 Original-Received: from localhost ([127.0.0.1]:42509 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pCHbk-00015q-Nr for submit@debbugs.gnu.org; Mon, 02 Jan 2023 04:59:53 -0500 Original-Received: from wout1-smtp.messagingengine.com ([64.147.123.24]:38195) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pCHbj-00015d-6e for 60376@debbugs.gnu.org; Mon, 02 Jan 2023 04:59:51 -0500 Original-Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailout.west.internal (Postfix) with ESMTP id 80B8C3200930; Mon, 2 Jan 2023 04:59:44 -0500 (EST) Original-Received: from mailfrontend1 ([10.202.2.162]) by compute2.internal (MEProxy); Mon, 02 Jan 2023 04:59:44 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= secure.kjonigsen.net; h=cc:cc:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm1; t=1672653584; x= 1672739984; bh=ce0pirZTi+rvUuA9yxMx9IVwEappowPWnFDU2aK1v/4=; b=M dq8YEx94jt8w68KG1csNXBj7pYZNv0ortU1dqlJ3kOITKuIzEiR7Kjg4jEQs+kF6 y6FaiS/cjkipuclqMKao3Lumg0bC6n4txqySKno9h8W+AXQ66N+96O4u7WlryMEO J/RNUmeHmCISSUSEzbEtqRBsSpVwVsdA3vudn2+/y36QOXpHrRKjgIwew4d0U+nm 5KHlso7+Yl514ijIAfV/wtPSXq/K5iS9QmQ5/knn7buJrNrREuZFRZ2e4x/47UJG p6Cf7DSB0EM2qCHh6Oir2urPeaj1URmXMgowL5yWvQtrBsdslC7rDD+1MektVSmZ YeYgAR54y0gY0VOfnxFgQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:sender:subject:subject:to:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm2; t=1672653584; x=1672739984; bh=ce0pirZTi+rvUuA9yxMx9IVwEapp owPWnFDU2aK1v/4=; b=maoRBkR1W84/ssW+eQppwsMXzcwcmJ6YSyBSzZrjYFC4 4OIushd/18C+w5O0c+6NEXRwtIApe0y8jVtY8KEPT8LC2Z3a4HXpPJeitaekwkFo 9bCOsoIAxgIRSPmeDC+gmPV7VGhIk+T6b9R59+hcIwDP60y7sa/0WIMoyCMSUn5f G4EQuEMsqPdXjFkb5dyJG4FChDSBfaMScNmqu8Ug15wlUPmNGEzCtnRYacT1nVGY 9MqHeHLHNkBCFguvyB7X8BT9OQIWbGKWAZM48mW0iqurowO1OC6CVgoXu8FVwPkR mDpzEJIOGHPFTZuBjB/L2AQs5cyEqMqS53BQNi+RZg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrjedvgdduudcutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpegtkfffgggfuffvvehfhfgjsehmtderredtfeejnecuhfhrohhmpeflohhsthgv ihhnucfmjhppnhhighhsvghnuceojhhoshhtvghinhesshgvtghurhgvrdhkjhhonhhigh hsvghnrdhnvghtqeenucggtffrrghtthgvrhhnpeehudeigeegheehhfeujeefvdehjeei ffejvdeuvefhieegleeghefhjeevgfekteenucevlhhushhtvghrufhiiigvpedtnecurf grrhgrmhepmhgrihhlfhhrohhmpehjohhsthgvihhnsehsvggtuhhrvgdrkhhjohhnihhg shgvnhdrnhgvth X-ME-Proxy: Feedback-ID: ib2f84088:Fastmail Original-Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 2 Jan 2023 04:59:43 -0500 (EST) Content-Language: en-US In-Reply-To: <0D5F2396-277A-4017-AE0B-371F591BD141@gmail.com> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:252318 Archived-At: This is a multi-part message in MIME format. --------------RIJRrmW16hTp0kN0GVkUmFCV Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 02.01.2023 01:12, Yuan Fu wrote: > Fantastic! I applied the patch, thanks! > > Yuan Great! Thanks! Please note: The previous patch removed a very wide (generic_name (identifier)) selector, which incorrectly caused generic functions to be highlighted as a types. This has lead to having to add in more specific (xxx (generic_name (identifier)) selectors around the codebase to compensate, and the previous patch evidently didn't have "all" the ones we need. Attached is a very small patch which should make support for highlighting generic types more complete. I won't promise it has 100% coverage, but with this in place, I can't see any obvious places in code where I'm missing out. With this in place, the only thing I'd like to improve now (if any) is indentation for object-creation/initialization expressions. I've made a few attempts and can't get those to behave properly. Is this anything you could take a look at, Theo? :) -- Jostein --------------RIJRrmW16hTp0kN0GVkUmFCV Content-Type: text/plain; charset=UTF-8; name="patch.txt" Content-Disposition: attachment; filename="patch.txt" Content-Transfer-Encoding: base64 RnJvbSA3NzMyNTQ0MmRlMmIzZDJkNmQ0ZmZjNDIyM2UwMGMwYTk1NmNmMjU2IE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiA9P1VURi04P3E/Sm9zdGVpbj0yMEtqPUMzPUI4bmln c2VuPz0gPGpvc3RlaW5Aa2pvbmlnc2VuLm5ldD4KRGF0ZTogU3VuLCAxIEphbiAyMDIzIDIw OjQ2OjAyICswMTAwClN1YmplY3Q6IFtQQVRDSF0gRnVydGhlciBnZW5lcmljLXJlbGF0ZWQg aW1wcm92ZW1lbnRzLgoKLS0tCiBsaXNwL3Byb2dtb2Rlcy9jc2hhcnAtbW9kZS5lbCB8IDMg KysrCiAxIGZpbGUgY2hhbmdlZCwgMyBpbnNlcnRpb25zKCspCgpkaWZmIC0tZ2l0IGEvbGlz cC9wcm9nbW9kZXMvY3NoYXJwLW1vZGUuZWwgYi9saXNwL3Byb2dtb2Rlcy9jc2hhcnAtbW9k ZS5lbAppbmRleCA0NzNlOGY0OWZkMy4uNzlhZmQ3ZjkxZGMgMTAwNjQ0Ci0tLSBhL2xpc3Av cHJvZ21vZGVzL2NzaGFycC1tb2RlLmVsCisrKyBiL2xpc3AvcHJvZ21vZGVzL2NzaGFycC1t b2RlLmVsCkBAIC03NzMsOSArNzczLDEyIEBAIGNzaGFycC10cy1tb2RlLS1mb250LWxvY2st c2V0dGluZ3MKICAgICAgKGFycmF5X3R5cGUKICAgICAgIChpZGVudGlmaWVyKSBAZm9udC1s b2NrLXR5cGUtZmFjZSkKICAgICAgKGNhc3RfZXhwcmVzc2lvbiAoaWRlbnRpZmllcikgQGZv bnQtbG9jay10eXBlLWZhY2UpCisgICAgIChjYXN0X2V4cHJlc3Npb24gKGdlbmVyaWNfbmFt ZSAoaWRlbnRpZmllcikgQGZvbnQtbG9jay10eXBlLWZhY2UpKQogICAgICBbIm9wZXJhdG9y Il0gQGZvbnQtbG9jay10eXBlLWZhY2UKICAgICAgKHR5cGVfcGFyYW1ldGVyX2NvbnN0cmFp bnRzX2NsYXVzZQogICAgICAgdGFyZ2V0OiAoaWRlbnRpZmllcikgQGZvbnQtbG9jay10eXBl LWZhY2UpCisgICAgICh0eXBlX2NvbnN0cmFpbnQgdHlwZTogKGlkZW50aWZpZXIpIEBmb250 LWxvY2stdHlwZS1mYWNlKQorICAgICAodHlwZV9jb25zdHJhaW50IHR5cGU6IChnZW5lcmlj X25hbWUgKGlkZW50aWZpZXIpIEBmb250LWxvY2stdHlwZS1mYWNlKSkKICAgICAgKHR5cGVf b2ZfZXhwcmVzc2lvbiAoaWRlbnRpZmllcikgQGZvbnQtbG9jay10eXBlLWZhY2UpCiAgICAg IChvYmplY3RfY3JlYXRpb25fZXhwcmVzc2lvbgogICAgICAgdHlwZTogKGlkZW50aWZpZXIp IEBmb250LWxvY2stdHlwZS1mYWNlKQotLSAKMi4zNy4yCg== --------------RIJRrmW16hTp0kN0GVkUmFCV--