From: Kazuhiro Ito <kzhr@d1.dion.ne.jp>
To: 6918@debbugs.gnu.org
Subject: bug#6918: Colors of xbm image are swapped on Windows
Date: Thu, 26 Aug 2010 17:42:31 +0900 [thread overview]
Message-ID: <82tymhzrwo.wl%kzhr@d1.dion.ne.jp> (raw)
[-- Attachment #1: Type: text/plain, Size: 1237 bytes --]
When I evaluate below expression with Emacs on Windows, colors of the
second image are swapped. With Emacs on other environment
(e.g. Debian), second image is identical to first image.
(let ((image "#define default_width 8
#define default_height 16
static char default_bits[] = {
0x81, 0x81, 0x42, 0x42, 0x24, 0x24, 0x18, 0x18, 0x18,
0x18, 0x24, 0x24, 0x42, 0x42, 0x81, 0x81};")
(face 'default)
(string "_"))
(set-text-properties 0 (length string) `(face ,face) string)
(with-temp-buffer
(switch-to-buffer (current-buffer))
(insert-image
(create-image image 'xbm t) string)
(sit-for 1)
(insert-image
(create-image image 'xbm t
:foreground (face-foreground face)
:background (face-background face)
) string)
(sit-for 3)))
Attached patch would fix problem. But I don't know this patch is
correct, because this swapping seems intended.
> 2007-06-21 Jason Rumney <jasonr@gnu.org>
> * image.c (convert_mono_to_color_image): Swap fore and background.
I guess this swapping has become unnecessary anymore by later change.
> 2007-12-05 Jason Rumney <jasonr@gnu.org>
> * image.c (xbm_load) [WINDOWSNT]: Shuffle the bits of directly
> specified XBMs.
--
Kazuhiro Ito
[-- Attachment #2: image.c.diff --]
[-- Type: application/octet-stream, Size: 539 bytes --]
=== modified file 'src/image.c'
--- src/image.c 2010-06-19 19:43:47 +0000
+++ src/image.c 2010-08-26 07:35:54 +0000
@@ -2643,8 +2643,8 @@
new_prev = SelectObject (new_img_dc, new_pixmap);
/* Windows convention for mono bitmaps is black = background,
white = foreground. */
- SetTextColor (new_img_dc, background);
- SetBkColor (new_img_dc, foreground);
+ SetTextColor (new_img_dc, foreground);
+ SetBkColor (new_img_dc, background);
BitBlt (new_img_dc, 0, 0, img->width, img->height, old_img_dc,
0, 0, SRCCOPY);
next reply other threads:[~2010-08-26 8:42 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-26 8:42 Kazuhiro Ito [this message]
2019-09-26 17:59 ` bug#6918: Colors of xbm image are swapped on Windows Lars Ingebrigtsen
2019-09-26 18:31 ` Eli Zaretskii
2019-09-26 18:34 ` Lars Ingebrigtsen
2019-09-26 18:44 ` Eli Zaretskii
2019-09-26 21:38 ` Jason Rumney
2019-09-27 5:30 ` Eli Zaretskii
2019-10-10 6:59 ` Jason Rumney
2019-10-10 8:17 ` Eli Zaretskii
2021-11-05 13:26 ` Stefan Kangas
2021-11-06 11:35 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=82tymhzrwo.wl%kzhr@d1.dion.ne.jp \
--to=kzhr@d1.dion.ne.jp \
--cc=6918@debbugs.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.