From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Robert Pluim Newsgroups: gmane.emacs.bugs Subject: bug#19909: [PATCH] Error out if with-file-notification=w32 is specified on cygwin Date: Fri, 20 Feb 2015 15:16:49 +0100 Organization: not if I can help it Message-ID: <82sie0fz1q.fsf@gmail.com> References: <821tlkhq2v.fsf@gmail.com> <83mw48lwvx.fsf@gnu.org> <82wq3cga1n.fsf@gmail.com> <83ioewlv1v.fsf@gnu.org> Reply-To: bug-gnu-emacs@gnu.org NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1424441904 24922 80.91.229.3 (20 Feb 2015 14:18:24 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 20 Feb 2015 14:18:24 +0000 (UTC) To: 19909@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Feb 20 15:18:12 2015 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1YOoPD-0008Hh-No for geb-bug-gnu-emacs@m.gmane.org; Fri, 20 Feb 2015 15:18:11 +0100 Original-Received: from localhost ([::1]:60717 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YOoPD-0008MW-7A for geb-bug-gnu-emacs@m.gmane.org; Fri, 20 Feb 2015 09:18:11 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:49868) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YOoP8-0008LL-MA for bug-gnu-emacs@gnu.org; Fri, 20 Feb 2015 09:18:07 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YOoP4-0005PG-Fm for bug-gnu-emacs@gnu.org; Fri, 20 Feb 2015 09:18:06 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:58030) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YOoP4-0005PC-CZ for bug-gnu-emacs@gnu.org; Fri, 20 Feb 2015 09:18:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1YOoP3-0002qV-TX for bug-gnu-emacs@gnu.org; Fri, 20 Feb 2015 09:18:01 -0500 X-Loop: help-debbugs@gnu.org In-Reply-To: <821tlkhq2v.fsf@gmail.com> Resent-From: Robert Pluim Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 20 Feb 2015 14:18:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 19909 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.142444184810896 (code B ref -1); Fri, 20 Feb 2015 14:18:01 +0000 Original-Received: (at submit) by debbugs.gnu.org; 20 Feb 2015 14:17:28 +0000 Original-Received: from localhost ([127.0.0.1]:49270 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YOoOV-0002pf-MC for submit@debbugs.gnu.org; Fri, 20 Feb 2015 09:17:28 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:47997) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YOoOS-0002pX-V9 for submit@debbugs.gnu.org; Fri, 20 Feb 2015 09:17:25 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YOoOO-0005GF-MJ for submit@debbugs.gnu.org; Fri, 20 Feb 2015 09:17:24 -0500 Original-Received: from lists.gnu.org ([2001:4830:134:3::11]:49675) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YOoOO-0005GB-KK for submit@debbugs.gnu.org; Fri, 20 Feb 2015 09:17:20 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:49702) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YOoON-0008Jy-K4 for bug-gnu-emacs@gnu.org; Fri, 20 Feb 2015 09:17:20 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YOoOJ-0005Bo-C6 for bug-gnu-emacs@gnu.org; Fri, 20 Feb 2015 09:17:19 -0500 Original-Received: from plane.gmane.org ([80.91.229.3]:42117) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YOoOJ-00059U-4o for bug-gnu-emacs@gnu.org; Fri, 20 Feb 2015 09:17:15 -0500 Original-Received: from list by plane.gmane.org with local (Exim 4.69) (envelope-from ) id 1YOoOH-0007qC-Qc for bug-gnu-emacs@gnu.org; Fri, 20 Feb 2015 15:17:13 +0100 Original-Received: from vav06-1-78-207-202-9.fbx.proxad.net ([78.207.202.9]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Fri, 20 Feb 2015 15:17:13 +0100 Original-Received: from rpluim by vav06-1-78-207-202-9.fbx.proxad.net with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Fri, 20 Feb 2015 15:17:13 +0100 X-Injected-Via-Gmane: http://gmane.org/ Mail-Followup-To: bug-gnu-emacs@gnu.org Original-Lines: 39 Original-X-Complaints-To: usenet@ger.gmane.org X-Gmane-NNTP-Posting-Host: vav06-1-78-207-202-9.fbx.proxad.net Mail-Copies-To: never User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (cygwin) Cancel-Lock: sha1:x07DeFH3K72AHL7WA9Ik0j4j2MA= X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:99644 Archived-At: Eli Zaretskii writes: >> From: Robert Pluim >> Date: Fri, 20 Feb 2015 11:19:16 +0100 >> >> Eli Zaretskii writes: >> >> >> From: Robert Pluim >> >> Date: Fri, 20 Feb 2015 10:47:36 +0100 >> >> >> >> It's a combination that won't compile, so it's probably best to error >> >> out during configure. >> > >> > Why doesn't it compile? Perhaps it's better to allow it to compile, >> > than to error out. >> >> I guess whoever put the following in w32.h had his reasons: >> >> #ifdef CYGWIN >> #error "w32.h is not compatible with Cygwin" >> #endif > > According to the comment in w32notify.c, w32.h is included only for > w32_strerror. Could you try commenting out the w32.h inclusion, and > instead copy the w32_strerror prototype into w32notify.c? Does Emacs > compile then as part of the Cygwin-w32 build, and do file > notifications work? (I don't have Cygwin installed to try that, > sorry.) > No, that doesn't compile. w32notify.c needs (at least) w32_unicode_filenames, filename_to_utf16(), filename_to_ansi() and w32_valid_pointer_p() from w32.c. I don't think adding w32.c into the build on cygwin is going to work. Regards Robert