From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Robert Pluim Newsgroups: gmane.emacs.bugs Subject: bug#19909: [PATCH] Error out if with-file-notification=w32 is specified on cygwin Date: Fri, 20 Feb 2015 16:46:48 +0100 Organization: not if I can help it Message-ID: <82oaoofuvr.fsf@gmail.com> References: <821tlkhq2v.fsf@gmail.com> <83mw48lwvx.fsf@gnu.org> <82wq3cga1n.fsf@gmail.com> <83ioewlv1v.fsf@gnu.org> <82sie0fz1q.fsf@gmail.com> <838ufslitm.fsf@gnu.org> Reply-To: bug-gnu-emacs@gnu.org NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1424447320 23008 80.91.229.3 (20 Feb 2015 15:48:40 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 20 Feb 2015 15:48:40 +0000 (UTC) To: 19909@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Feb 20 16:48:26 2015 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1YOpoM-0000p2-5b for geb-bug-gnu-emacs@m.gmane.org; Fri, 20 Feb 2015 16:48:14 +0100 Original-Received: from localhost ([::1]:32811 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YOpoL-000624-9c for geb-bug-gnu-emacs@m.gmane.org; Fri, 20 Feb 2015 10:48:13 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:39816) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YOpoH-00061y-Kx for bug-gnu-emacs@gnu.org; Fri, 20 Feb 2015 10:48:10 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YOpoA-0001mL-M1 for bug-gnu-emacs@gnu.org; Fri, 20 Feb 2015 10:48:09 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:58386) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YOpoA-0001mB-IT for bug-gnu-emacs@gnu.org; Fri, 20 Feb 2015 10:48:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1YOpoA-0004yf-0Q for bug-gnu-emacs@gnu.org; Fri, 20 Feb 2015 10:48:02 -0500 X-Loop: help-debbugs@gnu.org In-Reply-To: <821tlkhq2v.fsf@gmail.com> Resent-From: Robert Pluim Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 20 Feb 2015 15:48:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 19909 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch X-Debbugs-Original-To: bug-gnu-emacs@gnu.org X-Debbugs-Original-Cc: 19909@debbugs.gnu.org, Ken Brown Original-Received: via spool by submit@debbugs.gnu.org id=B.142444725419095 (code B ref -1); Fri, 20 Feb 2015 15:48:01 +0000 Original-Received: (at submit) by debbugs.gnu.org; 20 Feb 2015 15:47:34 +0000 Original-Received: from localhost ([127.0.0.1]:49626 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YOpnh-0004xu-DR for submit@debbugs.gnu.org; Fri, 20 Feb 2015 10:47:33 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:37943) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YOpnf-0004xm-1P for submit@debbugs.gnu.org; Fri, 20 Feb 2015 10:47:31 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YOpnd-0001h7-Gb for submit@debbugs.gnu.org; Fri, 20 Feb 2015 10:47:30 -0500 Original-Received: from lists.gnu.org ([2001:4830:134:3::11]:52694) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YOpnd-0001h1-Dp for submit@debbugs.gnu.org; Fri, 20 Feb 2015 10:47:29 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:39654) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YOpnc-0005zz-E3 for bug-gnu-emacs@gnu.org; Fri, 20 Feb 2015 10:47:29 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YOpnZ-0001gG-4H for bug-gnu-emacs@gnu.org; Fri, 20 Feb 2015 10:47:28 -0500 Original-Received: from plane.gmane.org ([80.91.229.3]:48964) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YOpnY-0001g9-Tc for bug-gnu-emacs@gnu.org; Fri, 20 Feb 2015 10:47:25 -0500 Original-Received: from list by plane.gmane.org with local (Exim 4.69) (envelope-from ) id 1YOpnU-0000HV-JZ for bug-gnu-emacs@gnu.org; Fri, 20 Feb 2015 16:47:20 +0100 Original-Received: from vav06-1-78-207-202-9.fbx.proxad.net ([78.207.202.9]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Fri, 20 Feb 2015 16:47:20 +0100 Original-Received: from rpluim by vav06-1-78-207-202-9.fbx.proxad.net with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Fri, 20 Feb 2015 16:47:20 +0100 X-Injected-Via-Gmane: http://gmane.org/ Mail-Followup-To: bug-gnu-emacs@gnu.org Original-Lines: 35 Original-X-Complaints-To: usenet@ger.gmane.org X-Gmane-NNTP-Posting-Host: vav06-1-78-207-202-9.fbx.proxad.net Mail-Copies-To: never User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (cygwin) Cancel-Lock: sha1:PfoV7m2SQEXEMR0jRyDTcRvqCTI= X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:99646 Archived-At: Eli Zaretskii writes: >> From: Robert Pluim >> Date: Fri, 20 Feb 2015 15:16:49 +0100 >> >> > According to the comment in w32notify.c, w32.h is included only for >> > w32_strerror. Could you try commenting out the w32.h inclusion, and >> > instead copy the w32_strerror prototype into w32notify.c? Does Emacs >> > compile then as part of the Cygwin-w32 build, and do file >> > notifications work? (I don't have Cygwin installed to try that, >> > sorry.) >> > >> >> No, that doesn't compile. w32notify.c needs (at least) >> w32_unicode_filenames, filename_to_utf16(), filename_to_ansi() and >> w32_valid_pointer_p() from w32.c. > > Right. But those problems are quite simple to solve. > > Ken, would you like to try to solve them? I could suggest a patch, > but it would be 100% untested. > >> I don't think adding w32.c into the build on cygwin is going to work. > > Because of the above, or because of something else? Because (perhaps mistakenly) I think that calling emacs code that assumes it's running under Windows native will not interact well with emacs code that's running under cygwin. Having said that, I'm willing to test any patches over the next week or so (after that I'm going to be without a cygwin environment for a couple of weeks). Robert