all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Robert Pluim <rpluim@gmail.com>
To: 19909@debbugs.gnu.org
Subject: bug#19909: [PATCH] Error out if	with-file-notification=w32	is	specified on cygwin
Date: Fri, 20 Feb 2015 16:46:48 +0100	[thread overview]
Message-ID: <82oaoofuvr.fsf@gmail.com> (raw)
In-Reply-To: <821tlkhq2v.fsf@gmail.com>

Eli Zaretskii <eliz@gnu.org> writes:

>> From: Robert Pluim <rpluim@gmail.com>
>> Date: Fri, 20 Feb 2015 15:16:49 +0100
>> 
>> > According to the comment in w32notify.c, w32.h is included only for
>> > w32_strerror.  Could you try commenting out the w32.h inclusion, and
>> > instead copy the w32_strerror prototype into w32notify.c?  Does Emacs
>> > compile then as part of the Cygwin-w32 build, and do file
>> > notifications work?  (I don't have Cygwin installed to try that,
>> > sorry.)
>> >
>> 
>> No, that doesn't compile. w32notify.c needs (at least)
>> w32_unicode_filenames, filename_to_utf16(), filename_to_ansi() and
>> w32_valid_pointer_p() from w32.c.
>
> Right.  But those problems are quite simple to solve.
>
> Ken, would you like to try to solve them?  I could suggest a patch,
> but it would be 100% untested.
>
>> I don't think adding w32.c into the build on cygwin is going to work.
>
> Because of the above, or because of something else?

Because (perhaps mistakenly) I think that calling emacs code that
assumes it's running under Windows native will not interact well with
emacs code that's running under cygwin.

Having said that, I'm willing to test any patches over the next week or
so (after that I'm going to be without a cygwin environment for a couple
of weeks).

Robert






  reply	other threads:[~2015-02-20 15:46 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-02-20  9:47 bug#19909: [PATCH] Error out if with-file-notification=w32 is specified on cygwin Robert Pluim
2015-02-20 10:06 ` Eli Zaretskii
2015-02-20 10:19   ` Robert Pluim
2015-02-20 10:46     ` Eli Zaretskii
2015-02-20 14:16       ` Robert Pluim
2015-02-20 15:10         ` Eli Zaretskii
2015-02-20 15:46           ` Robert Pluim [this message]
2015-02-20 16:17             ` Eli Zaretskii
2015-02-20 16:44               ` Robert Pluim
2015-02-20 17:16                 ` Eli Zaretskii
2015-02-20 16:15           ` Ken Brown
2015-02-20 17:06             ` Robert Pluim
2015-02-20 17:18             ` Eli Zaretskii
2015-02-27 22:25               ` Ken Brown
2015-02-28  7:59                 ` Eli Zaretskii
2015-02-28 16:32                   ` Ken Brown
2015-02-28 16:41                     ` Eli Zaretskii
2015-02-28 16:53                       ` Robert Pluim
2015-02-28 16:56                       ` Robert Pluim
2015-02-28 17:57                         ` Eli Zaretskii
2015-02-28 18:44                           ` Ken Brown
2015-02-28 19:14                             ` Eli Zaretskii
2015-02-28 20:14                               ` Ken Brown
2015-03-02  9:35                                 ` Robert Pluim
2015-03-02 14:05                                   ` Ken Brown
2015-03-02 14:06 ` bug#19909: closed (Re: bug#19909: [PATCH] Error out if with-file-notification=w32 is specified on cygwin) GNU bug Tracking System

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=82oaoofuvr.fsf@gmail.com \
    --to=rpluim@gmail.com \
    --cc=19909@debbugs.gnu.org \
    --cc=bug-gnu-emacs@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.