From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Robert Pluim Newsgroups: gmane.emacs.bugs Subject: bug#19909: [PATCH] Error out if with-file-notification=w32 is specified on cygwin Date: Fri, 20 Feb 2015 18:06:21 +0100 Message-ID: <82lhjsecmq.fsf@gmail.com> References: <821tlkhq2v.fsf@gmail.com> <83mw48lwvx.fsf@gnu.org> <82wq3cga1n.fsf@gmail.com> <83ioewlv1v.fsf@gnu.org> <82sie0fz1q.fsf@gmail.com> <838ufslitm.fsf@gnu.org> <54E75D96.70601@cornell.edu> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Trace: ger.gmane.org 1424452058 11269 80.91.229.3 (20 Feb 2015 17:07:38 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 20 Feb 2015 17:07:38 +0000 (UTC) Cc: 19909@debbugs.gnu.org To: Ken Brown Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Feb 20 18:07:27 2015 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1YOr2y-0002Eg-OC for geb-bug-gnu-emacs@m.gmane.org; Fri, 20 Feb 2015 18:07:25 +0100 Original-Received: from localhost ([::1]:33310 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YOr2x-0000Ph-Qq for geb-bug-gnu-emacs@m.gmane.org; Fri, 20 Feb 2015 12:07:23 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:35690) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YOr2p-0000GA-8E for bug-gnu-emacs@gnu.org; Fri, 20 Feb 2015 12:07:19 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YOr2c-0007dm-QX for bug-gnu-emacs@gnu.org; Fri, 20 Feb 2015 12:07:11 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:58417) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YOr2c-0007dX-IP for bug-gnu-emacs@gnu.org; Fri, 20 Feb 2015 12:07:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1YOr2c-0008F9-6C for bug-gnu-emacs@gnu.org; Fri, 20 Feb 2015 12:07:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Robert Pluim Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 20 Feb 2015 17:07:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 19909 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 19909-submit@debbugs.gnu.org id=B19909.142445199831657 (code B ref 19909); Fri, 20 Feb 2015 17:07:02 +0000 Original-Received: (at 19909) by debbugs.gnu.org; 20 Feb 2015 17:06:38 +0000 Original-Received: from localhost ([127.0.0.1]:49657 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YOr2D-0008EX-00 for submit@debbugs.gnu.org; Fri, 20 Feb 2015 12:06:37 -0500 Original-Received: from mail-wi0-f169.google.com ([209.85.212.169]:46456) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YOr2A-0008EO-4q for 19909@debbugs.gnu.org; Fri, 20 Feb 2015 12:06:34 -0500 Original-Received: by mail-wi0-f169.google.com with SMTP id em10so7735104wid.0 for <19909@debbugs.gnu.org>; Fri, 20 Feb 2015 09:06:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:references:gmane-reply-to-list:date:in-reply-to :message-id:user-agent:mime-version:content-type :content-transfer-encoding; bh=Kjb21/kNdxfqMbL8536d2RRHm3wxyD6FJj1iV3zpMSQ=; b=BhcMHrIcoYTkwcAOMmEmf7T0EwBn4slrP+41F//WsRG9KvqvyvJKUllMp3q2YwrtBN qU9tx6HeCJ/Jmm1KT7CGg6wpYuDPRIRrcsCB/4X0viGhn2cGaZWtyHNi3dvbB5xHUOAy eq5i5pKu3mqRKVSh5lKkWDVKlwI5rgfvZWr8AohbtIMPzzvaeq1ElEuT01AG0ACvr+O+ XJMYTtrWC458FlDKXSEzIpFB7DzFWk/LIbH8ftge+Qt1esrDFF+9aqFtnzYxHcGvpvZ5 Q6lGM17+QzOUGZHIEuWDNK4osmgQ3M+lvVqUYPqKI2PsFxbj5uHJ3WYQDBseOsqiQasr 67uQ== X-Received: by 10.180.108.239 with SMTP id hn15mr21596096wib.38.1424451993567; Fri, 20 Feb 2015 09:06:33 -0800 (PST) Original-Received: from RPLUIM (vav06-1-78-207-202-9.fbx.proxad.net. [78.207.202.9]) by mx.google.com with ESMTPSA id dm6sm3168386wib.22.2015.02.20.09.06.32 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 20 Feb 2015 09:06:33 -0800 (PST) Gmane-Reply-To-List: yes In-Reply-To: <54E75D96.70601@cornell.edu> (Ken Brown's message of "Fri, 20 Feb 2015 11:15:18 -0500") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (cygwin) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:99651 Archived-At: Ken Brown writes: > On 2/20/2015 10:10 AM, Eli Zaretskii wrote: >>> From: Robert Pluim >>> Date: Fri, 20 Feb 2015 15:16:49 +0100 >>> >>>> According to the comment in w32notify.c, w32.h is included only for >>>> w32_strerror. Could you try commenting out the w32.h inclusion, and >>>> instead copy the w32_strerror prototype into w32notify.c? Does Emacs >>>> compile then as part of the Cygwin-w32 build, and do file >>>> notifications work? (I don't have Cygwin installed to try that, >>>> sorry.) >>>> >>> >>> No, that doesn't compile. w32notify.c needs (at least) >>> w32_unicode_filenames, filename_to_utf16(), filename_to_ansi() and >>> w32_valid_pointer_p() from w32.c. >> >> Right. But those problems are quite simple to solve. >> >> Ken, would you like to try to solve them? I could suggest a patch, >> but it would be 100% untested. > > I'm busy with other things at the moment and can't get to it right > away. If it's easy for you to suggest a patch, why don't you go ahead, > and Robert can test it. Or you can wait a couple weeks until I can > look at it. > > BTW, file-notification=3Dgfile works fine in the Cygwin-w32 build, so > I'm not sure there's any need to put a lot of effort into this. I didn't know that. I'll give it a go. Perhaps the following slight modification to my original patch? diff --git a/ChangeLog b/ChangeLog index 4365668..dec9ce0 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,8 @@ +2015-02-20 rpluim + + * configure.ac: Error out if with-file-notification=3Dw32 is + specified on cygwin. + 2015-02-13 Jan Dj=C3=A4rv =20 * configure.ac: Set locallisppath to empty for NS self contained, diff --git a/configure.ac b/configure.ac index 0bcc55c..19d9c20 100644 --- a/configure.ac +++ b/configure.ac @@ -2659,6 +2659,11 @@ fi =20 dnl MS Windows native file monitor is available for mingw32 only. case $with_file_notification,$opsys in + w32,cygwin) + AC_MSG_ERROR([`--with-file-notification=3Dw32' was specified, but + this is only supported on MS-Windows native and MinGW32 builds. + Consider using gfile instead.]) + ;; w32,* | yes,mingw32) AC_CHECK_HEADER(windows.h) if test "$ac_cv_header_windows_h" =3D yes ; then