From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: David Reitter Newsgroups: gmane.emacs.devel Subject: Re: Get rid of per-frame settings of faces via Xresources Date: Mon, 4 May 2009 20:21:03 -0400 Message-ID: <82DC2034-022F-492B-B0D9-D4D67724B1B2@gmail.com> References: NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 (Apple Message framework v930.3) Content-Type: text/plain; charset=US-ASCII; format=flowed; delsp=yes Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1241482914 5026 80.91.229.12 (5 May 2009 00:21:54 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 5 May 2009 00:21:54 +0000 (UTC) Cc: emacs-devel@gnu.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue May 05 02:21:47 2009 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1M18Pr-0004Wc-Fh for ged-emacs-devel@m.gmane.org; Tue, 05 May 2009 02:21:47 +0200 Original-Received: from localhost ([127.0.0.1]:42079 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1M18Pq-0008MW-Qb for ged-emacs-devel@m.gmane.org; Mon, 04 May 2009 20:21:46 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1M18PU-0008CW-TT for emacs-devel@gnu.org; Mon, 04 May 2009 20:21:24 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1M18PT-0008BX-Qk for emacs-devel@gnu.org; Mon, 04 May 2009 20:21:24 -0400 Original-Received: from [199.232.76.173] (port=50383 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1M18PT-0008BF-JN for emacs-devel@gnu.org; Mon, 04 May 2009 20:21:23 -0400 Original-Received: from qw-out-1920.google.com ([74.125.92.149]:52678) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1M18PT-0004BQ-6P for emacs-devel@gnu.org; Mon, 04 May 2009 20:21:23 -0400 Original-Received: by qw-out-1920.google.com with SMTP id 4so3147864qwk.24 for ; Mon, 04 May 2009 17:21:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:cc:message-id:from:to :in-reply-to:content-type:content-transfer-encoding:mime-version :subject:date:references:x-mailer; bh=NgfwLDhmaCguO6mA/AyH0cC85pRdvidw/DOdS2NgWgQ=; b=rgGWWAAyw7ae4p4OOSLuAmMGjja09xYRyqGnIoTxx71RzgCZwBljHNAiijzmMiK3la Iw4jXcmvwbyflfmMUcih3ElT1Q4/on1ibNYuUwZwlOgh2DUN4k1pT5pnm8Bk0a0Ys/kE hzQ7rPyHHUYZRiwQTCnfcrd50khyR8VEewjzs= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=cc:message-id:from:to:in-reply-to:content-type :content-transfer-encoding:mime-version:subject:date:references :x-mailer; b=VT2aOHWIEIV/FCCVcSl9IfyQIJJwkVkQEPc8TadgifaRRv3eJbivRlNsKlw+EHZ+dN SWQrswlPPaIFN48sTm+MjWLos2wlB5bUi8NIBmDQ0hdQntq7Eac4jwHuwJl0dqUUR97R w9WsO84uKK9wQo9COaeSmxgM6dtrglnGyJcCI= Original-Received: by 10.220.84.78 with SMTP id i14mr10681460vcl.25.1241482882373; Mon, 04 May 2009 17:21:22 -0700 (PDT) Original-Received: from scarlett.local (pool-71-162-19-47.pitbpa.east.verizon.net [71.162.19.47]) by mx.google.com with ESMTPS id 5sm1025635ywl.32.2009.05.04.17.21.20 (version=TLSv1/SSLv3 cipher=RC4-MD5); Mon, 04 May 2009 17:21:21 -0700 (PDT) In-Reply-To: X-Mailer: Apple Mail (2.930.3) X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 2) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:110659 Archived-At: Well, the subject line was informative enough. If I interpret you correctly: We've had (some of) that removed in Aquamacs (back then based on pre Emacs 22.1 code) simply because frame creation was slowed down tremendously (seconds!) when many faces were known to Emacs (as is the case when you use color themes and you try out a bunch of them during the session). I decided not to support X resources on the Mac (under Carbon) - I don't think anybody missed it. ] I'm not sure about X of course. *** lisp/faces.el 13 Apr 2007 18:24:53 +0100 1.370 --- lisp/faces.el 13 Jul 2007 18:56:06 +0100 *************** *** 320,326 **** (defun set-face-attributes-from-resources (face frame) "Set attributes of FACE from X resources for FRAME." ! (when (memq (framep frame) '(x w32 mac)) (dolist (definition face-x-resources) (let ((attribute (car definition))) (dolist (entry (cdr definition)) --- 320,326 ---- (defun set-face-attributes-from-resources (face frame) "Set attributes of FACE from X resources for FRAME." ! (when (eq (framep frame) 'x) (dolist (definition face-x-resources) (let ((attribute (car definition))) (dolist (entry (cdr definition)) *************** *** 1789,1796 **** (condition-case () (progn (face-spec-set face (face-user-default-spec face) frame) ! (if (memq window-system '(x w32 mac)) ! (make-face-x-resource-internal face frame)) (internal-merge-in-global-face face frame)) (error nil))) ;; Apply the attributes specified by frame parameters. This --- 1789,1796 ---- (condition-case () (progn (face-spec-set face (face-user-default-spec face) frame) ! (if (eq window-system 'x) ! (make-face-x-resource-internal face frame)) (internal-merge-in-global-face face frame)) (error nil))) ;; Apply the attributes specified by frame parameters. This