From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Yuan Fu Newsgroups: gmane.emacs.bugs Subject: bug#70438: Emacs error 6 abort when starting rust-ts-mode Date: Fri, 26 Apr 2024 10:58:20 -0700 Message-ID: <82B0E79F-050A-43B0-BB68-BBD58F37E08E@gmail.com> References: <868r1cgdk9.fsf@gnu.org> <0439FD61-C3EE-4438-B775-043FE098F41E@gmail.com> <86zfto8jfs.fsf@gnu.org> <86jzkr8gpr.fsf@gnu.org> <6944FFA3-5CEB-4FFA-9A4C-1EFFF8EDC62D@gmail.com> <86cyqi6iyh.fsf@gnu.org> <3FCA9A10-73AD-4B56-B3E7-AB3DF04FD2BF@gmail.com> <86plud1sxk.fsf@gnu.org> <86plucxcot.fsf@gnu.org> Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3731.700.6.1.1\)) Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="22516"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 70438@debbugs.gnu.org, sh@bytekomplex.de To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Apr 26 19:58:59 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1s0Pqd-0005a8-Fn for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 26 Apr 2024 19:58:59 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1s0PqT-0003RV-21; Fri, 26 Apr 2024 13:58:49 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1s0PqR-0003RF-6a for bug-gnu-emacs@gnu.org; Fri, 26 Apr 2024 13:58:47 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1s0PqQ-00039T-PT for bug-gnu-emacs@gnu.org; Fri, 26 Apr 2024 13:58:46 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1s0Pqi-0006JS-GE for bug-gnu-emacs@gnu.org; Fri, 26 Apr 2024 13:59:04 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Yuan Fu Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 26 Apr 2024 17:59:04 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 70438 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: wontfix Original-Received: via spool by 70438-submit@debbugs.gnu.org id=B70438.171415434224246 (code B ref 70438); Fri, 26 Apr 2024 17:59:04 +0000 Original-Received: (at 70438) by debbugs.gnu.org; 26 Apr 2024 17:59:02 +0000 Original-Received: from localhost ([127.0.0.1]:38401 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1s0Pqe-0006IR-8I for submit@debbugs.gnu.org; Fri, 26 Apr 2024 13:59:01 -0400 Original-Received: from mail-pf1-x435.google.com ([2607:f8b0:4864:20::435]:59564) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1s0Pqb-0006Gl-W5 for 70438@debbugs.gnu.org; Fri, 26 Apr 2024 13:58:59 -0400 Original-Received: by mail-pf1-x435.google.com with SMTP id d2e1a72fcca58-6ecee1f325bso2310757b3a.2 for <70438@debbugs.gnu.org>; Fri, 26 Apr 2024 10:58:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1714154313; x=1714759113; darn=debbugs.gnu.org; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=7qcU99ZEeP8kavO5K6LjclgOVrNFPlFF8Ub2jkDAgEc=; b=Ag0bqHlbQcJfrrW6yX3LTN/ofeb+cFI6xDlpP8vcxaTEOvvQZtJtFIhSJQhTRaQ3Xl whFXjzVM3Q2HmBUDZmcwrynWEIwZ9f/lCrqK230ZcTP9orumJIF7QZQAQQ72BsI7E6GA mHNGMddoDsdCCWIabO9Xly14Y7azQUi0pI2XTW5x1vJHh0n2VM4lu2I+xtE+VYKRe6fT zvliqLTYx5dLwUt5V+PWq13Qi+SanosIELwe3Zz/mCzA3Jx7ntA76XGKnpXhHbN5DrmS 1S97ketrKS2ugB0IrTokm7GLnXvVi0yYoMMdcPcnscR+cGTKBBkrEg9SDfdX8lAPOhJI MVbg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1714154313; x=1714759113; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=7qcU99ZEeP8kavO5K6LjclgOVrNFPlFF8Ub2jkDAgEc=; b=Z40f364qiSY5oankINnYGD+ouhDywqaWVFXlJAj75V+pGIll1MKGHIXfgEp9oG/U3A MiCc5rJjVzCcPaum2t4/YlRBN57Yw8BwXeMBTmKBPNs89HaYFiOCx5I7pc9dO0/yp2DW mXbykL2FHNcob4of8DDAVAkpGNQk42FAz4IoOdQsRuR0e75rawisnwAQmjK2/tu0zdD5 KvBg8ASjy2Cv51RaM1h/2Z2pClyBjYVtyY1HLK5jpkUIW8GsugEJTJvlLWBdIEcfKiLs FxQOddU059fji5Q/BYgmTirwuF+LVRBpLyMC9ZERlBkEKoBBi5eITn9oJfTwC7stIdaa uf7g== X-Forwarded-Encrypted: i=1; AJvYcCUfNtnhoVNmlZCmLuHGka7wKqtTSREu0C5Wqie90DJtfpR7rCf8jPTcSvlgtoWPymtcKsQJ751jUHs8A891DAhDPCYx4PY= X-Gm-Message-State: AOJu0YxAVz0mvLQK3mzUFoMLQWs7n09RfkMPuDiBDC/nKSj89B6QrC+1 uGYa4aT3u4JKOWFVaadETyUcA16ClkN/ON/joaHFn9AKZ8KTxM4p X-Google-Smtp-Source: AGHT+IGHi9r1V+j/zweW2zCpk4ujOxBy1sxVVU1zdpswiEZdTFWlqNlGogT9RabFZguJ5PP/Uq6/yg== X-Received: by 2002:a05:6a00:3c8c:b0:6ec:f712:8a69 with SMTP id lm12-20020a056a003c8c00b006ecf7128a69mr4824160pfb.29.1714154313588; Fri, 26 Apr 2024 10:58:33 -0700 (PDT) Original-Received: from smtpclient.apple ([2601:641:300:4910:ac82:be4f:9f14:c0c9]) by smtp.gmail.com with ESMTPSA id h3-20020a056a00218300b006ed4aa9d48esm15047623pfi.212.2024.04.26.10.58.32 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Fri, 26 Apr 2024 10:58:32 -0700 (PDT) In-Reply-To: <86plucxcot.fsf@gnu.org> X-Mailer: Apple Mail (2.3731.700.6.1.1) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:284005 Archived-At: > On Apr 26, 2024, at 10:21 AM, Eli Zaretskii wrote: >=20 >> From: Yuan Fu >> Date: Fri, 26 Apr 2024 09:49:01 -0700 >> Cc: Stefan Heitmann , >> 70438@debbugs.gnu.org >>=20 >> In the GitHub issue that tracks this incident, the author made clear = that maintaining ABI versioning correctly is beyond their ability right = now. So I think we should pin the tree-sitter version. But then IIUC we = can only bump tree-sitter version with each Emacs release? This is a bit = unfortunate but better than crashing Emacs. >=20 > We cannot pin a tree-sitter version, because that makes sense only for > binary distributions. We ship only source tarballs, and for those, > _any_ tree-sitter version will do -- provided that Emacs is built with > the same version of tree-sitter with which it will be used, or with > the version that uses the same ABI. >=20 > We could perhaps record the version with which Emacs was built, and > then reject incompatible versions we find at run time, but since > tree-sitter doesn't provide any version-related symbols in their > header files, we cannot do even that. >=20 > So the bottom line is still the same: we cannot do anything here, as > long as the tree-sitter developers think they can break the ABI at > will. Can we statically link tree-sitter? =46rom the look of it, tree-sitter = devs don=E2=80=99t plan to not break ABI. We need to do something to = prevent Emacs from crashing. >> This also brings me to the versioning of tree-sitter grammars=E2=80=94t= hey really do change often, we should really consider pinning their = version in some way. The current catch-up game we play can=E2=80=99t be = scalable. >=20 > That's a separate issue: when there's incompatibility with grammar > libraries, Emacs doesn't crash. I can open a separate thread for this. Yuan=