From: Nikolay Kudryavtsev <nikolay.kudryavtsev@gmail.com>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: help-gnu-emacs@gnu.org, "Kévin Le Gouguec" <kevin.legouguec@gmail.com>
Subject: Re: Debugging SMIE for sh-script.el
Date: Mon, 6 Sep 2021 20:24:37 +0300 [thread overview]
Message-ID: <829bc30d-41a7-c630-a568-00e7f18f1407@gmail.com> (raw)
In-Reply-To: <jwva6kp959g.fsf-monnier+emacs@gnu.org>
Oh, you're right. Seems that I haven't read Kevin's last letter
carefully enough. Sorry about that.
I also don't understand the discussion of treating $(cat food) as a
single token, since blocks with the standard openers/closers are
supposed to be returned by the smie lexer as "" when it runs into them
from the outside.
Anyway, I still think that even in this case, changing
sh-smie--indent-continuation is a better idea than touching the token
grab code. Just to test I've coded an implementation of it
<https://gist.github.com/sg2002/43bbd454da3254f4d092e2758057c372>, that
behaves correctly for Kevin's use case. Needs more testing, but seems to
work ok in general.
next prev parent reply other threads:[~2021-09-06 17:24 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-02 10:49 Debugging SMIE for sh-script.el Kévin Le Gouguec
2021-09-02 12:07 ` Nikolay Kudryavtsev
2021-09-02 17:19 ` Kévin Le Gouguec
2021-09-02 18:09 ` Nikolay Kudryavtsev
2021-09-02 20:29 ` Kévin Le Gouguec
2021-09-02 19:50 ` Stefan Monnier via Users list for the GNU Emacs text editor
2021-09-02 21:37 ` Kévin Le Gouguec
2021-09-02 23:54 ` Stefan Monnier via Users list for the GNU Emacs text editor
2021-09-03 7:09 ` Kévin Le Gouguec
2021-09-03 12:12 ` Stefan Monnier
2021-09-05 15:48 ` Nikolay Kudryavtsev
2021-09-05 16:27 ` Stefan Monnier via Users list for the GNU Emacs text editor
2021-09-05 16:41 ` Nikolay Kudryavtsev
2021-09-05 17:23 ` Stefan Monnier via Users list for the GNU Emacs text editor
2021-09-05 18:01 ` Nikolay Kudryavtsev
2021-09-05 23:02 ` Stefan Monnier
2021-09-06 12:47 ` Nikolay Kudryavtsev
2021-09-06 14:01 ` Stefan Monnier
2021-09-06 17:24 ` Nikolay Kudryavtsev [this message]
2021-09-06 20:23 ` Stefan Monnier
2021-09-12 17:40 ` Kévin Le Gouguec
2021-09-02 19:47 ` Stefan Monnier via Users list for the GNU Emacs text editor
2021-09-02 20:39 ` Kévin Le Gouguec
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=829bc30d-41a7-c630-a568-00e7f18f1407@gmail.com \
--to=nikolay.kudryavtsev@gmail.com \
--cc=help-gnu-emacs@gnu.org \
--cc=kevin.legouguec@gmail.com \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.