From: Gregory Heytings <gregory@heytings.org>
To: Manuel Uberti <manuel.uberti@inventati.org>
Cc: 51386@debbugs.gnu.org
Subject: bug#51386: 29.0.50; fido-vertical-mode: ssh host completion
Date: Mon, 25 Oct 2021 16:13:20 +0000 [thread overview]
Message-ID: <822aec9d01dd14907c52@heytings.org> (raw)
In-Reply-To: <87916c87-fcea-d8a4-5f1d-9066e845add1@inventati.org>
[-- Attachment #1: Type: text/plain, Size: 669 bytes --]
>
> It doesn't seem to work, though. From emacs -Q:
>
Tramp doesn't behave as expected with only flex in completion-styles,
indeed. I see the same problem in Emacs 27. Your bug report was similar
to bug#50387, it is in fact related but subtly different.
>
> The hostname isn't completed and I don't see the *Completions* buffer.
> While without enabling fido-vertical-mode, I get /ssh:server on pressing
> TAB after /ssh:s
>
I'd suggest to add something a fallback method in
icomplete--fido-mode-setup, for example completion-styles '(flex basic).
And perhaps to apply the attached patch in your local Emacs, which
provides I think the behavior you expect.
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: Type: text/x-diff; name=Improve-handling-of-non-default-completion-styles-wi.patch, Size: 1089 bytes --]
From 5f4b821bbf5123422d43895bee4c847cfadf31b0 Mon Sep 17 00:00:00 2001
From: Gregory Heytings <gregory@heytings.org>
Date: Mon, 6 Sep 2021 20:52:21 +0000
Subject: [PATCH] Improve handling of non-default completion styles with Tramp
methods
* lisp/net/tramp.el (tramp-completion-handle-file-name-all-completions):
Do not return methods when the filename already contains a complete method.
Fixes bug#50387.
---
lisp/net/tramp.el | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/lisp/net/tramp.el b/lisp/net/tramp.el
index 4fd7a322d4..259fc1fcfc 100644
--- a/lisp/net/tramp.el
+++ b/lisp/net/tramp.el
@@ -2839,8 +2839,9 @@ tramp-completion-handle-file-name-all-completions
(delq nil all-user-hosts)))))
;; Possible methods.
- (setq result
- (append result (tramp-get-completion-methods m)))))))
+ (unless (string-empty-p method)
+ (setq result
+ (append result (tramp-get-completion-methods m))))))))
;; Unify list, add hop, remove nil elements.
(dolist (elt result)
--
2.33.0
next prev parent reply other threads:[~2021-10-25 16:13 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-25 14:37 bug#51386: 29.0.50; fido-vertical-mode: ssh host completion Manuel Uberti via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-10-25 14:54 ` Gregory Heytings
2021-10-25 15:08 ` Manuel Uberti via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-10-25 16:13 ` Gregory Heytings [this message]
2021-10-26 4:47 ` Manuel Uberti via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-10-26 7:13 ` Gregory Heytings
2021-10-26 15:30 ` Manuel Uberti via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-10-26 16:00 ` Manuel Uberti via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-10-26 18:12 ` Michael Albinus
2021-10-26 18:24 ` Gregory Heytings
2021-10-26 18:53 ` Michael Albinus
2021-10-26 19:06 ` Gregory Heytings
2021-10-27 5:50 ` Manuel Uberti via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-10-27 7:51 ` Gregory Heytings
2021-10-27 7:55 ` Manuel Uberti via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-10-27 8:05 ` Gregory Heytings
2021-10-27 8:07 ` Manuel Uberti via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-10-27 9:05 ` Michael Albinus
2021-10-27 9:08 ` Manuel Uberti via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-10-27 9:12 ` Gregory Heytings
2021-10-27 11:10 ` Michael Albinus
2021-10-27 11:19 ` Dmitry Gutov
2021-10-27 11:22 ` Manuel Uberti via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-10-27 11:39 ` Gregory Heytings
2021-10-27 11:55 ` Michael Albinus
2021-10-27 11:23 ` Gregory Heytings
2021-10-27 11:42 ` Michael Albinus
2021-10-27 12:04 ` Gregory Heytings
2021-10-27 12:12 ` Michael Albinus
2021-10-27 10:15 ` Dmitry Gutov
2021-10-27 10:23 ` Gregory Heytings
2021-10-27 10:25 ` Dmitry Gutov
2021-10-27 11:35 ` Michael Albinus
2021-10-27 12:02 ` Gregory Heytings
2021-10-31 18:13 ` Manuel Uberti via Bug reports for GNU Emacs, the Swiss army knife of text editors
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=822aec9d01dd14907c52@heytings.org \
--to=gregory@heytings.org \
--cc=51386@debbugs.gnu.org \
--cc=manuel.uberti@inventati.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.