From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Jim Porter Newsgroups: gmane.emacs.bugs Subject: bug#55696: 28.1; eshell fails to respect text-scale-increase Date: Fri, 10 Jun 2022 09:44:41 -0700 Message-ID: <820ec35d-6f93-e0ad-1b07-f07339da8360@gmail.com> References: <37af046b-4257-6370-c765-9290eae73fd4@gmail.com> <831qw6dzra.fsf@gnu.org> <0278e759-237b-a32b-4b1f-fbdacf39c8ef@gmail.com> <83pmjpar0x.fsf@gnu.org> <9e8a8b42-2f42-3027-2ec0-97744bb91911@gmail.com> <83sfoja2xp.fsf@gnu.org> <34062848-8fe4-351c-df63-5cc341fefa57@gmail.com> <83sfoj7x6f.fsf@gnu.org> <83ee027yjc.fsf@gnu.org> <2b86123e-76c1-ec0c-c767-7d821473e5e1@gmx.at> <86a0c66e-86f9-6bd6-2010-eb1cf2d9f1e6@gmail.com> <83a6am47v6.fsf@gnu.org> <4abda9a0-7c34-cdad-fc9e-a6dc25e7c74b@gmail.com> <837d5p3hr7.fsf@gnu.org> <8e4fc184-8ca1-8094-f37d-f77d0cbb337c@gmail.com> <83edzx12vm.fsf@gnu.org> <6c0578d4-4060-3c81-584e-53eb9912d40e@gmail.com> <83leu4zf1u.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="27493"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 55696@debbugs.gnu.org, jeff.kowalski@gmail.com To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Jun 10 18:46:46 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nzhmX-00072M-Uo for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 10 Jun 2022 18:46:45 +0200 Original-Received: from localhost ([::1]:42044 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nzhmX-0002WS-2T for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 10 Jun 2022 12:46:45 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:43862) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nzhkt-0000nV-DW for bug-gnu-emacs@gnu.org; Fri, 10 Jun 2022 12:45:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:57233) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nzhkt-0004Jf-54 for bug-gnu-emacs@gnu.org; Fri, 10 Jun 2022 12:45:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nzhkt-0003yi-3H for bug-gnu-emacs@gnu.org; Fri, 10 Jun 2022 12:45:03 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Jim Porter Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 10 Jun 2022 16:45:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 55696 X-GNU-PR-Package: emacs Original-Received: via spool by 55696-submit@debbugs.gnu.org id=B55696.165487948915224 (code B ref 55696); Fri, 10 Jun 2022 16:45:03 +0000 Original-Received: (at 55696) by debbugs.gnu.org; 10 Jun 2022 16:44:49 +0000 Original-Received: from localhost ([127.0.0.1]:51124 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nzhkf-0003xT-63 for submit@debbugs.gnu.org; Fri, 10 Jun 2022 12:44:49 -0400 Original-Received: from mail-pg1-f179.google.com ([209.85.215.179]:41669) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nzhkc-0003xB-K5 for 55696@debbugs.gnu.org; Fri, 10 Jun 2022 12:44:47 -0400 Original-Received: by mail-pg1-f179.google.com with SMTP id e66so25263767pgc.8 for <55696@debbugs.gnu.org>; Fri, 10 Jun 2022 09:44:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=subject:to:cc:references:from:message-id:date:mime-version :in-reply-to:content-language:content-transfer-encoding; bh=3CP9y/oSK13a402iCtij+VipgSQzsRHeyyXwfaT0DOM=; b=mVcJOqHNyocnLAQ6JVwLXfZ8wKDFgr80DmENSyYartvMobs5pwV7iembliDf2s8jBg /UdUlY5oErSNhtN1WztqPbSDCmfx7bDGUdRfZtOM0XQCmaOE8DajZTPzxHvVmdUfrW3K 1TvuTfyYE7Um94lnUr6CWGrBIjgRsiWi1+wkDfhE78ls4xjve7V0NMGhRUCQ/jIcFGAs U8h6/kH1jV/fTjoAZESWCe3CDTIn2rHExCw8yFPY9+IpgoSH2UVe/07nWx1qKDpclVzE TljqRj43FNYtCkRqbUMoFefweLo7RaVmPrvQJWbNRVQV+hdEsD9rBeGtOOeFzmQdSzav hmIg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=3CP9y/oSK13a402iCtij+VipgSQzsRHeyyXwfaT0DOM=; b=INS9ep3MRuvs2bQMhJIMz9tceF4H3Hu+5sVj3BwYKyzj1K4voBPtNnHq5YlBlbgHTT Zk0G8Ov1TFV5hqGtp3kXo/SX3ZCZBBenzVsWO0WR7FtuVIoUsP1xCL5ahFLunfqmCvJR +VJzcn7krpLaI6HH7vIWpa6ZE5BLmRkyqhhgNRN7EnvMW/DT5jGw6Uzp2j+J8kNZvw9H zdmk1pl0qHjdI/3TLiUd9iX1R0hSvAXvBshSNelafgYzEfXsIjz+PTf2zjVVYH1HQNXI wRTbyQ9O0LZjekl1ZHtWCRCBGLGe8fmVXWF2TJLOksFDiB4orUniq0zxLucfaynkOLGz B5ig== X-Gm-Message-State: AOAM531F6A667e9hQV8nmqnRTgU8nM8DNN29H+8Tfkl6cQCFpp1i+lWv +i933CcypLCwz/qZUnOwhIg= X-Google-Smtp-Source: ABdhPJy/JQ8X3PU6d0QEpgyptA3EhxckmlJBzOZ4VJB2vQBHdeGYPjFOe2QoeMZApsrJp8oNxOok0A== X-Received: by 2002:a05:6a00:124d:b0:51b:f2ac:ef8a with SMTP id u13-20020a056a00124d00b0051bf2acef8amr35462568pfi.72.1654879480604; Fri, 10 Jun 2022 09:44:40 -0700 (PDT) Original-Received: from [192.168.1.2] (cpe-76-168-148-233.socal.res.rr.com. [76.168.148.233]) by smtp.googlemail.com with ESMTPSA id g5-20020a655805000000b003fbfa234818sm19906453pgr.54.2022.06.10.09.44.39 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 10 Jun 2022 09:44:40 -0700 (PDT) In-Reply-To: <83leu4zf1u.fsf@gnu.org> Content-Language: en-US X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:234235 Archived-At: On 6/10/2022 8:58 AM, Eli Zaretskii wrote: >> Cc: 55696@debbugs.gnu.org, jeff.kowalski@gmail.com >> From: Jim Porter >> Date: Fri, 10 Jun 2022 08:44:22 -0700 >> >> On 6/9/2022 10:52 PM, Eli Zaretskii wrote: >>> What if there's an external command named 'listify' -- is there any >>> chance that the test will invoke it? If so, I think we should come up >>> with a safer solution. >> >> No, that shouldn't be a problem. When Eshell executes something that >> looks like a shell command[1], the order of precedence is this: >> >> 1. If an alias for the command exists in .emacs.d/eshell/aliases, use >> that. (This won't happen in tests, since `eshell-test-command-result' >> binds `eshell-directory-name' to a temp dir.) >> >> 2. If there's a Lisp function named `eshell/COMMAND', use that. >> >> 3. If there's an external command named `COMMAND', use that. >> >> 4. If there's a Lisp function named `COMMAND', use that. > > So the problem with using 'list' was that there was no Lisp function > eshell/list, is that right? Correct. I think `listify' (aka `eshell/listify') is the preferred Eshell way of expressing that for the command-style syntax. Maybe an `eshell/list' function would be good to have, but I'm not sure this problem would come up outside of the unit tests. They're really just trying to exercise all the different ways to expand variables, so the actual commands aren't very practical.