From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Jambunathan K Newsgroups: gmane.emacs.bugs Subject: bug#9548: 24.0.50; Add vc-git-stash to keymap Date: Mon, 19 Sep 2011 03:20:25 +0530 Message-ID: <81y5xlv7tq.fsf@gmail.com> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: dough.gmane.org 1316382672 23639 80.91.229.12 (18 Sep 2011 21:51:12 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Sun, 18 Sep 2011 21:51:12 +0000 (UTC) To: 9548@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Sep 18 23:51:08 2011 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([140.186.70.17]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1R5PGV-0005Q4-Ta for geb-bug-gnu-emacs@m.gmane.org; Sun, 18 Sep 2011 23:51:08 +0200 Original-Received: from localhost ([::1]:51666 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1R5PGV-000692-HA for geb-bug-gnu-emacs@m.gmane.org; Sun, 18 Sep 2011 17:51:07 -0400 Original-Received: from eggs.gnu.org ([140.186.70.92]:49773) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1R5PGT-00068x-9m for bug-gnu-emacs@gnu.org; Sun, 18 Sep 2011 17:51:06 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1R5PGS-0004VK-Fx for bug-gnu-emacs@gnu.org; Sun, 18 Sep 2011 17:51:05 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:39509) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1R5PGS-0004VB-E4 for bug-gnu-emacs@gnu.org; Sun, 18 Sep 2011 17:51:04 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.69) (envelope-from ) id 1R5PLF-00070C-Mo for bug-gnu-emacs@gnu.org; Sun, 18 Sep 2011 17:56:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Jambunathan K Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 18 Sep 2011 21:56:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 9548 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.131638294826892 (code B ref -1); Sun, 18 Sep 2011 21:56:01 +0000 Original-Received: (at submit) by debbugs.gnu.org; 18 Sep 2011 21:55:48 +0000 Original-Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1R5PL1-0006zh-Po for submit@debbugs.gnu.org; Sun, 18 Sep 2011 17:55:48 -0400 Original-Received: from eggs.gnu.org ([140.186.70.92]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1R5PKz-0006za-EJ for submit@debbugs.gnu.org; Sun, 18 Sep 2011 17:55:46 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1R5PGB-0004Sr-0y for submit@debbugs.gnu.org; Sun, 18 Sep 2011 17:50:48 -0400 Original-Received: from lists.gnu.org ([140.186.70.17]:55475) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1R5PGA-0004Sn-Vd for submit@debbugs.gnu.org; Sun, 18 Sep 2011 17:50:46 -0400 Original-Received: from eggs.gnu.org ([140.186.70.92]:49666) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1R5PGA-00068c-2Q for bug-gnu-emacs@gnu.org; Sun, 18 Sep 2011 17:50:46 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1R5PG8-0004SS-TM for bug-gnu-emacs@gnu.org; Sun, 18 Sep 2011 17:50:46 -0400 Original-Received: from mail-iy0-f169.google.com ([209.85.210.169]:39571) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1R5PG8-0004SO-Op for bug-gnu-emacs@gnu.org; Sun, 18 Sep 2011 17:50:44 -0400 Original-Received: by iaen33 with SMTP id n33so6460681iae.0 for ; Sun, 18 Sep 2011 14:50:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=from:to:subject:date:message-id:mime-version:content-type; bh=Ryv282GPHLL+6gx4ACxYmaDoMMdQRoo8WXvs3RG+w9Y=; b=WuZ/VWTu+499PAbf8Yy0KPgTu+eAV5UcLKOkX9G9zmZb2RWSJFmVFRGaFkUFuxujPv sfTE0kEC8TGdCG7ax8elqaQfukuOKajnP3miWYYJ4m6cuo4F0Yk8AcCx+K1wcLB8agJX xQ1NWsaNgE7n1wwWRX8LGKtIAte9/oAciafCA= Original-Received: by 10.68.24.168 with SMTP id v8mr3214184pbf.23.1316382643969; Sun, 18 Sep 2011 14:50:43 -0700 (PDT) Original-Received: from JAMBU-NETBOOK ([115.241.103.207]) by mx.google.com with ESMTPS id e3sm60102845pbi.7.2011.09.18.14.50.39 (version=TLSv1/SSLv3 cipher=OTHER); Sun, 18 Sep 2011 14:50:43 -0700 (PDT) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list Resent-Date: Sun, 18 Sep 2011 17:56:01 -0400 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 1) X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:51451 Archived-At: Please add vc-git-stash to keymap[1]. I suggest the following binding S => vc-git-stash C-u S => vc-git-stash-snapshot 1. I am not sure why the stash command keys are capitalized. Pressing SHIFT seems a needless overhead to me. IMHO, they should all be lowercased. 2. I need a way to create a stash or a snapshot when there are ZERO snapshots. This is currently not possible. May be the "Stash : " header line[2] could be decorated with the needed keymap decorations. My 2 cents follows: Speaking of keymaps, the stash operations seem to be orthogonal to regular vc-dir operations. Elsewhere there were discussions about applying a series of stashes to work area - implying some a potential need for marking and reordering stash lines. What this essentially means is that stash operations are "global"/"set" operations in a *vc-dir* and accordingly they deserve a prefix of their own (in addition to the current "local, this-stash-only" keymap bindings.) In GNU Emacs 24.0.50.1 (i386-mingw-nt5.1.2600) of 2011-09-06 on 3249CTO Windowing system distributor `Microsoft Corp.', version 5.1.2600 configured using `configure --with-gcc (4.5) --no-opt' Footnotes: [1] ,----[ C-h v vc-git-stash-map RET ] | vc-git-stash-map is a variable defined in `vc-git.el'. | Its value is shown below. | | This variable is potentially risky when used as a file local variable. | | Documentation: | Not documented as a variable. | | Value: (keymap | (83 . vc-git-stash-snapshot) | (80 . vc-git-stash-pop-at-point) | (65 . vc-git-stash-apply-at-point) | (13 . vc-git-stash-show-at-point) | (61 . vc-git-stash-show-at-point) | (11 . vc-git-stash-delete-at-point) | (down-mouse-3 . vc-git-stash-menu) | (mouse-2 . ignore)) | | [back] `---- [2] #+begin_src emacs-lisp [around line 540 vc-git.el] (propertize "Stash :\n" 'face 'font-lock-type-face 'help-echo stash-help-echo) #+end_src #+begin_src emacs-lisp [around line 550 vc-git.el] (concat (propertize "Stash : " 'face 'font-lock-type-face 'help-echo stash-help-echo) (propertize "Nothing stashed" 'help-echo stash-help-echo 'face 'font-lock-variable-name-face)) #+end_src