From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Drew Adams Newsgroups: gmane.emacs.bugs Subject: bug#26242: 25.1; `dired-shrink-to-fit' warning Date: Wed, 12 Jun 2019 08:40:56 -0700 (PDT) Message-ID: <81f3c127-0080-49c4-8f17-c78cfc022570@default> References: <0159673c-b125-422a-b192-09e16132afa9@default> <87imtavo2j.fsf@mouse.gnus.org> <21a73189-b234-410a-b93d-07129bfed981@default> <85wohqakdi.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="126001"; mail-complaints-to="usenet@blaine.gmane.org" Cc: Lars Ingebrigtsen , 26242@debbugs.gnu.org To: npostavs@gmail.com Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Jun 12 17:43:17 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hb5P9-000WeA-Hg for geb-bug-gnu-emacs@m.gmane.org; Wed, 12 Jun 2019 17:43:15 +0200 Original-Received: from localhost ([::1]:33216 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hb5P6-0001o6-Tm for geb-bug-gnu-emacs@m.gmane.org; Wed, 12 Jun 2019 11:43:12 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:41235) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hb5O0-0001Jm-Ig for bug-gnu-emacs@gnu.org; Wed, 12 Jun 2019 11:42:06 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hb5Nz-0004ZU-LA for bug-gnu-emacs@gnu.org; Wed, 12 Jun 2019 11:42:04 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:48609) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hb5Ny-0004XE-2O for bug-gnu-emacs@gnu.org; Wed, 12 Jun 2019 11:42:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hb5Nx-00030U-To for bug-gnu-emacs@gnu.org; Wed, 12 Jun 2019 11:42:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Drew Adams Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 12 Jun 2019 15:42:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 26242 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: notabug Original-Received: via spool by 26242-submit@debbugs.gnu.org id=B26242.156035406911490 (code B ref 26242); Wed, 12 Jun 2019 15:42:01 +0000 Original-Received: (at 26242) by debbugs.gnu.org; 12 Jun 2019 15:41:09 +0000 Original-Received: from localhost ([127.0.0.1]:33920 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hb5N7-0002zG-97 for submit@debbugs.gnu.org; Wed, 12 Jun 2019 11:41:09 -0400 Original-Received: from aserp2130.oracle.com ([141.146.126.79]:43982) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hb5N4-0002yc-02 for 26242@debbugs.gnu.org; Wed, 12 Jun 2019 11:41:08 -0400 Original-Received: from pps.filterd (aserp2130.oracle.com [127.0.0.1]) by aserp2130.oracle.com (8.16.0.27/8.16.0.27) with SMTP id x5CFXfwS130218; Wed, 12 Jun 2019 15:41:00 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=mime-version : message-id : date : from : sender : to : cc : subject : references : in-reply-to : content-type : content-transfer-encoding; s=corp-2018-07-02; bh=wuLWkjnJNochUcHLXRYwToCtoCnwrP1tRqeyJNbivp8=; b=VvXaenYUIF98fVrEpmraPT+HqF0qRxIO6ht8yp5roMDFJVQ/MzU6J4E6UikUS+CvXNp3 RJa4o4q0IsHrrcJKJv8pQa4xXCljPl3ybVsT3EMFibrw3xhXNmu5dZUEhHLl4VYehRQ3 HRCll396Cr4f9cQ/NT7KlTg+ZlDWvPHxvo1ibCRdUor12/twhwvwLJoavd/6C3tJUpQh eT0rSoyRaiiMIfdUwj6yrJEO3dEvsFMT11O+ou3artovaHf2/ywM/VZBh5Yac4cq8drI X3ypyobIGxGWoxPtjkhluQmBlJCPbGAA5uvoLd+XZcidTfxJ+wn4XU2jj7Ft9zoW9cBG BQ== Original-Received: from userp3030.oracle.com (userp3030.oracle.com [156.151.31.80]) by aserp2130.oracle.com with ESMTP id 2t02hevhby-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 12 Jun 2019 15:40:59 +0000 Original-Received: from pps.filterd (userp3030.oracle.com [127.0.0.1]) by userp3030.oracle.com (8.16.0.27/8.16.0.27) with SMTP id x5CFdLNh165916; Wed, 12 Jun 2019 15:40:59 GMT Original-Received: from userv0121.oracle.com (userv0121.oracle.com [156.151.31.72]) by userp3030.oracle.com with ESMTP id 2t024v1y70-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 12 Jun 2019 15:40:59 +0000 Original-Received: from abhmp0011.oracle.com (abhmp0011.oracle.com [141.146.116.17]) by userv0121.oracle.com (8.14.4/8.13.8) with ESMTP id x5CFevBt015380; Wed, 12 Jun 2019 15:40:58 GMT In-Reply-To: <85wohqakdi.fsf@gmail.com> X-Priority: 3 X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.9.1 (1003210) [OL 16.0.4861.0 (x86)] X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9286 signatures=668687 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=1 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=841 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1810050000 definitions=main-1906120104 X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9286 signatures=668687 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 priorityscore=1501 malwarescore=0 suspectscore=1 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=907 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1810050000 definitions=main-1906120104 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:160449 Archived-At: > > This is what should be done, as already pointed out: > > > > What we should do is just restore the definition > > of `dired-shrink-to-fit' >=20 > The definition of dired-shrink-to-fit was never changed, so what do you > mean by "restore"? Don't remove the variable. >From Lars: > Because the variable is going away... Don't issue that byte-compiler warning, but instead do one or more of the things I suggested. Don't close the bug, saying there is nothing to change about the "fix" of adding the byte-comp warning.