From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] emacs-25 4d8fd9c 4/4: Handle "empty line" regexp in xref searches Date: Wed, 4 May 2016 02:18:30 +0300 Message-ID: <81e22f77-70c5-546c-e5fd-170d4e2272d8@yandex.ru> References: <20160503230207.9960.96573@vcs.savannah.gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1462317595 30903 80.91.229.3 (3 May 2016 23:19:55 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 3 May 2016 23:19:55 +0000 (UTC) To: emacs-devel@gnu.org, Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed May 04 01:19:50 2016 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1axjba-00032S-1K for ged-emacs-devel@m.gmane.org; Wed, 04 May 2016 01:19:50 +0200 Original-Received: from localhost ([::1]:44527 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1axjbW-0001Mr-5B for ged-emacs-devel@m.gmane.org; Tue, 03 May 2016 19:19:46 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:35891) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1axjbE-00019x-4D for emacs-devel@gnu.org; Tue, 03 May 2016 19:19:34 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1axjb2-0002ZV-Jk for emacs-devel@gnu.org; Tue, 03 May 2016 19:19:22 -0400 Original-Received: from mail-wm0-x242.google.com ([2a00:1450:400c:c09::242]:36023) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1axjaq-0002Pt-A3; Tue, 03 May 2016 19:19:05 -0400 Original-Received: by mail-wm0-x242.google.com with SMTP id w143so6719090wmw.3; Tue, 03 May 2016 16:18:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:subject:to:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding; bh=XdKlUVDBv6tKuUSAsNaHq46rH1eIrFa/yAX/K1rrJ+c=; b=HP0JAILs3R/XG/lIB/1/yGdVaOuvS1TNi/EFFTR3AL14Cehyjc0BSlL6dKWtMcF9Xy kQg5SBS9Ugyb/JVlysptrGYBpdvjJPzp403v7pK0vdYH8HouNrJAEXidg5p99eOU+c9o 1JhbIs+1ANs6iImXWrZwaxY6dOLLL7NAd0/U/I5XTrovz425ZRRnREdGU6oiCbcB6Cuf UJCOVDwKTHg26IsNg0BtPPcTb4b/frrjWXiCDipPl4dpayzNl6HXf4gl3rl/Yw71dLus Tep6mKKawSikzAk+mrP6tvfGoaolLn6t4PAtckEhbKmu4kUMdt7WruJ+1IBOtN8injTW h2Fg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:subject:to:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-transfer-encoding; bh=XdKlUVDBv6tKuUSAsNaHq46rH1eIrFa/yAX/K1rrJ+c=; b=TBDBET1v9b8cX/krB6x7OIflktZ06E0V8GGp817M2hheRWypz3TNkrMzd06jVxfmPN ZhnwYEyrcYAJoyw/KNK575aRDy2zsq7ldQ1WIDvXd+Khr/2ZXmO/CoupKzJJbko7a844 Det2WxB6eab26hwLPofzZO4/aHE/pEgTmIBB866ivOKro0LU65/mAcfxi0GR+68tKlsz 15ArgXY7y+B+/d18/52zITtYbmeEtXC/fRvSSKDx32xygpnOPjXNsOTGsS8Pgk2r6S35 IdvpK7q/T1Uo+mZ3lhG1dd0SX8x2W1zuRcM5zvQ0wAhtIdMfpp8wi7f8z5fhme8TpKVq 7SrQ== X-Gm-Message-State: AOPr4FVvt3lo9mH33Pkg0ILnPHGYj+ejTCSl02qnfQvvEStyLiAb/7fgouNIkJVSPl2Zdg== X-Received: by 10.28.22.65 with SMTP id 62mr28325978wmw.32.1462317512499; Tue, 03 May 2016 16:18:32 -0700 (PDT) Original-Received: from [192.168.1.2] ([185.105.175.24]) by smtp.googlemail.com with ESMTPSA id n66sm924444wmn.7.2016.05.03.16.18.31 (version=TLSv1/SSLv3 cipher=OTHER); Tue, 03 May 2016 16:18:32 -0700 (PDT) User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.1 In-Reply-To: X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2a00:1450:400c:c09::242 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:203559 Archived-At: Hi John, On 05/04/2016 02:08 AM, John Wiegley wrote: >> branch: emacs-25 >> commit 4d8fd9cf338cf9b5dfc613657adfeabff2d9c14e >> Author: Dmitry Gutov >> Commit: Dmitry Gutov > >> * lisp/progmodes/xref.el (xref--collect-matches-1): Stop after one >> match if re-search-forward doesn't move point (bug#23426). > Was this issue on our blocking list? Apparently not. > Should it have been? I believe so, yes. But if Eli thinks otherwise, feel free to revert it. There was another, considerably less critical, but also less risky change in the same push (6f82d8e). If anything, I expected that one to spark some discussion. It's straight up performance improvement, however. Again, feel free to revert in on emacs-25. Then I'll avoid making similar changes there.