From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Drew Adams Newsgroups: gmane.emacs.bugs Subject: bug#27583: 24.5; `info.el': some test for (eq major-mode 'Info-mode) Date: Tue, 4 Jul 2017 19:11:04 -0700 (PDT) Message-ID: <81c97390-9678-4a2e-9772-f2ba9378ecd0@default> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Trace: blaine.gmane.org 1499220741 6461 195.159.176.226 (5 Jul 2017 02:12:21 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Wed, 5 Jul 2017 02:12:21 +0000 (UTC) To: 27583@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Jul 05 04:12:17 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dSZnZ-0000yJ-6q for geb-bug-gnu-emacs@m.gmane.org; Wed, 05 Jul 2017 04:12:13 +0200 Original-Received: from localhost ([::1]:43745 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dSZnZ-00026l-Ps for geb-bug-gnu-emacs@m.gmane.org; Tue, 04 Jul 2017 22:12:13 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:59972) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dSZnU-00026g-PA for bug-gnu-emacs@gnu.org; Tue, 04 Jul 2017 22:12:09 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dSZnO-0007oj-5g for bug-gnu-emacs@gnu.org; Tue, 04 Jul 2017 22:12:08 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:50100) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dSZnO-0007oZ-2L for bug-gnu-emacs@gnu.org; Tue, 04 Jul 2017 22:12:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1dSZnN-0005x5-Ub for bug-gnu-emacs@gnu.org; Tue, 04 Jul 2017 22:12:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Drew Adams Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 05 Jul 2017 02:12:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 27583 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.149922068422835 (code B ref -1); Wed, 05 Jul 2017 02:12:01 +0000 Original-Received: (at submit) by debbugs.gnu.org; 5 Jul 2017 02:11:24 +0000 Original-Received: from localhost ([127.0.0.1]:52777 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dSZmm-0005wE-7v for submit@debbugs.gnu.org; Tue, 04 Jul 2017 22:11:24 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:40637) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dSZmk-0005w2-2H for submit@debbugs.gnu.org; Tue, 04 Jul 2017 22:11:22 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dSZme-0007M9-2Q for submit@debbugs.gnu.org; Tue, 04 Jul 2017 22:11:16 -0400 Original-Received: from lists.gnu.org ([2001:4830:134:3::11]:50856) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1dSZmd-0007M2-VT for submit@debbugs.gnu.org; Tue, 04 Jul 2017 22:11:15 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:59841) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dSZmd-0001sM-02 for bug-gnu-emacs@gnu.org; Tue, 04 Jul 2017 22:11:15 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dSZmY-0007JC-0e for bug-gnu-emacs@gnu.org; Tue, 04 Jul 2017 22:11:14 -0400 Original-Received: from aserp1040.oracle.com ([141.146.126.69]:35305) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1dSZmX-0007IF-MP for bug-gnu-emacs@gnu.org; Tue, 04 Jul 2017 22:11:09 -0400 Original-Received: from aserv0022.oracle.com (aserv0022.oracle.com [141.146.126.234]) by aserp1040.oracle.com (Sentrion-MTA-4.3.2/Sentrion-MTA-4.3.2) with ESMTP id v652B7kX029352 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Wed, 5 Jul 2017 02:11:07 GMT Original-Received: from userv0122.oracle.com (userv0122.oracle.com [156.151.31.75]) by aserv0022.oracle.com (8.14.4/8.14.4) with ESMTP id v652B6wc016349 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Wed, 5 Jul 2017 02:11:06 GMT Original-Received: from abhmp0018.oracle.com (abhmp0018.oracle.com [141.146.116.24]) by userv0122.oracle.com (8.14.4/8.14.4) with ESMTP id v652B5XL020249 for ; Wed, 5 Jul 2017 02:11:06 GMT X-Priority: 3 X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.9.1 (1003210) [OL 12.0.6770.5000 (x86)] X-Source-IP: aserv0022.oracle.com [141.146.126.234] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.4.x-2.6.x [generic] [fuzzy] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:134193 Archived-At: Most of the places where `major-mode' is tested use a test like this: (derived-mode-p 'Info-mode). But there are still a few places where this is done: (eq major-mode 'Info-mode). I think (but am not positive) that each of the latter tests should be changed to use `derived-mode-p', to let users and libraries define and use modes that are derived from `Info-mode'. It looks like the places that still use (eq major-mode 'Info-mode) constitute code that doesn't get much love. The occurrences are in these 3 things: Info-hide-note-references (in the option's :set function) info-display-manual info--manual-names (used only by info-display-manual) In GNU Emacs 24.5.1 (i686-pc-mingw32) of 2015-04-11 on LEG570 Windowing system distributor `Microsoft Corp.', version 6.1.7601 Configured using: `configure --prefix=3D/c/usr --host=3Di686-pc-mingw32'