all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Drew Adams <drew.adams@oracle.com>
To: 27583@debbugs.gnu.org
Subject: bug#27583: 24.5; `info.el': some test for (eq major-mode 'Info-mode)
Date: Tue, 4 Jul 2017 19:11:04 -0700 (PDT)	[thread overview]
Message-ID: <81c97390-9678-4a2e-9772-f2ba9378ecd0@default> (raw)

Most of the places where `major-mode' is tested use a test like this:
(derived-mode-p 'Info-mode).  But there are still a few places where
this is done: (eq major-mode 'Info-mode).

I think (but am not positive) that each of the latter tests should be
changed to use `derived-mode-p', to let users and libraries define and
use modes that are derived from `Info-mode'.

It looks like the places that still use (eq major-mode 'Info-mode)
constitute code that doesn't get much love.  The occurrences are in
these 3 things:

 Info-hide-note-references (in the option's :set function)
 info-display-manual
 info--manual-names (used only by info-display-manual)



In GNU Emacs 24.5.1 (i686-pc-mingw32)
 of 2015-04-11 on LEG570
Windowing system distributor `Microsoft Corp.', version 6.1.7601
Configured using:
 `configure --prefix=/c/usr --host=i686-pc-mingw32'





             reply	other threads:[~2017-07-05  2:11 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-07-05  2:11 Drew Adams [this message]
2019-08-27  1:39 ` bug#27583: 24.5; `info.el': some test for (eq major-mode 'Info-mode) Stefan Kangas
2019-08-27  2:33   ` Drew Adams
2019-09-03 18:23     ` Stefan Kangas
2019-09-07 22:20       ` Stefan Kangas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=81c97390-9678-4a2e-9772-f2ba9378ecd0@default \
    --to=drew.adams@oracle.com \
    --cc=27583@debbugs.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.